Page MenuHomePhabricator
Create Task
Maniphest T121471

[2.1.136-alpha-2015-12-14 ] Sliding footer for 'saved for offline reading' displays article title with underscores
Closed, ResolvedPublic
Actions

Description

Description

If articles with two and more words in their titles are being saved, the sliding footer will display underscore after each word in article's title.

Steps to reproduce

  1. Search for articles with more than one word in their titles
  2. When viewing the article, click to Save.
  3. The sliding footer will display the article tile with underscore after each word

Expected results

Article title should be displayed exactly as it's displayed when article is viewed.

Actual results

Screenshot_2015-12-14-16-13-11.png (1×1 px, 155 KB)

Environments observed

App version: 2.1.136-alpha-2015-12-14
Android OS versions: Android 5.1.1
Device model: Nexus 5
Device language: English

Details

SubjectRepoBranchLines +/-
Display proper title when saving page from menu.apps/android/wikipediamaster+1 -1
Customize query in gerrit

Event Timeline

Etonkovidova created this task.Dec 15 2015, 12:51 AM
Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added a project: Wikipedia-Android-App-Backlog.
Etonkovidova added subscribers: Aklapper, StudiesWorld, Etonkovidova.
gerritbot subscribed.Dec 16 2015, 2:09 PM

Change 259491 had a related patch set uploaded (by Dbrant):
Display proper title when saving page from menu.

https://gerrit.wikimedia.org/r/259491

gerritbot added a project: Patch-For-Review.Dec 16 2015, 2:09 PM
Dbrant claimed this task.Dec 16 2015, 2:09 PM
Dbrant added a project: Mobile-App-Android-Sprint-72-Hafnium.
Dbrant set Security to None.
Dbrant moved this task from To Do to Code Review on the Mobile-App-Android-Sprint-72-Hafnium board.
Dbrant added a subscriber: Mobile-App-Android-Sprint-72-Hafnium.
Dbrant removed a subscriber: Mobile-App-Android-Sprint-72-Hafnium.
Dbrant moved this task from Needs Triage to Current Sprint on the Wikipedia-Android-App-Backlog board.Dec 16 2015, 3:03 PM
gerritbot added a comment.Dec 16 2015, 3:07 PM

Change 259491 merged by jenkins-bot:
Display proper title when saving page from menu.

https://gerrit.wikimedia.org/r/259491

Dbrant moved this task from Code Review to QA Signoff on the Mobile-App-Android-Sprint-72-Hafnium board.Dec 18 2015, 2:50 PM
Etonkovidova added a comment.Dec 18 2015, 9:01 PM

Checked with 2.1.136-alpha-2015-12-18 on Nexus 5 (Android 5.1.1) - no underscores(or anything extra) in articles' titles in the sliding footer.

Screenshot_2015-12-18-12-58-04.png (1×1 px, 225 KB)

Screenshot_2015-12-18-12-55-03.png (1×1 px, 737 KB)

Etonkovidova moved this task from QA Signoff to Ready for Signoff on the Mobile-App-Android-Sprint-72-Hafnium board.Dec 18 2015, 9:01 PM
Dbrant moved this task from Ready for Signoff to Done on the Mobile-App-Android-Sprint-72-Hafnium board.Jan 4 2016, 5:41 PM
Dbrant closed this task as Resolved.Jan 4 2016, 5:43 PM
Dbrant moved this task from Current Sprint to Resolved/Invalid/Declined/Legacy on the Wikipedia-Android-App-Backlog board.Jan 18 2016, 3:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL