generator=watchlist complains about gwlprop even if it's not set
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Catrope
	Jun 15 2007, 2:59 PM

Description

Fixes unjustified generator=watchlist gwlprop error

http://www.mediawiki.org/w/api.php?action=query&prop=info&generator=watchlist

gives:

while gwlprop wasn't set. This is because the code assumes the default for gwlprop (ids|title|flags), and then complains that it's not empty. Setting gwlprop to an empty value doesn't work either, so there is currently no way to use list=watchlist as a generator.

The attached patch fixes this by only throwing an error if gwlprop is not set to its default value. The downside of this is that

api.php?action=query&prop=info&generator=watchlist&gwlprop=ids|title|flags

won't cause an error, but it won't affect the query result either.

Version: 1.11.x
Severity: normal

Attached:

fix-gwlparams.patch679 BDownload

Details

Reference: bz10274

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:52 PM

• bzimport added a project: MediaWiki-Action-API.

• bzimport set Reference to bz10274.

• bzimport added a subscriber: Unknown Object (MLST).

Catrope created this task.Jun 15 2007, 2:59 PM

Thanks for the report and the patch. I will allow gwlprop to be specified to be consistent and to simplify design.

Fixed in r23043

Oops, forgot to mark as fixed.

generator=watchlist complains about gwlprop even if it's not setClosed, ResolvedPublicActions

Description

Details

Event Timeline

generator=watchlist complains about gwlprop even if it's not set
Closed, ResolvedPublic
Actions