Page MenuHomePhabricator
Create Task
Maniphest T123756

Notifications with no primary link do not get the correct text color
Closed, ResolvedPublic
Actions

Description

When I open the notification fly-out menu, all read notifcations are displayed as they should be (light grey background on dark grey text), except of the Welcome and E-Mail notifications displayed, where the text is black instead of dark grey.

  • M137 Black Echo text in a read notification
    10

    • Details

    SubjectRepoBranchLines +/-
    Set text color on header directly, not on <a>mediawiki/extensions/Echomaster+3 -6
    Customize query in gerrit

    Related Objects

    Event Timeline

    MGChecker created this task.Jan 15 2016, 6:00 PM
    MGChecker raised the priority of this task from to Needs Triage.
    MGChecker updated the task description. (Show Details)
    MGChecker added a project: Notifications.
    MGChecker added subscribers: MGChecker, Aklapper, Luke081515.
    Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJan 15 2016, 6:00 PM
    Restricted Application added a subscriber: StudiesWorld. · View Herald Transcript
    Catrope subscribed.Jan 15 2016, 6:02 PM

    Could you add a screenshot?

    MGChecker added a mock: M137: Black Echo text in a read notification.Jan 15 2016, 6:39 PM
    Catrope edited projects, added Collaboration-Team-Archive-2015-2016; removed Collaboration-Team-Triage.Jan 15 2016, 11:13 PM
    Catrope set Security to None.
    • Mattflaschen-WMF updated the task description. (Show Details)Jan 15 2016, 11:35 PM
    MGChecker renamed this task from Read E-Mail notifcation isn't displayed correctly to Read E-Mail and Welcome notifcations aren't displayed correctly.Jan 17 2016, 11:10 AM
    MGChecker updated the task description. (Show Details)
    MGChecker added a comment.Jan 17 2016, 11:36 AM

    For Welcome notifcations it's the same.

    Catrope added a comment.Jan 19 2016, 2:20 AM

    Ha! Good catch. This happens in cases where there is no primary link.

    Catrope renamed this task from Read E-Mail and Welcome notifcations aren't displayed correctly to Notifications with no primary link do not get the correct text color.Jan 19 2016, 2:20 AM
    gerritbot subscribed.Jan 19 2016, 2:27 AM

    Change 264913 had a related patch set uploaded (by Catrope):
    Set text color on header directly, not on <a>

    https://gerrit.wikimedia.org/r/264913

    gerritbot added a project: Patch-For-Review.Jan 19 2016, 2:27 AM
    Catrope claimed this task.Jan 19 2016, 2:28 AM
    Catrope moved this task from Untriaged to In Development on the Collaboration-Team-Archive-2015-2016 board.
    Catrope moved this task from In Development to Needs Review on the Collaboration-Team-Archive-2015-2016 board.
    Catrope moved this task from Needs Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.Jan 19 2016, 3:21 AM
    gerritbot added a comment.Jan 19 2016, 3:23 AM

    Change 264913 merged by jenkins-bot:
    Set text color on header directly, not on <a>

    https://gerrit.wikimedia.org/r/264913

    ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)).Jan 19 2016, 4:01 AM
    Etonkovidova subscribed.Jan 19 2016, 8:24 PM

    Checked the fix in betalabs -both E-ail and Welcome notifications are displayed grey in the Notifications flyout.

    Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Jan 19 2016, 8:34 PM
    • jmatazzoni closed this task as Resolved.Feb 17 2016, 12:54 AM
    Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL