Page MenuHomePhabricator

Message 'jsonschema-invalid-notinenum' is being passed wrong parameters
Closed, ResolvedPublic

Description

The message 'jsonschema-invalid-notinenum' is being passed wrong parameters, at least sometimes (T123840).

$msg = JsonUtil::uiMessage( 'jsonschema-invalid-notinenum', $this->node, $this->getDataPathTitles() );

Where JsonUtil::uiMessage is a wrapper for wfMessage and $this->node is an array (possibly associative) representing current node. wfMessage interprets this array as message parameters, ignoring the second function call parameter. Not sure how this ever worked.

Event Timeline

matmarex created this task.Jan 16 2016, 7:29 PM
matmarex raised the priority of this task from to Normal.
matmarex updated the task description. (Show Details)
matmarex added a subscriber: matmarex.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 16 2016, 7:29 PM
matmarex claimed this task.Jan 16 2016, 7:43 PM

Change 264575 had a related patch set uploaded (by Bartosz Dziewoński):
Stringify message parameters for 'jsonschema-invalid-notinenum'

https://gerrit.wikimedia.org/r/264575

Change 264575 merged by jenkins-bot:
Stringify message parameters for 'jsonschema-invalid-notinenum'

https://gerrit.wikimedia.org/r/264575

matmarex closed this task as Resolved.Feb 18 2016, 8:42 PM
matmarex removed a project: Patch-For-Review.
matmarex set Security to None.