Page MenuHomePhabricator

MediaWiki:Sitenotice close - should not be enclosed in [ ] when rendered.
Closed, DeclinedPublic

Description

Please remove the [ ] surrounding [[MediaWiki:Sitenotice close]] from the page layout. If such Brackes are desired, they should rather be part of the message, than part of the fixed page layout.

See current http://ksh.wikipedia.org/wiki/MediaWiki:Sitenotice_close (with a small enough window width) as an example of the uglyness and waste of space that may result from the forced inclusion of [ ].


Version: 1.11.x
Severity: enhancement
URL: http://ksh.wikipedia.org/wiki/MediaWiki:Sitenotice_close

Details

Reference
bz10416

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 9:55 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz10416.
bzimport added a subscriber: Unknown Object (MLST).

robchur wrote:

There is considerable precedent, however, for keeping incidental punctuation like this out of the message text; in a lot of cases, it looks much *better*. There are reasonable arguments either way.

I agree in general, and in the many, more repetitive cases.

This specific message is occurring only once in one place or not at all. There is no need to keep a common "look and feel" with a single message, but as the sample shows, there is a considerable drawback, at least in the monobook skin, when two messages appearing besides each other, and going together, cannont be formatted the same way.

ayg wrote:

Punctuation should always be localized, as far as I'm concerned. I don't see any reason for it to ever be hardcoded into the software. Of course, actually moving the punctuation into the message is a nuisance in that the message should really be renamed and backwards compatibility kept if it's to be done properly.

Same link style as used elsewhere for consistency.

ayg wrote:

Maybe use 'editsection-brackets' (preferably renamed to 'link-brackets' or something) from r23645? Assuming that stays.

@brion: There is not compatibility to maintai with "elsewhere" - the contary is true, this is a solitarian message, and using layout styles of other messages is outright wrong.

To be more precise: []s are being used auto-inserted next to headlines genereated from ==, ===, etc. Here is no such headline next to Sitenotice_close.

@Simetrical: This does NOT look like a solution for me. If I understood it right, you can choose to remove the []s from BOTH editsections AND Sitenotice close, or from none of them.

Sitenotice close is a completely different type of message from Editsection. There is no point in forcibly putting them together. I don't mind [editsection] to remain as it is,
but I do want

[

Sitenotice
close

]

to look more proper.

@brion: There is not compatibility to maintai with "elsewhere" - the contary is
true, this is a solitarian message, and using layout styles of other messages
is outright wrong.

Well, I respectfully disagree. As another part of the wiki user interface, it should remain consistent with other parts of the wiki user interface unless there is a good reason for it. The only reason I see stated above is that you think they're ugly, which I disagree with.