Page MenuHomePhabricator
Create Task
Maniphest T124608

Deletion of flow post with title "{{Wikipedia:Administrators' noticeboard/Incidents}}" results in transclusion Special:Log/delete
Closed, ResolvedPublic
Actions

Assigned To
• Mattflaschen-WMF
Authored By
MarcoAurelio
Jan 24 2016, 3:14 PM
Tags
Referenced Files
Unknown Object (File)
Jan 24 2016, 3:14 PM
Subscribers
Aklapper
Ciencia_Al_Poder
Krenair
MarcoAurelio
• Mattflaschen-WMF
StudiesWorld
valhallasw

Description

https://en.wikipedia.org/w/index.php?title=Special:Log/delete&offset=20160124143208&type=delete&user=

{F3278921}

Log now transcludes pages.

Details

SubjectRepoBranchLines +/-
Don't accidentally parse topic title on log pagesmediawiki/extensions/Flowwmf/1.27.0-wmf.11+13 -8
Don't accidentally parse topic title on log pagesmediawiki/extensions/Flowwmf/1.27.0-wmf.10+13 -8
Don't accidentally parse topic title on log pagesmediawiki/extensions/Flowmaster+13 -8
Customize query in gerrit

Related Objects

Event Timeline

MarcoAurelio created this task.Jan 24 2016, 3:14 PM
MarcoAurelio raised the priority of this task from to Unbreak Now!.
MarcoAurelio updated the task description. (Show Details)
MarcoAurelio added a project: MediaWiki-Logevents.
MarcoAurelio subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 24 2016, 3:14 PM
MarcoAurelio added a comment.Jan 24 2016, 3:20 PM

Looks it's because of this Flow post and its title "{{Wikipedia:Administrators' noticeboard/Incidents}}".

MarcoAurelio renamed this task from English Wikipedia deletion log broken? to English Wikipedia deletion log broken.Jan 24 2016, 3:24 PM
MarcoAurelio updated the task description. (Show Details)
MarcoAurelio removed a project: MediaWiki-Logevents.
MarcoAurelio set Security to None.
valhallasw lowered the priority of this task from Unbreak Now! to Needs Triage.Jan 24 2016, 3:31 PM
valhallasw subscribed.

Although template insertion is an issue, the contents just continue under it.

Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptJan 24 2016, 3:31 PM
valhallasw added projects: MediaWiki-General, StructuredDiscussions.Jan 24 2016, 3:32 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJan 24 2016, 3:32 PM
valhallasw renamed this task from English Wikipedia deletion log broken to Deletion of flow post with title "{{Wikipedia:Administrators' noticeboard/Incidents}}" results in transclusion Special:Log/delete.Jan 24 2016, 3:34 PM
Ciencia_Al_Poder subscribed.Jan 24 2016, 3:36 PM

Related: T120291: wikitext in flow titles is parsed (HTML tags like <tt> and templates) on echo notifications

Ciencia_Al_Poder updated the task description. (Show Details)Jan 24 2016, 3:39 PM
Krenair triaged this task as High priority.Jan 24 2016, 10:38 PM
Krenair subscribed.
• Mattflaschen-WMF claimed this task.Jan 25 2016, 6:14 PM
• Mattflaschen-WMF raised the priority of this task from High to Unbreak Now!.
• Mattflaschen-WMF edited projects, added Collaboration-Team-Archive-2015-2016; removed Collaboration-Team-Triage.
• Mattflaschen-WMF subscribed.
gerritbot subscribed.Jan 27 2016, 8:51 PM

Change 266908 had a related patch set uploaded (by Mattflaschen):
Don't accidentally parse topic title on log pages

https://gerrit.wikimedia.org/r/266908

gerritbot added a project: Patch-For-Review.Jan 27 2016, 8:51 PM
• Mattflaschen-WMF moved this task from Untriaged to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Jan 27 2016, 8:56 PM
gerritbot added a comment.Jan 27 2016, 9:10 PM

Change 266908 merged by jenkins-bot:
Don't accidentally parse topic title on log pages

https://gerrit.wikimedia.org/r/266908

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)).Jan 27 2016, 10:00 PM
gerritbot added a comment.Jan 27 2016, 11:29 PM

Change 266938 had a related patch set uploaded (by Mattflaschen):
Don't accidentally parse topic title on log pages

https://gerrit.wikimedia.org/r/266938

gerritbot added a comment.Jan 27 2016, 11:29 PM

Change 266939 had a related patch set uploaded (by Mattflaschen):
Don't accidentally parse topic title on log pages

https://gerrit.wikimedia.org/r/266939

gerritbot added a comment.Jan 28 2016, 12:22 AM

Change 266938 merged by jenkins-bot:
Don't accidentally parse topic title on log pages

https://gerrit.wikimedia.org/r/266938

gerritbot added a comment.Jan 28 2016, 12:25 AM

Change 266939 merged by jenkins-bot:
Don't accidentally parse topic title on log pages

https://gerrit.wikimedia.org/r/266939

• Mattflaschen-WMF added a comment.Jan 28 2016, 12:45 AM

Krenair swatted out our fix, and it is working for me in production:

https://en.wikipedia.org/w/index.php?title=Special:Log/delete&user=Reedy&limit=1

https://www.mediawiki.org/w/index.php?title=Special%3ALog&type=delete&user=mattflaschen-WMF&page=&year=&month=-1&tagfilter=&limit=1

Looks like maybe the original test case was edited to work around this bug?

(I did confirm it on MediaWiki.org and locally before the fix.)

• Mattflaschen-WMF moved this task from Needs Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.Jan 28 2016, 12:46 AM
ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)).Jan 28 2016, 1:00 AM
Ciencia_Al_Poder closed this task as Resolved.Jan 28 2016, 7:54 PM
Ciencia_Al_Poder removed a project: Patch-For-Review.
Ciencia_Al_Poder removed a subscriber: gerritbot.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL