Page MenuHomePhabricator
Create Task
Maniphest T125491

[GlobalTitleFail] RequestContext::getTitle called by ApiDocumentationTest->checkMessage/ApiBase::makeMessage/Message->setContext/DerivativeContext->getTitle/RequestContext->getTitle with no title set
Closed, ResolvedPublic
Actions

Description

While debugging a phpunit test failure, I noticed that mw-debug-cli.log contains hundreds of kilobytes of this repeated message:
[GlobalTitleFail] RequestContext::getTitle called by ApiDocumentationTest->checkMessage/ApiBase::makeMessage/Message->setContext/DerivativeContext->getTitle/RequestContext->getTitle with no title set

Example: https://integration.wikimedia.org/ci/job/mwext-testextension-php55/8/artifact/log/mw-debug-cli.log

Details

SubjectRepoBranchLines +/-
Set title on context in ApiDocumentationTestmediawiki/coremaster+3 -0
Customize query in gerrit

Event Timeline

Nikerabbit created this task.Feb 2 2016, 8:48 AM
Nikerabbit raised the priority of this task from to Needs Triage.
Nikerabbit updated the task description. (Show Details)
Nikerabbit added projects: MediaWiki-Core-Tests, MediaWiki-Action-API.
Nikerabbit subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 2 2016, 8:48 AM
Anomie removed a project: MediaWiki-Action-API.Feb 2 2016, 2:21 PM
Anomie set Security to None.
Anomie subscribed.

The fact that the unit testing framework doesn't set a title on the main RequestContext has nothing to do with MediaWiki-Action-API.

gerritbot subscribed.Feb 2 2016, 2:28 PM

Change 267883 had a related patch set uploaded (by Anomie):
Set title on context in ApiDocumentationTest

https://gerrit.wikimedia.org/r/267883

gerritbot added a project: Patch-For-Review.Feb 2 2016, 2:28 PM
gerritbot added a comment.Feb 3 2016, 12:40 PM

Change 267883 merged by jenkins-bot:
Set title on context in ApiDocumentationTest

https://gerrit.wikimedia.org/r/267883

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-02-09_(1.27.0-wmf.13)).Feb 3 2016, 1:00 PM
Anomie closed this task as Resolved.Feb 3 2016, 2:20 PM
Anomie claimed this task.
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL