Page MenuHomePhabricator
Create Task
Maniphest T126780

UWDetails objects are being constructed from scratch twice for each upload: once when stashed, once when moving to Details step
Closed, ResolvedPublic
Actions

Description

UWDetails objects are being constructed from scratch twice for each uploads: once when stashes, once when moving to Details step. This is super silly and super slow D:

Details

SubjectRepoBranchLines +/-
Don't construct UploadWizardDetails twice for each UploadWizardUploadmediawiki/extensions/UploadWizardmaster+0 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Feb 12 2016, 5:41 PM
matmarex claimed this task.
matmarex raised the priority of this task from to High.
matmarex updated the task description. (Show Details)
matmarex added projects: Multimedia, UploadWizard.
matmarex subscribed.
Restricted Application added subscribers: Steinsplitter, Matanya, Aklapper. · View Herald TranscriptFeb 12 2016, 5:41 PM
matmarex added a parent task: T121901: UploadWizard UI performance abysmal when adding many files to upload at once.Feb 12 2016, 5:42 PM
matmarex renamed this task from UWDetails objects are being constructed from scratch twice for each uploads: once when stashes, once when moving to Details step to UWDetails objects are being constructed from scratch twice for each upload: once when stashed, once when moving to Details step.Feb 16 2016, 4:48 PM
matmarex set Security to None.
matmarex closed this task as Invalid.Feb 18 2016, 5:09 PM

Hmm, I can't reproduce this anymore. I'm not sure where I've seen this. I swear it was real :(

matmarex reopened this task as Open.Feb 18 2016, 6:18 PM

Oh wait, I'm stupid, I was looking at the wrong function.

gerritbot subscribed.Feb 18 2016, 6:27 PM

Change 271570 had a related patch set uploaded (by Bartosz Dziewoński):
Don't construct UploadWizardDetails twice for each UploadWizardUpload

https://gerrit.wikimedia.org/r/271570

gerritbot added a project: Patch-For-Review.Feb 18 2016, 6:27 PM
gerritbot added a comment.Feb 18 2016, 9:08 PM

Change 271570 merged by jenkins-bot:
Don't construct UploadWizardDetails twice for each UploadWizardUpload

https://gerrit.wikimedia.org/r/271570

matmarex closed this task as Resolved.Feb 18 2016, 9:29 PM
matmarex removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).Feb 18 2016, 10:00 PM
matmarex mentioned this in T121901: UploadWizard UI performance abysmal when adding many files to upload at once.Feb 19 2016, 10:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL