Page MenuHomePhabricator

UWDetails objects are being constructed from scratch twice for each upload: once when stashed, once when moving to Details step
Closed, ResolvedPublic

Description

UWDetails objects are being constructed from scratch twice for each uploads: once when stashes, once when moving to Details step. This is super silly and super slow D:

Event Timeline

matmarex claimed this task.
matmarex raised the priority of this task from to High.
matmarex updated the task description. (Show Details)
matmarex added projects: Multimedia, UploadWizard.
matmarex added a subscriber: matmarex.
matmarex renamed this task from UWDetails objects are being constructed from scratch twice for each uploads: once when stashes, once when moving to Details step to UWDetails objects are being constructed from scratch twice for each upload: once when stashed, once when moving to Details step.Feb 16 2016, 4:48 PM
matmarex set Security to None.

Hmm, I can't reproduce this anymore. I'm not sure where I've seen this. I swear it was real :(

Oh wait, I'm stupid, I was looking at the wrong function.

Change 271570 had a related patch set uploaded (by Bartosz Dziewoński):
Don't construct UploadWizardDetails twice for each UploadWizardUpload

https://gerrit.wikimedia.org/r/271570

Change 271570 merged by jenkins-bot:
Don't construct UploadWizardDetails twice for each UploadWizardUpload

https://gerrit.wikimedia.org/r/271570