Page MenuHomePhabricator

Provide a way to force the default prefix suggester over completion suggester
Closed, ResolvedPublic

Description

There are a couple unique use cases, such as http://tools.wmflabs.org/pageviews/, that want to be able to show redirects just as they are. Supporting this use case in the completion suggester itself might be a pain, but we could offer a way to fallback to the old prefix search.

Event Timeline

EBernhardson raised the priority of this task from to Needs Triage.
EBernhardson updated the task description. (Show Details)
EBernhardson added a subscriber: EBernhardson.

Do we need it in all API functions, specific API? Because now all APIs go to SearchEngine implementation, so implementations are free to do what they want. We'd have to either force it on API level (calling default one instead of completion one) or somehow control all implementations.

I think for this use case supporting it only in ApiQueryPrefixSearch would be sufficient. I'm not sure the best way of exposing this to api users, most obvious to them would be to have an explicit api flag but i'm not sure yet what it would look like. Needs some consideration.

If it's ApiQueryPrefixSearch only then it's easy to have a query parameter and let it call defaultPrefixSearch().

Change 271926 had a related patch set uploaded (by Smalyshev):
Allow falling back to old search deterministically

https://gerrit.wikimedia.org/r/271926

Change 271927 had a related patch set uploaded (by Smalyshev):
Allow to specify default search in ApiQueryPrefixSearch

https://gerrit.wikimedia.org/r/271927

Change 271926 merged by jenkins-bot:
Allow falling back to old search deterministically

https://gerrit.wikimedia.org/r/271926

Change 271927 abandoned by Smalyshev:
Allow to specify default search in ApiQueryPrefixSearch

https://gerrit.wikimedia.org/r/271927

Deskana triaged this task as Medium priority.