Page MenuHomePhabricator

Mholloway (Michael Holloway)
Software Engineer, WMF Product Infrastructure Team

Projects (15)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 30 2015, 8:44 PM (251 w, 6 d)
Availability
Available
IRC Nick
mdholloway
LDAP User
Mholloway
MediaWiki User
MHolloway (WMF) [ Global Accounts ]

Recent Activity

Tue, Jan 21

Mholloway committed rWSWF7c8368dca3aa: puller.sh: hard-reset the repo before fetching changes (authored by Mholloway).
puller.sh: hard-reset the repo before fetching changes
Tue, Jan 21, 6:39 PM

Mon, Jan 20

Mholloway committed rGMOD2a1f4931b2a7: Update mobileapps to 1848cf5 (authored by Mholloway).
Update mobileapps to 1848cf5
Mon, Jan 20, 3:53 PM
Mholloway moved T229437: How should we expose historical information on suggested labels (and vote(s) on them)? from Needs design to Under discussion on the MachineVision board.
Mon, Jan 20, 6:54 AM · Structured-Data-Backlog, MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Product-Infrastructure-Team-Backlog, MachineVision
Mholloway moved T241072: Update the "waiting period" implemenation so as not to block the job queue from Under discussion to In development on the MachineVision board.
Mon, Jan 20, 6:53 AM · Patch-For-Review, Structured Data Engineering, Structured-Data-Backlog (Current Work), Product-Infrastructure-Team-Backlog, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), MachineVision

Wed, Jan 15

Mholloway updated the task description for T218733: Migrate mobileapps to k8s and node 10.
Wed, Jan 15, 5:02 PM · Product-Infrastructure-Team-Backlog, Page Content Service, Mobile-Content-Service
Mholloway added a project to T225107: Migrate recommendation-api to node 10: Recommendation-API.
Wed, Jan 15, 4:59 PM · Recommendation-API, Product-Infrastructure-Team-Backlog
Mholloway closed T242479: mobileapps 'parsePronunciation' bug causing string error with some articles as Resolved.

Nm, it is.

Wed, Jan 15, 4:45 PM · Page Content Service, Product-Infrastructure-Team-Backlog
Mholloway claimed T242587: babel update breaks compatibility with npm 3.8.x.
Wed, Jan 15, 4:41 PM · Services, Page Content Service, Product-Infrastructure-Team-Backlog
Mholloway lowered the priority of T242587: babel update breaks compatibility with npm 3.8.x from High to Medium.
Wed, Jan 15, 4:41 PM · Services, Page Content Service, Product-Infrastructure-Team-Backlog
Mholloway added a comment to T242587: babel update breaks compatibility with npm 3.8.x.

Let's figure out who to bug about updating the npm version in the npm-node-6-docker image.

Wed, Jan 15, 4:41 PM · Services, Page Content Service, Product-Infrastructure-Team-Backlog
Mholloway committed rMSRA40411f687135: Commit package-lock.json (authored by Mholloway).
Commit package-lock.json
Wed, Jan 15, 3:11 PM
Mholloway edited projects for T229162: OnThisDay: support Italian language, added: Product-Infrastructure-Team-Backlog, Wikifeeds; removed Product-Infrastructure-Team-Backlog (Kanban), Mobile-Content-Service.
Wed, Jan 15, 3:02 PM · Wikifeeds, Product-Infrastructure-Team-Backlog, Patch-For-Review
Mholloway added a project to T218250: [Enhancement] Check user's edit permissions for suggested items before sending: Recommendation-API.
Wed, Jan 15, 3:00 PM · Recommendation-API, Product-Infrastructure-Team-Backlog (Kanban)
Mholloway raised the priority of T218250: [Enhancement] Check user's edit permissions for suggested items before sending from Low to Medium.
Wed, Jan 15, 3:00 PM · Recommendation-API, Product-Infrastructure-Team-Backlog (Kanban)
Mholloway moved T218250: [Enhancement] Check user's edit permissions for suggested items before sending from To Do to To Deploy on the Product-Infrastructure-Team-Backlog (Kanban) board.
Wed, Jan 15, 2:59 PM · Recommendation-API, Product-Infrastructure-Team-Backlog (Kanban)
Mholloway claimed T218250: [Enhancement] Check user's edit permissions for suggested items before sending.

Per T235028#5760400 it's sufficient just to exclude protected pages from the response for now. That change has been merged to Recommendation-API and now just needs to be deployed.

Wed, Jan 15, 2:59 PM · Recommendation-API, Product-Infrastructure-Team-Backlog (Kanban)
Mholloway added a comment to T242763: /page/summary/<title> often returns type: 'no-extract'.

Weird. When I do the same, I get a 302 with header Location: Carnivore.

Wed, Jan 15, 12:58 PM · RESTBase, Page Content Service, MediaWiki-REST-API, Product-Infrastructure-Team-Backlog
Mholloway committed rGMOD3c5f6159977a: Update mobileapps to 7f507ae (authored by Mholloway).
Update mobileapps to 7f507ae
Wed, Jan 15, 6:48 AM
Mholloway added a project to T242763: /page/summary/<title> often returns type: 'no-extract': RESTBase.

Ah, OK, I see that if you are requesting directly from a mobileapps service instance, then the redirects won't be resolved and the type will indeed be no-extract. I recommend using the public REST API summary endpoint.

Can you elaborate here?

Wed, Jan 15, 5:16 AM · RESTBase, Page Content Service, MediaWiki-REST-API, Product-Infrastructure-Team-Backlog

Tue, Jan 14

Mholloway committed rMSRA0aef24ffb999: Filter protected pages from description and caption suggestions (authored by Mholloway).
Filter protected pages from description and caption suggestions
Tue, Jan 14, 7:21 PM
Mholloway committed rMSRA0fb7791c7e0a: Fix failing spec test (authored by Mholloway).
Fix failing spec test
Tue, Jan 14, 7:21 PM
Mholloway added a comment to T242763: /page/summary/<title> often returns type: 'no-extract'.

Ah, OK, I see that if you are requesting directly from a mobileapps service instance, then the redirects won't be resolved and the type will indeed be no-extract. I recommend using the public REST API summary endpoint.

Tue, Jan 14, 6:05 PM · RESTBase, Page Content Service, MediaWiki-REST-API, Product-Infrastructure-Team-Backlog
Mholloway added a project to T242763: /page/summary/<title> often returns type: 'no-extract': Page Content Service.

I just tried each of the example links in Chromium, and all came back with the expected standard type. But I notice that they're all redirects, which probably isn't a coincidence. How are you requesting these that's resulting in no-extract? Are you using the public REST API endpoints? RESTBase should be taking care of resolving redirects.

Tue, Jan 14, 5:42 PM · RESTBase, Page Content Service, MediaWiki-REST-API, Product-Infrastructure-Team-Backlog
Mholloway renamed T235028: Indicate that Commons pages/images are protected from Filter protected pages from Suggested Edits suggestions to Indicate that Commons pages/images are protected.
Tue, Jan 14, 12:43 PM · Patch-For-Review, WikimediaEditorTasks, Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Android-app-Bugs
Mholloway added a comment to T235028: Indicate that Commons pages/images are protected.

Whoops, I may be confused — I was thinking about this in the context of Suggested Edits (since I'd heard about protected suggestions being an issue there), but this task actually looks broader, if not totally separate.

Tue, Jan 14, 12:42 PM · Patch-For-Review, WikimediaEditorTasks, Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Android-app-Bugs
Mholloway renamed T235028: Indicate that Commons pages/images are protected from Indicate that Commons pages/images are protected to Filter protected pages from Suggested Edits suggestions.
Tue, Jan 14, 12:38 PM · Patch-For-Review, WikimediaEditorTasks, Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Android-app-Bugs
Mholloway closed T142047: Audit and improve documentation for uses of innerHTML as Resolved.

The real issue here was HTML-formatted content being provided in text fields, which has long since been fixed.

Tue, Jan 14, 11:19 AM · Product-Infrastructure-Team-Backlog, Technical-Debt, Mobile-Content-Service
Mholloway updated the task description for T142047: Audit and improve documentation for uses of innerHTML.
Tue, Jan 14, 11:18 AM · Product-Infrastructure-Team-Backlog, Technical-Debt, Mobile-Content-Service
Mholloway updated the task description for T142047: Audit and improve documentation for uses of innerHTML.
Tue, Jan 14, 11:18 AM · Product-Infrastructure-Team-Backlog, Technical-Debt, Mobile-Content-Service
Mholloway removed a project from T239619: mobile-html: validate innerHTML and appendChild() for potentially dangerous code : Android-app-feature-mobile-html.
Tue, Jan 14, 11:11 AM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Page Content Service
Mholloway closed T240518: Some jobs are not being processed / are processed slowly as Resolved.

Incident report is in review.

Tue, Jan 14, 10:52 AM · Wikimedia-Incident, SDC-Statements (Machine-vision-depicts), MachineVision, Structured-Data-Backlog, Product-Infrastructure-Team-Backlog, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Core Platform Team Workboards (Clinic Duty Team), WMF-JobQueue, Operations
Mholloway closed T240518: Some jobs are not being processed / are processed slowly, a subtask of T240777: MassMessage not delivering, as Resolved.
Tue, Jan 14, 10:52 AM · Operations, MassMessage, User-DannyS712
Mholloway closed T240518: Some jobs are not being processed / are processed slowly, a subtask of T240800: MediaWiki mail system for watchlist on it.wikipedia is delivering very slowly , as Resolved.
Tue, Jan 14, 10:52 AM · Operations, Mail
Mholloway created T242726: Improve the Kafka job queue's handling of unknown new jobs.
Tue, Jan 14, 10:16 AM · WMF-JobQueue, Wikimedia-Incident
Mholloway updated the task description for T242722: Document the danger of the release timestamp feature in code and on-wiki .
Tue, Jan 14, 9:55 AM · WMF-JobQueue, Wikimedia-Incident
Mholloway created T242722: Document the danger of the release timestamp feature in code and on-wiki .
Tue, Jan 14, 9:52 AM · WMF-JobQueue, Wikimedia-Incident
Mholloway moved T242721: Add alert(s) for unusual job processing backlog increases from On-going to Follow-up on the Wikimedia-Incident board.
Tue, Jan 14, 9:44 AM · Wikimedia-Incident, WMF-JobQueue
Mholloway created T242721: Add alert(s) for unusual job processing backlog increases.
Tue, Jan 14, 9:43 AM · Wikimedia-Incident, WMF-JobQueue
Mholloway reopened T242479: mobileapps 'parsePronunciation' bug causing string error with some articles as "Open".

Hmm, no, that isn't right.

Tue, Jan 14, 8:31 AM · Page Content Service, Product-Infrastructure-Team-Backlog
Mholloway closed T242479: mobileapps 'parsePronunciation' bug causing string error with some articles as Resolved.

Ah, I see — looks like domino understands the un-quoted selectors, but webpack throws an error. Thanks for fixing that!

Tue, Jan 14, 8:28 AM · Page Content Service, Product-Infrastructure-Team-Backlog
Mholloway added a project to T242662: "machinevision-machineaidedtagging-intro" message should not refer to production interwiki codes: Product-Infrastructure-Team-Backlog.
Tue, Jan 14, 7:42 AM · Product-Infrastructure-Team-Backlog, SDC-Statements (Machine-vision-depicts), Structured-Data-Backlog, Performance-Team (Radar), I18n, MachineVision
Mholloway added a project to T242662: "machinevision-machineaidedtagging-intro" message should not refer to production interwiki codes: SDC-Statements (Machine-vision-depicts).
Tue, Jan 14, 7:42 AM · Product-Infrastructure-Team-Backlog, SDC-Statements (Machine-vision-depicts), Structured-Data-Backlog, Performance-Team (Radar), I18n, MachineVision
Mholloway updated subscribers of T242667: Reduce flash of empty page and hoisted footer when loading Special:SuggestedTags (FOUC).
Tue, Jan 14, 7:40 AM · Structured-Data-Backlog, SDC-Statements (Machine-vision-depicts), Performance-Team (Radar), Product-Infrastructure-Team-Backlog, MachineVision
Mholloway added a project to T242667: Reduce flash of empty page and hoisted footer when loading Special:SuggestedTags (FOUC): SDC-Statements (Machine-vision-depicts).
Tue, Jan 14, 7:39 AM · Structured-Data-Backlog, SDC-Statements (Machine-vision-depicts), Performance-Team (Radar), Product-Infrastructure-Team-Backlog, MachineVision

Mon, Jan 13

Mholloway added a comment to T241072: Update the "waiting period" implemenation so as not to block the job queue.

(Updated the task description since what went wrong is no longer a mystery.)

Mon, Jan 13, 12:13 PM · Patch-For-Review, Structured Data Engineering, Structured-Data-Backlog (Current Work), Product-Infrastructure-Team-Backlog, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), MachineVision
Mholloway added a comment to T241072: Update the "waiting period" implemenation so as not to block the job queue.

My recommendation would be to go ahead with splitting into a separate queue/changeprop rule, if that's acceptable from a service ops perspective. Relatively speaking, this is a pretty low-volume job type.

Mon, Jan 13, 12:13 PM · Patch-For-Review, Structured Data Engineering, Structured-Data-Backlog (Current Work), Product-Infrastructure-Team-Backlog, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), MachineVision
Mholloway renamed T241072: Update the "waiting period" implemenation so as not to block the job queue from Investigate why fetchGoogleCloudVisionAnnotations jobs blocked the job queue, and fix it to Update the "waiting period" implemenation so as not to block the job queue.
Mon, Jan 13, 12:10 PM · Patch-For-Review, Structured Data Engineering, Structured-Data-Backlog (Current Work), Product-Infrastructure-Team-Backlog, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), MachineVision
Mholloway added a comment to T242479: mobileapps 'parsePronunciation' bug causing string error with some articles.

Do you have a stack trace? I'd like to better understand what's going wrong and why it only occurs on some articles.

Mon, Jan 13, 11:37 AM · Page Content Service, Product-Infrastructure-Team-Backlog
Mholloway added a comment to T225107: Migrate recommendation-api to node 10.

Moving back to "needs triage" for discussion in tomorrow's team meeting. This is becoming more urgent as dependencies are rapidly dropping node 6 support.

Mon, Jan 13, 11:27 AM · Recommendation-API, Product-Infrastructure-Team-Backlog
Mholloway added a comment to T218733: Migrate mobileapps to k8s and node 10.

Our dependencies are also rapidly dropping node 6 support:

Mon, Jan 13, 11:18 AM · Product-Infrastructure-Team-Backlog, Page Content Service, Mobile-Content-Service
Mholloway moved T218733: Migrate mobileapps to k8s and node 10 from Tracking to Needs triage on the Product-Infrastructure-Team-Backlog board.
Mon, Jan 13, 11:13 AM · Product-Infrastructure-Team-Backlog, Page Content Service, Mobile-Content-Service
Mholloway moved T225107: Migrate recommendation-api to node 10 from Tracking to Needs triage on the Product-Infrastructure-Team-Backlog board.
Mon, Jan 13, 11:13 AM · Recommendation-API, Product-Infrastructure-Team-Backlog
Mholloway triaged T242587: babel update breaks compatibility with npm 3.8.x as High priority.
Mon, Jan 13, 11:04 AM · Services, Page Content Service, Product-Infrastructure-Team-Backlog
Mholloway created T242587: babel update breaks compatibility with npm 3.8.x.
Mon, Jan 13, 11:04 AM · Services, Page Content Service, Product-Infrastructure-Team-Backlog
Mholloway triaged T242583: requestretry 4.1.0 breaks compatibility with node 6 as High priority.
Mon, Jan 13, 10:46 AM · Product-Infrastructure-Team-Backlog (Kanban), Services, Page Content Service
Mholloway created T242583: requestretry 4.1.0 breaks compatibility with node 6.
Mon, Jan 13, 10:46 AM · Product-Infrastructure-Team-Backlog (Kanban), Services, Page Content Service
Mholloway added a comment to T240597: Enable TLS for mobileapps and implement the Strict-Transport-Security header .

For reference, here are some notes on other services using encryption within the Wikimedia production environment: https://wikitech.wikimedia.org/wiki/User:Jbond/Encryption

Mon, Jan 13, 9:52 AM · Page Content Service, Product-Infrastructure-Team-Backlog

Tue, Jan 7

Mholloway added a comment to T241242: "Edit conflict" when approving two or more tags for a specific image.

I'll poke my head in from vacationland to say one quick thing: I don't know what to make of the filename business, but one particular area I suspect may be causing trouble is how we're creating and saving multiple revisions in series in the course of handling a single API request. Maybe we're getting the expected revision ID is retrieved from a DB replica at one point and from master at another, causing a race condition?

Tue, Jan 7, 8:15 AM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (Machine-vision-depicts), MachineVision

Dec 22 2019

Mholloway added a comment to T235028: Indicate that Commons pages/images are protected.

We could forward protection info from the MediaWiki API and allow the apps to check the user's groups against any page protections in effect, or we could simply omit pages with any kind of protection from the results. Any preference for one or the other?

Dec 22 2019, 4:44 PM · Patch-For-Review, WikimediaEditorTasks, Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Android-app-Bugs

Dec 20 2019

Mholloway added a comment to T241242: "Edit conflict" when approving two or more tags for a specific image.

Same file, uploaded with a different name, allows 2+ tags to be saved at once.

Dec 20 2019, 11:51 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (Machine-vision-depicts), MachineVision
Mholloway updated the task description for T241242: "Edit conflict" when approving two or more tags for a specific image.
Dec 20 2019, 11:49 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (Machine-vision-depicts), MachineVision
Mholloway closed T241014: Argument 2 passed to MediaWiki\Extension\WikimediaEditorTasks\Hooks::countersOnEditSuccess() must be an instance of MediaWiki\Revision\RevisionRecord, null given, called in /srv/mediawiki/php-1.35.0-wmf.10/extensions/WikimediaEditorTasks/src/Hooks.php on line 78 as Resolved.
Dec 20 2019, 7:36 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Wikimedia-production-error, WikimediaEditorTasks, Product-Infrastructure-Team-Backlog (Kanban)
Mholloway moved T241014: Argument 2 passed to MediaWiki\Extension\WikimediaEditorTasks\Hooks::countersOnEditSuccess() must be an instance of MediaWiki\Revision\RevisionRecord, null given, called in /srv/mediawiki/php-1.35.0-wmf.10/extensions/WikimediaEditorTasks/src/Hooks.php on line 78 from Code Review to Sign off on the Product-Infrastructure-Team-Backlog (Kanban) board.
Dec 20 2019, 7:35 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Wikimedia-production-error, WikimediaEditorTasks, Product-Infrastructure-Team-Backlog (Kanban)
Mholloway committed rEWET0d11eabc34e4: Get revision record from revision object (authored by MSantos).
Get revision record from revision object
Dec 20 2019, 6:38 PM
Mholloway added a subtask for T240616: MachineVision should not put out at MediaWiki\Extension\MachineVision\MachineVisionEntitySaveException fatal on an edit conflict: T241242: "Edit conflict" when approving two or more tags for a specific image.
Dec 20 2019, 4:13 PM · Product-Infrastructure-Team-Backlog, Structured Data Engineering, Structured-Data-Backlog, MachineVision
Mholloway added a parent task for T241242: "Edit conflict" when approving two or more tags for a specific image: T240616: MachineVision should not put out at MediaWiki\Extension\MachineVision\MachineVisionEntitySaveException fatal on an edit conflict.
Dec 20 2019, 4:13 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (Machine-vision-depicts), MachineVision
Mholloway updated the task description for T241242: "Edit conflict" when approving two or more tags for a specific image.
Dec 20 2019, 4:09 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (Machine-vision-depicts), MachineVision
Mholloway updated the task description for T241242: "Edit conflict" when approving two or more tags for a specific image.
Dec 20 2019, 2:44 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (Machine-vision-depicts), MachineVision
Mholloway updated the task description for T241242: "Edit conflict" when approving two or more tags for a specific image.
Dec 20 2019, 2:44 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (Machine-vision-depicts), MachineVision
Mholloway created T241242: "Edit conflict" when approving two or more tags for a specific image.
Dec 20 2019, 2:43 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (Machine-vision-depicts), MachineVision
Mholloway moved T240251: mobile-html: Add userGroups and leadImageHeight to PCS setup settings from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog (Kanban) board.
Dec 20 2019, 1:40 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service
Mholloway closed T238567: MachineVisionEntitySaveException from line 148 of WikidataDepictsSetter.php: * Your edit was patched into the latest version. as Resolved.
Dec 20 2019, 1:40 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Product-Infrastructure-Team-Backlog (Kanban), MachineVision
Mholloway moved T240646: Create a link to Special:SuggestedTags in the nav sidebar from Sign off to To Deploy on the Product-Infrastructure-Team-Backlog (Kanban) board.
Dec 20 2019, 1:39 PM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Structured-Data-Backlog, MachineVision, SDC-Statements (Machine-vision-depicts), Product-Infrastructure-Team-Backlog (Kanban)
Mholloway closed T241013: Argument 3 passed to MediaWiki\Extension\WikimediaEditorTasks\WikipediaAppDescriptionEditCounter::onRevert() must be an instance of MediaWiki\Revision\RevisionRecord, instance of Revision given, called in /srv/mediawiki/php-1.35.0-wmf.10/extensions/WikimediaEditorTasks/src/Hooks.php on line 116 as Resolved.
Dec 20 2019, 1:38 PM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Wikimedia-production-error, WikimediaEditorTasks, Product-Infrastructure-Team-Backlog (Kanban)
Mholloway closed T240682: Error extracting reference lists: TypeError: Cannot read property 'matches' of null as Resolved.
Dec 20 2019, 12:15 AM · Page Content Service, Product-Infrastructure-Team-Backlog (Kanban)
Mholloway closed T240274: [mobile-html] URIError: URI malformed as Resolved.
Dec 20 2019, 12:15 AM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service
Mholloway moved T240682: Error extracting reference lists: TypeError: Cannot read property 'matches' of null from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog (Kanban) board.
Dec 20 2019, 12:15 AM · Page Content Service, Product-Infrastructure-Team-Backlog (Kanban)
Mholloway moved T240274: [mobile-html] URIError: URI malformed from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog (Kanban) board.
Dec 20 2019, 12:15 AM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service
Mholloway closed T239671: mobile-html: handle error or empty page/related/ response properly as Resolved.
Dec 20 2019, 12:15 AM · Product-Infrastructure-Team-Backlog (Kanban), Android-app-feature-mobile-html, Page Content Service
Mholloway moved T239671: mobile-html: handle error or empty page/related/ response properly from Code Review to Sign off on the Product-Infrastructure-Team-Backlog (Kanban) board.
Dec 20 2019, 12:14 AM · Product-Infrastructure-Team-Backlog (Kanban), Android-app-feature-mobile-html, Page Content Service
Mholloway moved T241013: Argument 3 passed to MediaWiki\Extension\WikimediaEditorTasks\WikipediaAppDescriptionEditCounter::onRevert() must be an instance of MediaWiki\Revision\RevisionRecord, instance of Revision given, called in /srv/mediawiki/php-1.35.0-wmf.10/extensions/WikimediaEditorTasks/src/Hooks.php on line 116 from Code Review to Sign off on the Product-Infrastructure-Team-Backlog (Kanban) board.
Dec 20 2019, 12:14 AM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Wikimedia-production-error, WikimediaEditorTasks, Product-Infrastructure-Team-Backlog (Kanban)
Mholloway committed rEWET96b90d70eb96: Pass RevisionRecord to onRevert (authored by MSantos).
Pass RevisionRecord to onRevert
Dec 20 2019, 12:04 AM

Dec 19 2019

Mholloway moved T241072: Update the "waiting period" implemenation so as not to block the job queue from In development to Under discussion on the MachineVision board.
Dec 19 2019, 11:40 PM · Patch-For-Review, Structured Data Engineering, Structured-Data-Backlog (Current Work), Product-Infrastructure-Team-Backlog, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), MachineVision
Mholloway moved T240616: MachineVision should not put out at MediaWiki\Extension\MachineVision\MachineVisionEntitySaveException fatal on an edit conflict from Backlog to In development on the MachineVision board.
Dec 19 2019, 8:33 PM · Product-Infrastructure-Team-Backlog, Structured Data Engineering, Structured-Data-Backlog, MachineVision
Mholloway moved T240518: Some jobs are not being processed / are processed slowly from Backlog to Tracking on the MachineVision board.
Dec 19 2019, 8:33 PM · Wikimedia-Incident, SDC-Statements (Machine-vision-depicts), MachineVision, Structured-Data-Backlog, Product-Infrastructure-Team-Backlog, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Core Platform Team Workboards (Clinic Duty Team), WMF-JobQueue, Operations
Mholloway moved T241072: Update the "waiting period" implemenation so as not to block the job queue from Under discussion to In development on the MachineVision board.
Dec 19 2019, 8:29 PM · Patch-For-Review, Structured Data Engineering, Structured-Data-Backlog (Current Work), Product-Infrastructure-Team-Backlog, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), MachineVision
Mholloway added a comment to T241072: Update the "waiting period" implemenation so as not to block the job queue.

@Pchelolo Sounds good. We'll ignore duplicate key errors upon inserting data from these jobs, then, since they're an expected condition of using the job queue.

Dec 19 2019, 8:29 PM · Patch-For-Review, Structured Data Engineering, Structured-Data-Backlog (Current Work), Product-Infrastructure-Team-Backlog, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), MachineVision
Mholloway added a comment to T241072: Update the "waiting period" implemenation so as not to block the job queue.

@Pchelolo There's one other issue that needs resolution before we can try reenabling these jobs. Separate from the immediate job queue delay caused by the use of jobReleaseTimestamp, these jobs were failing at a high rate with DB duplicate entry errors, indicating that data for the same image had already been inserted by a previous job. This doesn't make sense from the MediaWiki side, where only a single job is submitted in the UploadComplete hook for a newly uploaded file. Were these most likely retries caused by the misbehaving release timestamp, or might there be something else going wrong?

Dec 19 2019, 6:56 PM · Patch-For-Review, Structured Data Engineering, Structured-Data-Backlog (Current Work), Product-Infrastructure-Team-Backlog, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), MachineVision
Mholloway moved T241072: Update the "waiting period" implemenation so as not to block the job queue from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Dec 19 2019, 6:32 PM · Patch-For-Review, Structured Data Engineering, Structured-Data-Backlog (Current Work), Product-Infrastructure-Team-Backlog, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), MachineVision
Mholloway awarded T241157: XKCD "Citation needed" comic in Chandra Wiseman room is off-kilter a The World Burns token.
Dec 19 2019, 5:28 PM · Office-IT

Dec 18 2019

Mholloway committed rGMOD9dd82275f14f: Update mobileapps to cf2bb3b (authored by Mholloway).
Update mobileapps to cf2bb3b
Dec 18 2019, 9:28 PM
Mholloway added a comment to T241072: Update the "waiting period" implemenation so as not to block the job queue.

The product requirement that's meant to fulfill is for a "waiting period" of 48 hours, so that we're not sending out labeling requests for new files that are going to be quickly deleted for one reason or another. I can imagine a few different ways of implementing this, but picked the jobReleaseTimestamp since it appeared to be available for use. I thought I'd seen at least one other existing job using the release timestamp feature, but I might be mistaken.

Dec 18 2019, 6:15 PM · Patch-For-Review, Structured Data Engineering, Structured-Data-Backlog (Current Work), Product-Infrastructure-Team-Backlog, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), MachineVision
Mholloway added a comment to T240516: Do not serve label suggestions that have already been added as depicts statements.

As for the priority change, we have already added a message to the user to indicate that a depicts statement already exists for an approved label. This task is to prevent labels with existing depicts statements from being suggested at all.

Dec 18 2019, 6:06 PM · SDC-Statements (Machine-vision-depicts), MachineVision, Structured-Data-Backlog
Mholloway removed a project from T240516: Do not serve label suggestions that have already been added as depicts statements: Product-Infrastructure-Team-Backlog.
Dec 18 2019, 6:05 PM · SDC-Statements (Machine-vision-depicts), MachineVision, Structured-Data-Backlog
Mholloway added a comment to T240516: Do not serve label suggestions that have already been added as depicts statements.

To clarify my dropping this, I/Product Infra won't have time to work on this before the quarter ends and the primary maintenance responsibility shifts to the Structured Data team.

Dec 18 2019, 6:04 PM · SDC-Statements (Machine-vision-depicts), MachineVision, Structured-Data-Backlog
Mholloway claimed T241072: Update the "waiting period" implemenation so as not to block the job queue.
Dec 18 2019, 4:39 PM · Patch-For-Review, Structured Data Engineering, Structured-Data-Backlog (Current Work), Product-Infrastructure-Team-Backlog, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), MachineVision
Mholloway added a comment to T241072: Update the "waiting period" implemenation so as not to block the job queue.

@Pchelolo Is there a step to register the job in cpjobqueue that I missed? I didn't do any Kafka configuration at all, just set up the job in the extension.

Dec 18 2019, 4:01 PM · Patch-For-Review, Structured Data Engineering, Structured-Data-Backlog (Current Work), Product-Infrastructure-Team-Backlog, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), MachineVision
Mholloway triaged T241072: Update the "waiting period" implemenation so as not to block the job queue as High priority.
Dec 18 2019, 4:00 PM · Patch-For-Review, Structured Data Engineering, Structured-Data-Backlog (Current Work), Product-Infrastructure-Team-Backlog, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), MachineVision
Mholloway renamed T241072: Update the "waiting period" implemenation so as not to block the job queue from Investigate why fetchGoogleCloudVisionAnnotations jobs blocked the job queue to Investigate why fetchGoogleCloudVisionAnnotations jobs blocked the job queue, and fix it.
Dec 18 2019, 4:00 PM · Patch-For-Review, Structured Data Engineering, Structured-Data-Backlog (Current Work), Product-Infrastructure-Team-Backlog, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), MachineVision
Mholloway created T241072: Update the "waiting period" implemenation so as not to block the job queue.
Dec 18 2019, 3:59 PM · Patch-For-Review, Structured Data Engineering, Structured-Data-Backlog (Current Work), Product-Infrastructure-Team-Backlog, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), MachineVision