Page MenuHomePhabricator

Mholloway (Michael Holloway)
Software Engineer, WMF Reading Infrastructure Team

Projects (14)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 30 2015, 8:44 PM (211 w, 6 d)
Availability
Available
IRC Nick
mdholloway
LDAP User
Mholloway
MediaWiki User
MHolloway (WMF) [ Global Accounts ]

Recent Activity

Thu, Apr 11

bearND awarded T200374: Update indirect dependency on github.com/gwicke/kad.git a Pterodactyl token.
Thu, Apr 11, 3:01 PM · Core Platform Team Backlog (Later), Services (later), service-runner

Wed, Apr 10

Mholloway moved T220574: Continuous errors on several REST API resources (probably related to MCS release) from To Do to Code Review on the Reading-Infrastructure-Team-Backlog (Kanban) board.
Wed, Apr 10, 7:03 AM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Kanban (Done with CPT), Services (done), Reading-Infrastructure-Team-Backlog (Kanban), RESTBase, Mobile-Content-Service, Operations
Mholloway claimed T220574: Continuous errors on several REST API resources (probably related to MCS release).
Wed, Apr 10, 7:03 AM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Kanban (Done with CPT), Services (done), Reading-Infrastructure-Team-Backlog (Kanban), RESTBase, Mobile-Content-Service, Operations

Tue, Apr 9

Mholloway moved T219411: External links no longer have arrow icon in Light theme. from To Deploy to Sign off on the Reading-Infrastructure-Team-Backlog (Kanban) board.
Tue, Apr 9, 2:33 AM · Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), wikimedia-page-library, Page Content Service, Wikipedia-Android-App-Backlog
Mholloway moved T219667: Add wikibase entity id for image files to media endpoint from To Deploy to Sign off on the Reading-Infrastructure-Team-Backlog (Kanban) board.
Tue, Apr 9, 2:33 AM · Page Content Service, Reading-Infrastructure-Team-Backlog (Kanban), Patch-For-Review
Mholloway moved T220045: Stop getting base CSS from live ResourceLoader requests from To Deploy to Sign off on the Reading-Infrastructure-Team-Backlog (Kanban) board.
Tue, Apr 9, 2:32 AM · Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), Page Content Service, Reading Epics (Platform JS CSS and HTML consolidation)

Mon, Apr 8

Mholloway moved T218302: Choose DB/Cluster for WikimediaEditorTasks tables from Needs triage to Tracking on the Reading-Infrastructure-Team-Backlog board.
Mon, Apr 8, 4:58 PM · Reading-Infrastructure-Team-Backlog, DBA, WikimediaEditorTasks
Mholloway edited projects for T218302: Choose DB/Cluster for WikimediaEditorTasks tables, added: Reading-Infrastructure-Team-Backlog; removed Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban).
Mon, Apr 8, 4:57 PM · Reading-Infrastructure-Team-Backlog, DBA, WikimediaEditorTasks
Mholloway moved T220153: Beta Wikidata: Error: 1146 Table 'wikishared.wikimedia_editor_tasks_keys' doesn't exist from Code Review to Sign off on the Reading-Infrastructure-Team-Backlog (Kanban) board.
Mon, Apr 8, 4:56 PM · Reading-Infrastructure-Team-Backlog (Kanban), Patch-For-Review, WikimediaEditorTasks, Wikidata, Beta-Cluster-reproducible, Wikimedia-production-error

Sun, Apr 7

Mholloway created T220282: Investigate CirrusSearch as a Suggested Edits suggestions backend.
Sun, Apr 7, 12:26 AM · Discovery-Search, WikimediaEditorTasks, Reading-Infrastructure-Team-Backlog

Sat, Apr 6

Mholloway moved T220153: Beta Wikidata: Error: 1146 Table 'wikishared.wikimedia_editor_tasks_keys' doesn't exist from To Do to Code Review on the Reading-Infrastructure-Team-Backlog (Kanban) board.
Sat, Apr 6, 1:01 AM · Reading-Infrastructure-Team-Backlog (Kanban), Patch-For-Review, WikimediaEditorTasks, Wikidata, Beta-Cluster-reproducible, Wikimedia-production-error
Mholloway edited projects for T220153: Beta Wikidata: Error: 1146 Table 'wikishared.wikimedia_editor_tasks_keys' doesn't exist, added: Reading-Infrastructure-Team-Backlog (Kanban); removed Reading-Infrastructure-Team-Backlog.
Sat, Apr 6, 1:00 AM · Reading-Infrastructure-Team-Backlog (Kanban), Patch-For-Review, WikimediaEditorTasks, Wikidata, Beta-Cluster-reproducible, Wikimedia-production-error
Mholloway claimed T220153: Beta Wikidata: Error: 1146 Table 'wikishared.wikimedia_editor_tasks_keys' doesn't exist.
Sat, Apr 6, 1:00 AM · Reading-Infrastructure-Team-Backlog (Kanban), Patch-For-Review, WikimediaEditorTasks, Wikidata, Beta-Cluster-reproducible, Wikimedia-production-error

Fri, Apr 5

Mholloway added a comment to T209997: Create a new API endpoint which returns Commons images in need of a caption or caption translation.

It's also worth exploring whether/how we can leverage the WikibaseCirrusSearch extension here -- maybe we don't need to be doing so much work in large, custom MySQL tables.

Fri, Apr 5, 8:41 PM · WikimediaEditorTasks, Reading-Infrastructure-Team-Backlog
Mholloway added a comment to T209997: Create a new API endpoint which returns Commons images in need of a caption or caption translation.

It looks like we can piggyback on Extension:GlobalUsage to get the pages using a file per wiki. (I am curious as to how this flow will work in the app, and will inquire with the team.)

Fri, Apr 5, 8:08 PM · WikimediaEditorTasks, Reading-Infrastructure-Team-Backlog
Mholloway moved T218136: Deploy Extension:WikimediaEditorTasks to production from Doing to Code Review on the Reading-Infrastructure-Team-Backlog (Kanban) board.
Fri, Apr 5, 7:24 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), WikimediaEditorTasks, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
Mholloway moved T218129: Audit RL modules used for the mobileapps CSS base endpoint (and what we really need them for) from Doing to Sign off on the Reading-Infrastructure-Team-Backlog (Kanban) board.
Fri, Apr 5, 7:24 PM · Reading-Infrastructure-Team-Backlog (Kanban), Page Content Service
Mholloway triaged T219667: Add wikibase entity id for image files to media endpoint as Normal priority.
Fri, Apr 5, 7:23 PM · Page Content Service, Reading-Infrastructure-Team-Backlog (Kanban), Patch-For-Review
Mholloway moved T220045: Stop getting base CSS from live ResourceLoader requests from Code Review to To Deploy on the Reading-Infrastructure-Team-Backlog (Kanban) board.
Fri, Apr 5, 7:23 PM · Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), Page Content Service, Reading Epics (Platform JS CSS and HTML consolidation)
Mholloway moved T219667: Add wikibase entity id for image files to media endpoint from Code Review to To Deploy on the Reading-Infrastructure-Team-Backlog (Kanban) board.
Fri, Apr 5, 7:23 PM · Page Content Service, Reading-Infrastructure-Team-Backlog (Kanban), Patch-For-Review
Mholloway moved T219411: External links no longer have arrow icon in Light theme. from Code Review to To Deploy on the Reading-Infrastructure-Team-Backlog (Kanban) board.
Fri, Apr 5, 7:23 PM · Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), wikimedia-page-library, Page Content Service, Wikipedia-Android-App-Backlog
Mholloway added a comment to T209997: Create a new API endpoint which returns Commons images in need of a caption or caption translation.

See also T219502: wb_terms is deprecated for background on the current Wikibase storage scheme. wb_terms is not in use on commonswiki (it exists, but is empty).

Fri, Apr 5, 6:44 PM · WikimediaEditorTasks, Reading-Infrastructure-Team-Backlog
Mholloway updated subscribers of T209997: Create a new API endpoint which returns Commons images in need of a caption or caption translation.

it's not going to be possible in this case to run a series of MySQL queries to populate suggestions as we did for descriptions. Captions are stored along with other media info in JSON blobs in External Storage. From within MediaWiki, they are accessed from a revision record's mediainfo slot. Take, for example the current latest revision (344850849) of File:Pluto-01 Stern 03 Pluto Color TXT.jpg:

Fri, Apr 5, 6:40 PM · WikimediaEditorTasks, Reading-Infrastructure-Team-Backlog
Mholloway updated the task description for T209997: Create a new API endpoint which returns Commons images in need of a caption or caption translation.
Fri, Apr 5, 6:25 PM · WikimediaEditorTasks, Reading-Infrastructure-Team-Backlog
Mholloway changed the status of T209997: Create a new API endpoint which returns Commons images in need of a caption or caption translation from Stalled to Open.
Fri, Apr 5, 6:23 PM · WikimediaEditorTasks, Reading-Infrastructure-Team-Backlog
Mholloway changed the status of T209997: Create a new API endpoint which returns Commons images in need of a caption or caption translation, a subtask of T212793: Build infrastructure required to support the Suggested Edits feature, from Stalled to Open.
Fri, Apr 5, 6:23 PM · WikimediaEditorTasks, Epic, Reading-Infrastructure-Team-Backlog

Thu, Apr 4

Mholloway added a comment to T220045: Stop getting base CSS from live ResourceLoader requests.

Thanks for filling out the task description, @bearND -- I had a lot of meetings today and didn't get to it. I'll tag the appropriate tasks.

Thu, Apr 4, 11:50 PM · Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), Page Content Service, Reading Epics (Platform JS CSS and HTML consolidation)
Mholloway added a comment to T220034: Node.js composition layer for Suggested Edits suggestions.

@bmansurov, I'll spin up a quick prototype for you to take a look at.

Thu, Apr 4, 4:47 PM · Core Platform Team Backlog (Watching / External), Services (watching), Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway added a comment to T220034: Node.js composition layer for Suggested Edits suggestions.

Thanks @Pchelolo, that's an excellent point. Having this as part of the Recommendation API makes perfect sense to me. @bmansurov and I actually chatted about it at All-Hands, but I decided to try to keep the logic entirely within MediaWiki, if possible; it now looks like that's not going to suffice.

Thu, Apr 4, 2:53 PM · Core Platform Team Backlog (Watching / External), Services (watching), Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks

Wed, Apr 3

Mholloway updated the task description for T220034: Node.js composition layer for Suggested Edits suggestions.
Wed, Apr 3, 9:26 PM · Core Platform Team Backlog (Watching / External), Services (watching), Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway updated the task description for T220034: Node.js composition layer for Suggested Edits suggestions.
Wed, Apr 3, 9:24 PM · Core Platform Team Backlog (Watching / External), Services (watching), Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway added a parent task for T220034: Node.js composition layer for Suggested Edits suggestions: T212793: Build infrastructure required to support the Suggested Edits feature.
Wed, Apr 3, 7:47 PM · Core Platform Team Backlog (Watching / External), Services (watching), Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway added a subtask for T212793: Build infrastructure required to support the Suggested Edits feature: T220034: Node.js composition layer for Suggested Edits suggestions.
Wed, Apr 3, 7:47 PM · WikimediaEditorTasks, Epic, Reading-Infrastructure-Team-Backlog
Mholloway added a project to T220034: Node.js composition layer for Suggested Edits suggestions: Services.

Tagging Services as a heads-up. I don't anticipate this needing storage.

Wed, Apr 3, 7:45 PM · Core Platform Team Backlog (Watching / External), Services (watching), Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway triaged T220034: Node.js composition layer for Suggested Edits suggestions as Normal priority.
Wed, Apr 3, 7:44 PM · Core Platform Team Backlog (Watching / External), Services (watching), Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway created T220034: Node.js composition layer for Suggested Edits suggestions.
Wed, Apr 3, 7:43 PM · Core Platform Team Backlog (Watching / External), Services (watching), Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway triaged T218599: Pipe Suggested edits unlock notifications through echo service, so they can be shown in Notifications screen as Normal priority.

Prioritizing this as normal following a chat in the apps-infra sync.

Wed, Apr 3, 4:43 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks, Android-app-feature-Description-Editing, Wikipedia-Android-App-Backlog
Mholloway added a comment to T218129: Audit RL modules used for the mobileapps CSS base endpoint (and what we really need them for).

@Jdlrobson Oh, thanks for the pointer -- that will be handy in the event we iterate on the PCS CSS endpoint to vary the styles served per page.

Wed, Apr 3, 2:22 PM · Reading-Infrastructure-Team-Backlog (Kanban), Page Content Service
Mholloway updated subscribers of T219411: External links no longer have arrow icon in Light theme..

I think we're better off getting away from serving live ResourceLoader modules, and moving in the direction we discussed on the call with @Jdlrobson a few weeks ago of serving curated copies based on upstream rules. The current approach isn't working well, as evidenced by this task, T214728: Dark mode broken (page background remains light) in apps., T214714: Improper CSS being served to apps., and more.

Wed, Apr 3, 2:20 PM · Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), wikimedia-page-library, Page Content Service, Wikipedia-Android-App-Backlog

Tue, Apr 2

Mholloway updated the task description for T218129: Audit RL modules used for the mobileapps CSS base endpoint (and what we really need them for).
Tue, Apr 2, 6:29 PM · Reading-Infrastructure-Team-Backlog (Kanban), Page Content Service
Mholloway added a project to T219909: mobile-html section offsets: Page Content Service.
Tue, Apr 2, 6:29 PM · Page Content Service, Reading-Infrastructure-Team-Backlog
Mholloway updated the task description for T218129: Audit RL modules used for the mobileapps CSS base endpoint (and what we really need them for).
Tue, Apr 2, 6:27 PM · Reading-Infrastructure-Team-Backlog (Kanban), Page Content Service
Mholloway added a comment to T218302: Choose DB/Cluster for WikimediaEditorTasks tables.

@Marostegui Yes, that's fine to delete. Thank you.

Tue, Apr 2, 5:43 PM · Reading-Infrastructure-Team-Backlog, DBA, WikimediaEditorTasks
Mholloway added a comment to T218302: Choose DB/Cluster for WikimediaEditorTasks tables.

There's nothing private on that table. It only contains data on whether a description exists in the languages of Wikipedia pages linked to Wikidata items.

Tue, Apr 2, 5:29 PM · Reading-Infrastructure-Team-Backlog, DBA, WikimediaEditorTasks
Mholloway updated the task description for T218136: Deploy Extension:WikimediaEditorTasks to production.
Tue, Apr 2, 5:07 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), WikimediaEditorTasks, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
Mholloway moved T218129: Audit RL modules used for the mobileapps CSS base endpoint (and what we really need them for) from To Do to Doing on the Reading-Infrastructure-Team-Backlog (Kanban) board.
Tue, Apr 2, 5:06 PM · Reading-Infrastructure-Team-Backlog (Kanban), Page Content Service
Mholloway added a comment to T218129: Audit RL modules used for the mobileapps CSS base endpoint (and what we really need them for).

Bumping to high priority, because problems to this keep occurring regularly; see most recently T219411: External links no longer have arrow icon in Light theme..

Tue, Apr 2, 5:06 PM · Reading-Infrastructure-Team-Backlog (Kanban), Page Content Service
Mholloway raised the priority of T218129: Audit RL modules used for the mobileapps CSS base endpoint (and what we really need them for) from Normal to High.
Tue, Apr 2, 5:05 PM · Reading-Infrastructure-Team-Backlog (Kanban), Page Content Service
Mholloway claimed T218129: Audit RL modules used for the mobileapps CSS base endpoint (and what we really need them for).
Tue, Apr 2, 5:05 PM · Reading-Infrastructure-Team-Backlog (Kanban), Page Content Service
Mholloway added a comment to T218302: Choose DB/Cluster for WikimediaEditorTasks tables.

Does wikimedia_editor_tasks_entity_description_exists being moved to the local DB mean that it should also be removed from the $private_tables list in https://gerrit.wikimedia.org/r/plugins/gitiles/operations/puppet/+/production/manifests/realm.pp?

Tue, Apr 2, 5:03 PM · Reading-Infrastructure-Team-Backlog, DBA, WikimediaEditorTasks
Mholloway closed T219509: [testwikidatawiki] Suggestions may yield deleted items, a subtask of T219314: Provide for deleting stale rows from wikimedia_editor_tasks_entity_description_exists, as Resolved.
Tue, Apr 2, 4:59 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway closed T219509: [testwikidatawiki] Suggestions may yield deleted items as Resolved.

Currently handled with secondary filtering on the client. Later, we can consider moving this type of secondary filtering up into the service layer, perhaps in a node.js service.

Tue, Apr 2, 4:59 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway closed T219535: Sitelinks may be to redirects which resolve to a page with a short description defined as Resolved.

Currently handled with secondary filtering on the client. Late, we can consider moving this type of secondary filtering up into the service layer, perhaps in a node.js service.

Tue, Apr 2, 4:58 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway closed T219537: English suggestions include items with a local and not a central description as Resolved.

Excellent! Thank you.

Tue, Apr 2, 4:57 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway updated subscribers of T219537: English suggestions include items with a local and not a central description.

@Dbrant Can you confirm that this issue and related issues T219535 and T219509 are being handled with client-side filtering?

Tue, Apr 2, 4:52 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway moved T219667: Add wikibase entity id for image files to media endpoint from To Do to Code Review on the Reading-Infrastructure-Team-Backlog (Kanban) board.
Tue, Apr 2, 4:49 PM · Page Content Service, Reading-Infrastructure-Team-Backlog (Kanban), Patch-For-Review
Mholloway added a project to T219667: Add wikibase entity id for image files to media endpoint: Page Content Service.
Tue, Apr 2, 4:48 PM · Page Content Service, Reading-Infrastructure-Team-Backlog (Kanban), Patch-For-Review
Mholloway edited projects for T219667: Add wikibase entity id for image files to media endpoint, added: Reading-Infrastructure-Team-Backlog (Kanban); removed Reading-Infrastructure-Team-Backlog.
Tue, Apr 2, 4:48 PM · Page Content Service, Reading-Infrastructure-Team-Backlog (Kanban), Patch-For-Review
Mholloway claimed T219667: Add wikibase entity id for image files to media endpoint.
Tue, Apr 2, 4:48 PM · Page Content Service, Reading-Infrastructure-Team-Backlog (Kanban), Patch-For-Review

Mon, Apr 1

Mholloway renamed T219685: Handle language variants in the suggestions table populate script from Figure out how to handle language variants to Handle language variants in the suggestions table populate script.
Mon, Apr 1, 9:27 PM · Chinese-Sites, I18n, Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway added a comment to T219685: Handle language variants in the suggestions table populate script.

To get variants for which descriptions are present would be a one-line change,

Actually, that's not true. We can't just rely on the presence of a hyphen in a language string to indicate a variant, because several standalone wikis (including zh-classical, zh-min-nan, and zh-yue) have language codes with hyphens, but are full wikis rather than variants...

Mon, Apr 1, 9:14 PM · Chinese-Sites, I18n, Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway triaged T219685: Handle language variants in the suggestions table populate script as Normal priority.
Mon, Apr 1, 9:06 PM · Chinese-Sites, I18n, Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway added a comment to T219685: Handle language variants in the suggestions table populate script.

Once we can get the correct description (the current API will only get description under zh label from wikidata) from the API,

Is that T173842: [BUG] Wikidata description for the specific Chinese language variant should be shown?

Mon, Apr 1, 9:04 PM · Chinese-Sites, I18n, Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway updated subscribers of T219685: Handle language variants in the suggestions table populate script.

@cooltey I looked into this a bit. The counts table actually stores whatever value is provided for the language parameter in the POST body of the wbsetdescription query; so if "zh" is sent, that is what will be stored, and if "zh-hans" or "zh-hant" (or another variant) are sent, that is what will be stored and what will appear in the wikimediaeditortaskscounts response. Were you testing in the app or in a third-party API client application when you found that your description edits were all being recorded as simply "zh"? Is "zh" not what were you sending as language?

Mon, Apr 1, 8:00 PM · Chinese-Sites, I18n, Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway updated subscribers of T219314: Provide for deleting stale rows from wikimedia_editor_tasks_entity_description_exists.

@Tgr The simplest way that's occurred to me for handling this would be to add a timestamp column to wikimedia_editor_tasks_entity_description_exists. Then we could simply run a DELETE query daily for any row with a timestamp more than a few days old (assuming we're running the populate script daily), with the old timestamp indicating that the sitelink corresponding to the row no longer exists in wb_items_per_site and is no longer being updated by the populate script.

Mon, Apr 1, 5:58 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway renamed T219314: Provide for deleting stale rows from wikimedia_editor_tasks_entity_description_exists from Maintenance script to clear stale rows from wikimedia_editor_tasks_entity_description_exists to Provide for deleting stale rows from wikimedia_editor_tasks_entity_description_exists.
Mon, Apr 1, 5:49 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway committed rEWET0ffbec60e0f7: Don't penalize users for self-reverts (authored by Mholloway).
Don't penalize users for self-reverts
Mon, Apr 1, 5:34 PM
Mholloway closed T219511: [testwikidatawiki] Some descriptions have no entries in wb_terms as Invalid.

I've yet to see this on wikidatawiki, so I'm going to call this a fluke present only on testwikidatawiki unless I encounter evidence to the contrary.

Mon, Apr 1, 4:58 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks

Fri, Mar 29

Mholloway created T219685: Handle language variants in the suggestions table populate script.
Fri, Mar 29, 11:02 PM · Chinese-Sites, I18n, Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway added a comment to T219667: Add wikibase entity id for image files to media endpoint.

It doesn't seem like data exists in the DB for many of the files yet... most that I have tried (like ) come up as missing: true.

Fri, Mar 29, 10:54 PM · Page Content Service, Reading-Infrastructure-Team-Backlog (Kanban), Patch-For-Review
Mholloway added a comment to T219667: Add wikibase entity id for image files to media endpoint.

Here's why this is a bit more troublesome than one would think: the Commons entity IDs for files are based on their Commons page IDs, and for /page/media we make our imageinfo calls to the local Wikipedias and not Commons. We do this because Commons doesn't actually host all media files, but only the freely licensed ones. Fair-use media content is hosted directly on the wikis of projects that allow it. We can get imageinfo about all files used on a Wikipedia when querying it for imageinfo because Commons is searched as a fallback for files not hosted locally, but when querying Commons directly, there is no fallback. So just querying Commons in all cases won't work. (Also, note that because not all files are Commons-hosted, not every item will have a wb_entity_id when this is implemented.)

Fri, Mar 29, 9:01 PM · Page Content Service, Reading-Infrastructure-Team-Backlog (Kanban), Patch-For-Review
Mholloway added a comment to T218928: Image and captions overlapping on German article in Android app.

This is fixed by disabling the display: webkit-flex and display: flex rules from the ancestor div.thumbinner. The style block containing those rules is coming from https://github.com/wikimedia/mediawiki-skins-MinervaNeue/blob/master/resources/skins.minerva.content.styles/hacks.less#L168-L175.

Fri, Mar 29, 6:33 PM · wikimedia-page-library, Reading-Infrastructure-Team-Backlog, Wikipedia-Android-App-Backlog
Mholloway closed T203173: License note on jsonconfig pages as Resolved.
Fri, Mar 29, 5:36 PM · MediaWiki-extensions-JsonConfig
Mholloway closed T206073: Wikimedia Technical Conference 2018 Session - Identifying and extracting data trapped in our content as Resolved.
Fri, Mar 29, 5:34 PM · Language-strategy, Wikimedia-Technical-Conference-2018
Mholloway committed rEWET928fd900c92d: Update: use READ_LATEST, not READ_LOCKING, on evaluate targets passed (authored by Mholloway).
Update: use READ_LATEST, not READ_LOCKING, on evaluate targets passed
Fri, Mar 29, 3:07 PM
Mholloway committed rEWET3140eedf1590: Don't penalize users for self-reverts (authored by Mholloway).
Don't penalize users for self-reverts
Fri, Mar 29, 2:11 PM
Mholloway updated the task description for T218136: Deploy Extension:WikimediaEditorTasks to production.
Fri, Mar 29, 4:17 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), WikimediaEditorTasks, Wikimedia-extension-review-queue, Wikimedia-Extension-setup

Thu, Mar 28

Mholloway updated the task description for T218136: Deploy Extension:WikimediaEditorTasks to production.
Thu, Mar 28, 7:48 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), WikimediaEditorTasks, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
Mholloway updated the task description for T218136: Deploy Extension:WikimediaEditorTasks to production.
Thu, Mar 28, 7:44 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), WikimediaEditorTasks, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
Mholloway updated the task description for T218136: Deploy Extension:WikimediaEditorTasks to production.
Thu, Mar 28, 7:39 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), WikimediaEditorTasks, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
Mholloway closed T219502: wb_terms is deprecated as Invalid.

Makes sense. Thanks for the explanation, @Jdforrester-WMF. For now, I think I'll close this ticket since it's not actionable at present.

Thu, Mar 28, 7:26 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway updated the task description for T218136: Deploy Extension:WikimediaEditorTasks to production.
Thu, Mar 28, 7:01 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), WikimediaEditorTasks, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
Mholloway added a comment to T219509: [testwikidatawiki] Suggestions may yield deleted items.

This case can be handled in the cleanup script to be created for the parent task.

Thu, Mar 28, 6:41 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway added a parent task for T219509: [testwikidatawiki] Suggestions may yield deleted items: T219314: Provide for deleting stale rows from wikimedia_editor_tasks_entity_description_exists.
Thu, Mar 28, 6:40 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway added a subtask for T219314: Provide for deleting stale rows from wikimedia_editor_tasks_entity_description_exists: T219509: [testwikidatawiki] Suggestions may yield deleted items.
Thu, Mar 28, 6:40 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway added a comment to T219502: wb_terms is deprecated.

It's used in WikimediaEditorTasks to derive whether a description exists in the language of sitelinked pages.

Thu, Mar 28, 6:29 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway updated subscribers of T219502: wb_terms is deprecated.

@Jdforrester-WMF What is wb_terms deprected in favor of?

Thu, Mar 28, 6:21 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway added a comment to T219535: Sitelinks may be to redirects which resolve to a page with a short description defined.

It's not possible to eliminate these directly from the table on wikidatawiki; it'll require the consumer to perform some form of secondary, external filtering based on data gathered from the target language wiki database.

Thu, Mar 28, 6:16 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway added a comment to T219537: English suggestions include items with a local and not a central description.

It's not possible to eliminate these directly from the table on wikidatawiki; it'll require the consumer to perform some form of secondary, external filtering based on data gathered from the target language wiki database.

Thu, Mar 28, 6:16 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway updated the task description for T219537: English suggestions include items with a local and not a central description.
Thu, Mar 28, 5:05 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway triaged T219537: English suggestions include items with a local and not a central description as High priority.
Thu, Mar 28, 5:04 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway created T219537: English suggestions include items with a local and not a central description.
Thu, Mar 28, 5:04 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway created T219535: Sitelinks may be to redirects which resolve to a page with a short description defined.
Thu, Mar 28, 4:53 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway added a comment to T219511: [testwikidatawiki] Some descriptions have no entries in wb_terms.

Also, it's possible this is just bad data on test.wikidata.org, and this won't happen on Wikidata proper.

Thu, Mar 28, 3:17 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway updated the task description for T218248: [Enhancement] Recheck edit suggestions before sending.
Thu, Mar 28, 3:10 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway triaged T219511: [testwikidatawiki] Some descriptions have no entries in wb_terms as High priority.
Thu, Mar 28, 3:07 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway created T219511: [testwikidatawiki] Some descriptions have no entries in wb_terms.
Thu, Mar 28, 3:06 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway renamed T219509: [testwikidatawiki] Suggestions may yield deleted items from [testwikidatawiki] Suggestions may yield deleted Wikibase items to [testwikidatawiki] Suggestions may yield deleted items.
Thu, Mar 28, 3:01 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway created T219509: [testwikidatawiki] Suggestions may yield deleted items.
Thu, Mar 28, 3:01 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway updated the task description for T218248: [Enhancement] Recheck edit suggestions before sending.
Thu, Mar 28, 2:49 PM · Reading-Infrastructure-Team-Backlog, WikimediaEditorTasks