Page MenuHomePhabricator

Mholloway (Michael Holloway)
Software Engineer, WMF Product Infrastructure Team

Projects (15)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Mar 30 2015, 8:44 PM (242 w, 3 d)
Availability
Available
IRC Nick
mdholloway
LDAP User
Mholloway
MediaWiki User
MHolloway (WMF) [ Global Accounts ]

Recent Activity

Yesterday

Mholloway triaged T238879: UploadWizard CTA patch causes production timeouts as High priority.
Thu, Nov 21, 11:28 PM · Structured-Data-Backlog, SDC-Statements (Machine-vision-depicts), Product-Infrastructure-Team-Backlog, Machine vision
Mholloway updated the task description for T238879: UploadWizard CTA patch causes production timeouts.
Thu, Nov 21, 11:27 PM · Structured-Data-Backlog, SDC-Statements (Machine-vision-depicts), Product-Infrastructure-Team-Backlog, Machine vision
Mholloway created T238879: UploadWizard CTA patch causes production timeouts.
Thu, Nov 21, 11:26 PM · Structured-Data-Backlog, SDC-Statements (Machine-vision-depicts), Product-Infrastructure-Team-Backlog, Machine vision
Mholloway moved T238700: Domino TypeError: Cannot read property 'type' of undefined from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog (Kanban) board.
Thu, Nov 21, 9:19 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service
Mholloway committed rGMOD70154b4834f9: Update mobileapps to c140e88 (authored by Mholloway).
Update mobileapps to c140e88
Thu, Nov 21, 9:11 PM
jcrespo awarded T238301: MediaWiki\Extension\MachineVision\Maintenance\FetchSuggestions::execute: no transaction to commit, something got out of sync regularly erroring since 2019-11-13 a Like token.
Thu, Nov 21, 6:30 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Product-Infrastructure-Team-Backlog (Kanban), Machine vision, Wikimedia-production-error
Mholloway moved T237419: Treat dynamically-generated paths more defensively in maintenance scripts from Code Review to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Thu, Nov 21, 5:18 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Machine vision
Mholloway closed T237547: Image result received with missing data as Resolved.
Thu, Nov 21, 3:36 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Product-Infrastructure-Team-Backlog (Kanban), Machine vision
Mholloway closed T237420: Prefer Message::parse() or ::escape() over Message::text() as Resolved.
Thu, Nov 21, 3:35 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Product-Infrastructure-Team-Backlog (Kanban), Machine vision
Mholloway closed T238301: MediaWiki\Extension\MachineVision\Maintenance\FetchSuggestions::execute: no transaction to commit, something got out of sync regularly erroring since 2019-11-13 as Resolved.

The fix for this is merged, and should roll out before the next script run.

Thu, Nov 21, 3:35 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Product-Infrastructure-Team-Backlog (Kanban), Machine vision, Wikimedia-production-error
Mholloway closed T235571: Consolidate wikimedia-page-library into the mobileapps repo, a subtask of T229286: Resolve service instability due to excessive event loop blockage since starting PCS response pregeneration, as Resolved.
Thu, Nov 21, 3:34 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog, Epic, Page Content Service, Mobile-Content-Service, serviceops
Mholloway closed T235571: Consolidate wikimedia-page-library into the mobileapps repo as Resolved.
Thu, Nov 21, 3:34 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), wikimedia-page-library, Page Content Service
Mholloway moved T235571: Consolidate wikimedia-page-library into the mobileapps repo from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog (Kanban) board.
Thu, Nov 21, 3:34 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), wikimedia-page-library, Page Content Service
Mholloway moved T238700: Domino TypeError: Cannot read property 'type' of undefined from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog (Kanban) board.
Thu, Nov 21, 3:34 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service
Mholloway added a comment to T238792: Wikifeeds deployment failed in staging.

Deployed on eqiad and codfw. Thank you, @akosiaris!

Thu, Nov 21, 3:25 PM · serviceops, Product-Infrastructure-Team-Backlog, Wikifeeds
Mholloway created T238832: PCS internal request rates tripled on 2019-11-19.
Thu, Nov 21, 3:05 PM · serviceops, Core Platform Team, Product-Infrastructure-Team-Backlog
Mholloway committed rDEPLOYCHARTS2765a68a70ac: Fix typos in docker-registry discovery URLs (authored by Mholloway).
Fix typos in docker-registry discovery URLs
Thu, Nov 21, 1:13 PM

Wed, Nov 20

Mholloway added a comment to T237859: Page Content Service content for de:Briar_(Instant_Messenger) not updated when content transcluded from Wikidata is edited.

Hmm, that is surprising. My workaround suggestion was based on https://github.com/wikimedia/change-propagation/pull/223 but maybe something has changed since then. @Pchelolo probably knows more.

Wed, Nov 20, 11:07 PM · Core Platform Team Workboards (Clinic Duty Team), Product-Infrastructure-Team-Backlog
Mholloway added a comment to T238792: Wikifeeds deployment failed in staging.

Looks like there are currently issues accessing docker-registry.wikimedia.org, which may be to blame here.

Wed, Nov 20, 8:55 PM · serviceops, Product-Infrastructure-Team-Backlog, Wikifeeds
Mholloway updated the task description for T238792: Wikifeeds deployment failed in staging.
Wed, Nov 20, 8:38 PM · serviceops, Product-Infrastructure-Team-Backlog, Wikifeeds
Mholloway created T238792: Wikifeeds deployment failed in staging.
Wed, Nov 20, 8:38 PM · serviceops, Product-Infrastructure-Team-Backlog, Wikifeeds
Mholloway committed rDEPLOYCHARTSe65900d72caa: Update wikifeeds to 2019-11-20-152441-production (authored by Mholloway).
Update wikifeeds to 2019-11-20-152441-production
Wed, Nov 20, 8:14 PM
Mholloway updated the task description for T237859: Page Content Service content for de:Briar_(Instant_Messenger) not updated when content transcluded from Wikidata is edited.
Wed, Nov 20, 7:06 PM · Core Platform Team Workboards (Clinic Duty Team), Product-Infrastructure-Team-Backlog
Mholloway added a comment to T237859: Page Content Service content for de:Briar_(Instant_Messenger) not updated when content transcluded from Wikidata is edited.

As a workaround, I believe that performing a purge or null edit of the article will trigger a PCS update that will pull in changes to transcluded content.

Wed, Nov 20, 5:35 PM · Core Platform Team Workboards (Clinic Duty Team), Product-Infrastructure-Team-Backlog
Mholloway added a comment to T238701: NOT_FOUND_ERR: NOT_FOUND_ERR (8): the object can not be found here.

@JoeWalsh This doesn't appear to have occurred since that change was deployed. I'll update if/when a newer trace is available.

Wed, Nov 20, 5:09 PM · Product-Infrastructure-Team-Backlog, Page Content Service
Mholloway updated the task description for T238701: NOT_FOUND_ERR: NOT_FOUND_ERR (8): the object can not be found here.
Wed, Nov 20, 5:07 PM · Product-Infrastructure-Team-Backlog, Page Content Service
Mholloway updated the task description for T238702: Error extracting reference lists: TypeError: Cannot read property 'matches' of null.
Wed, Nov 20, 5:03 PM · Product-Infrastructure-Team-Backlog, Page Content Service
Mholloway placed T236741: Use local DBs on testcommonswiki and testwikidatawiki up for grabs.
Wed, Nov 20, 4:56 PM · Product-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway moved T236741: Use local DBs on testcommonswiki and testwikidatawiki from Needs analysis to Backlog on the Product-Infrastructure-Team-Backlog board.
Wed, Nov 20, 4:56 PM · Product-Infrastructure-Team-Backlog, WikimediaEditorTasks
Mholloway closed T238173: Special:SuggestedTags loads stale suggestions on back-navigation as Invalid.

Please reopen if repro steps are found.

Wed, Nov 20, 4:50 PM · Product-Infrastructure-Team-Backlog, SDC-Statements (Machine-vision-depicts), Machine vision, Structured-Data-Backlog
Mholloway edited projects for T238567: MachineVisionEntitySaveException from line 148 of WikidataDepictsSetter.php: * Your edit was patched into the latest version., added: Product-Infrastructure-Team-Backlog (Kanban); removed Product-Infrastructure-Team-Backlog.
Wed, Nov 20, 4:47 PM · Product-Infrastructure-Team-Backlog (Kanban), Machine vision
Mholloway committed rWSWF6fff6729970f: Update to node 10 and bump dependency versions (authored by Mholloway).
Update to node 10 and bump dependency versions
Wed, Nov 20, 4:14 PM
Mholloway renamed T237859: Page Content Service content for de:Briar_(Instant_Messenger) not updated when content transcluded from Wikidata is edited from Wikipedia Webpage vs. Wikipedia Android App Webpage: Wikidata Issue on "Briar (Instant Messenger)" to Page Content Service content for de:Briar_(Instant_Messenger) not updated when content transcluded from Wikidata is edited.
Wed, Nov 20, 3:15 PM · Core Platform Team Workboards (Clinic Duty Team), Product-Infrastructure-Team-Backlog
Mholloway edited projects for T237859: Page Content Service content for de:Briar_(Instant_Messenger) not updated when content transcluded from Wikidata is edited, added: Core Platform Team, Product-Infrastructure-Team-Backlog; removed Wikipedia-Android-App-Backlog.

If I understand correctly, the issue here is that the Page Content Service content was updated in response to edits to the Wikipedia page content ( https://de.wikipedia.org/wiki/Briar_(Instant_Messenger) ), but not in response to edits to the corresponding Wikidata item (https://www.wikidata.org/wiki/Q18210428) from which properties are pulled in via https://de.wikipedia.org/wiki/Vorlage:Infobox_Software.

Wed, Nov 20, 3:14 PM · Core Platform Team Workboards (Clinic Duty Team), Product-Infrastructure-Team-Backlog
Mholloway reopened T237859: Page Content Service content for de:Briar_(Instant_Messenger) not updated when content transcluded from Wikidata is edited as "Open".
Wed, Nov 20, 3:02 PM · Core Platform Team Workboards (Clinic Duty Team), Product-Infrastructure-Team-Backlog
Mholloway closed T173098: [BUG] Updated article version does not shown immediately upon publishing an edit in the app as Resolved.

Ah, I see the issue now. T237859 is a distinct issue, and I'll follow up there with further dicussion. In the meantime, I'm going to be bold and close this task. New incidents should be documented in new tasks.

Wed, Nov 20, 3:01 PM · Core Platform Team, Mobile-Content-Service, Product-Infrastructure-Team-Backlog, Wikipedia-Android-App-Backlog
Mholloway added a project to T173098: [BUG] Updated article version does not shown immediately upon publishing an edit in the app: Core Platform Team.

This issue concerns the service(s) that propagate resource change events and issue update requests resulting from such changes to the Page Content Service. Those are maintained by the Core Platform Team, so I'm tagging them here.

Wed, Nov 20, 5:11 AM · Core Platform Team, Mobile-Content-Service, Product-Infrastructure-Team-Backlog, Wikipedia-Android-App-Backlog

Tue, Nov 19

Mholloway created T238702: Error extracting reference lists: TypeError: Cannot read property 'matches' of null.
Tue, Nov 19, 10:57 PM · Product-Infrastructure-Team-Backlog, Page Content Service
Mholloway created T238701: NOT_FOUND_ERR: NOT_FOUND_ERR (8): the object can not be found here.
Tue, Nov 19, 10:53 PM · Product-Infrastructure-Team-Backlog, Page Content Service
Mholloway created T238700: Domino TypeError: Cannot read property 'type' of undefined.
Tue, Nov 19, 10:50 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service
Mholloway committed rGMOD6e6bd42691a5: Update mobileapps to 477d248 (authored by Mholloway).
Update mobileapps to 477d248
Tue, Nov 19, 8:46 PM
Mholloway moved T237420: Prefer Message::parse() or ::escape() over Message::text() from Code Review to Sign off on the Product-Infrastructure-Team-Backlog (Kanban) board.
Tue, Nov 19, 4:34 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Product-Infrastructure-Team-Backlog (Kanban), Machine vision
Mholloway added a comment to T230845: Reader gets media links.

One thing I think is worth making explicit on this ticket is whether this endpoint is intended to return only media items that are part of the article content, or all linked media items. For example, on enwiki, many articles with linked media content contain an imagelink to Commons-logo.svg via the inclusion of Template:Commons_category. Is the intent to include images like these in the response, or to try and restrict inclusion to images more likely to be interesting to the caller? The media/media-list endpoints in mobileapps attempt to do the latter, but I'm not sure whether you intend to go down that road again here.

Tue, Nov 19, 4:18 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)

Mon, Nov 18

Mholloway committed rDEPLOYCHARTS5338289aa601: Update wikifeeds to 2019-11-12-001916-production (authored by Mholloway).
Update wikifeeds to 2019-11-12-001916-production
Mon, Nov 18, 9:54 PM
Mholloway moved T237419: Treat dynamically-generated paths more defensively in maintenance scripts from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Mon, Nov 18, 9:45 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Machine vision
Mholloway moved T237419: Treat dynamically-generated paths more defensively in maintenance scripts from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Mon, Nov 18, 8:46 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Machine vision
Mholloway claimed T237419: Treat dynamically-generated paths more defensively in maintenance scripts.
Mon, Nov 18, 8:46 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Machine vision
Mholloway moved T237420: Prefer Message::parse() or ::escape() over Message::text() from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Mon, Nov 18, 8:41 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Product-Infrastructure-Team-Backlog (Kanban), Machine vision
Mholloway moved T237420: Prefer Message::parse() or ::escape() over Message::text() from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Mon, Nov 18, 8:11 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Product-Infrastructure-Team-Backlog (Kanban), Machine vision
Mholloway claimed T237420: Prefer Message::parse() or ::escape() over Message::text().
Mon, Nov 18, 8:11 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Product-Infrastructure-Team-Backlog (Kanban), Machine vision
Mholloway moved T235887: Add extension data to Cloud VPS DB replicas from Ready for dev to Tracking on the Machine vision board.
Mon, Nov 18, 7:01 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog, Machine vision
Mholloway moved T238574: Create wiki replica views for MachineVision extension tables from Backlog to Tracking on the Machine vision board.
Mon, Nov 18, 7:00 PM · cloud-services-team, Product-Infrastructure-Team-Backlog, Machine vision
Mholloway moved T238574: Create wiki replica views for MachineVision extension tables from Needs triage to Tracking on the Product-Infrastructure-Team-Backlog board.
Mon, Nov 18, 7:00 PM · cloud-services-team, Product-Infrastructure-Team-Backlog, Machine vision
Mholloway created T238574: Create wiki replica views for MachineVision extension tables.
Mon, Nov 18, 7:00 PM · cloud-services-team, Product-Infrastructure-Team-Backlog, Machine vision
Mholloway edited projects for T237419: Treat dynamically-generated paths more defensively in maintenance scripts, added: Product-Infrastructure-Team-Backlog (Kanban); removed Product-Infrastructure-Team-Backlog.
Mon, Nov 18, 5:22 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Machine vision
Mholloway edited projects for T237420: Prefer Message::parse() or ::escape() over Message::text(), added: Product-Infrastructure-Team-Backlog (Kanban); removed Product-Infrastructure-Team-Backlog.
Mon, Nov 18, 5:21 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Product-Infrastructure-Team-Backlog (Kanban), Machine vision
Mholloway moved T235887: Add extension data to Cloud VPS DB replicas from Backlog to Ready for dev on the Machine vision board.
Mon, Nov 18, 5:18 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog, Machine vision
Mholloway moved T237419: Treat dynamically-generated paths more defensively in maintenance scripts from Backlog to Ready for dev on the Machine vision board.
Mon, Nov 18, 5:17 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Machine vision
Mholloway moved T237415: Vulnerable and outdated npm packages used by MachineVision from Ready for dev to Backlog on the Machine vision board.
Mon, Nov 18, 5:17 PM · Machine vision, Product-Infrastructure-Team-Backlog
Mholloway moved T237415: Vulnerable and outdated npm packages used by MachineVision from Backlog to Ready for dev on the Machine vision board.
Mon, Nov 18, 5:17 PM · Machine vision, Product-Infrastructure-Team-Backlog
Mholloway moved T227349: Deploy the MachineVision extension to production from Backlog to In development on the Machine vision board.
Mon, Nov 18, 5:17 PM · Product-Infrastructure-Team-Backlog (Kanban), Machine vision
Mholloway closed T224917: Machine vision image metadata service as Invalid.

This was implemented as a MediaWiki extension, and there is no plan to add an external service component.

Mon, Nov 18, 5:16 PM · Machine vision, serviceops-radar, Release Pipeline, Services (watching), Operations, Product-Infrastructure-Team-Backlog, Service-deployment-requests
Mholloway moved T238450: Adjust max-height of images from Backlog to In development on the Machine vision board.
Mon, Nov 18, 5:15 PM · Structured-Data-Backlog, Structured-Data-Design, Structured Data Engineering, Machine vision, SDC-Statements (Machine-vision-depicts)
Mholloway moved T237420: Prefer Message::parse() or ::escape() over Message::text() from Backlog to Ready for dev on the Machine vision board.
Mon, Nov 18, 5:15 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Product-Infrastructure-Team-Backlog (Kanban), Machine vision
Mholloway created T238567: MachineVisionEntitySaveException from line 148 of WikidataDepictsSetter.php: * Your edit was patched into the latest version..
Mon, Nov 18, 4:48 PM · Product-Infrastructure-Team-Backlog (Kanban), Machine vision
Mholloway moved T238173: Special:SuggestedTags loads stale suggestions on back-navigation from Ready for dev to Backlog on the Machine vision board.
Mon, Nov 18, 4:30 PM · Product-Infrastructure-Team-Backlog, SDC-Statements (Machine-vision-depicts), Machine vision, Structured-Data-Backlog
Mholloway raised the priority of T238173: Special:SuggestedTags loads stale suggestions on back-navigation from High to Needs Triage.

De-prioritizing and moving to the PI backlog until this can be reproduced.

Mon, Nov 18, 4:30 PM · Product-Infrastructure-Team-Backlog, SDC-Statements (Machine-vision-depicts), Machine vision, Structured-Data-Backlog
Mholloway moved T237588: Security review for MachineVision libraries from Backlog to Under discussion on the Machine vision board.
Mon, Nov 18, 4:28 PM · Security-Team-Reviews, Product-Infrastructure-Team-Backlog, MediaWiki-Vendor, Machine vision
Mholloway moved T237596: Add MachineVision dependencies to vendor from Backlog to Under discussion on the Machine vision board.
Mon, Nov 18, 4:28 PM · Product-Infrastructure-Team-Backlog, MediaWiki-Vendor, Machine vision
Mholloway moved T238301: MediaWiki\Extension\MachineVision\Maintenance\FetchSuggestions::execute: no transaction to commit, something got out of sync regularly erroring since 2019-11-13 from Backlog to In development on the Machine vision board.
Mon, Nov 18, 4:28 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Product-Infrastructure-Team-Backlog (Kanban), Machine vision, Wikimedia-production-error
Mholloway moved T238301: MediaWiki\Extension\MachineVision\Maintenance\FetchSuggestions::execute: no transaction to commit, something got out of sync regularly erroring since 2019-11-13 from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog (Kanban) board.
Mon, Nov 18, 2:43 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Product-Infrastructure-Team-Backlog (Kanban), Machine vision, Wikimedia-production-error
Mholloway moved T238301: MediaWiki\Extension\MachineVision\Maintenance\FetchSuggestions::execute: no transaction to commit, something got out of sync regularly erroring since 2019-11-13 from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog (Kanban) board.
Mon, Nov 18, 2:42 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Product-Infrastructure-Team-Backlog (Kanban), Machine vision, Wikimedia-production-error

Fri, Nov 15

Mholloway committed rEMVI99d8ac8de464: Hygiene: Remove outdated comments (authored by Mholloway).
Hygiene: Remove outdated comments
Fri, Nov 15, 11:36 PM
Mholloway updated the task description for T231032: Implement features that allow for tracking and measuring machine-aided depicts usage/activity.
Fri, Nov 15, 11:14 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Product-Infrastructure-Team-Backlog (Kanban), Machine vision, Structured-Data-Backlog
Mholloway added a comment to T231032: Implement features that allow for tracking and measuring machine-aided depicts usage/activity.

Instrumentation capability that allows cross-referencing the tag confidence scores and the frequency of reversion

It's probably best if I add a column to machine_vision_label to track whether the label was reverted, in addition to the above added tag; will follow up with another patch.

Upon further reflection, a new column isn't required for this. Reverts can be identified by tag and the confidence score for the associated label up in machine_vision_suggestion.

Fri, Nov 15, 11:14 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Product-Infrastructure-Team-Backlog (Kanban), Machine vision, Structured-Data-Backlog
Mholloway added a comment to T238301: MediaWiki\Extension\MachineVision\Maintenance\FetchSuggestions::execute: no transaction to commit, something got out of sync regularly erroring since 2019-11-13.

Thanks, @jcrespo. It looks like the only practical effect in this case is the logspam, so I'll let the script run its course this time. Thanks also for the recommendations — that makes sense. We'll update accordingly for the next run.

Fri, Nov 15, 9:48 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Product-Infrastructure-Team-Backlog (Kanban), Machine vision, Wikimedia-production-error
Mholloway added a comment to T231032: Implement features that allow for tracking and measuring machine-aided depicts usage/activity.

Ah, I just scrolled up and found https://meta.wikimedia.org/wiki/Schema:MachineAidedDepictsUsage (again) -- @Ramsey-WMF, thoughts?

Fri, Nov 15, 4:34 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Product-Infrastructure-Team-Backlog (Kanban), Machine vision, Structured-Data-Backlog
Mholloway added a comment to T231032: Implement features that allow for tracking and measuring machine-aided depicts usage/activity.

Hi @Ramsey-WMF & @mpopov, I drafted an EventLogging schema for Special:SuggestedTags interactions: https://meta.wikimedia.org/wiki/Schema:SuggestedTagsAction. Please let me know your thoughts when you get a chance.

Fri, Nov 15, 3:53 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Product-Infrastructure-Team-Backlog (Kanban), Machine vision, Structured-Data-Backlog

Thu, Nov 14

Mholloway moved T238301: MediaWiki\Extension\MachineVision\Maintenance\FetchSuggestions::execute: no transaction to commit, something got out of sync regularly erroring since 2019-11-13 from To Do to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Thu, Nov 14, 7:56 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Product-Infrastructure-Team-Backlog (Kanban), Machine vision, Wikimedia-production-error
Mholloway claimed T238301: MediaWiki\Extension\MachineVision\Maintenance\FetchSuggestions::execute: no transaction to commit, something got out of sync regularly erroring since 2019-11-13.
Thu, Nov 14, 7:52 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Product-Infrastructure-Team-Backlog (Kanban), Machine vision, Wikimedia-production-error
Mholloway added a project to T238301: MediaWiki\Extension\MachineVision\Maintenance\FetchSuggestions::execute: no transaction to commit, something got out of sync regularly erroring since 2019-11-13: Product-Infrastructure-Team-Backlog (Kanban).
Thu, Nov 14, 7:52 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Product-Infrastructure-Team-Backlog (Kanban), Machine vision, Wikimedia-production-error
Mholloway added a comment to T238301: MediaWiki\Extension\MachineVision\Maintenance\FetchSuggestions::execute: no transaction to commit, something got out of sync regularly erroring since 2019-11-13.

The problem is this line, calling commitTransaction when no transaction has been opened: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/MachineVision/+/master/maintenance/fetchSuggestions.php#81

Thu, Nov 14, 7:51 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Product-Infrastructure-Team-Backlog (Kanban), Machine vision, Wikimedia-production-error
Mholloway added a comment to T238260: Suggested tag review window is very small.

Just to add a (negative) data point, I have never seen this.

Thu, Nov 14, 7:23 PM · Structured-Data-Backlog (Current Work)
Mholloway added a comment to T230845: Reader gets media links.

The specific files you'll want to look at are routes/page/media.js and lib/media.js.

Thu, Nov 14, 3:13 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)
Mholloway added a parent task for T237588: Security review for MachineVision libraries: T237596: Add MachineVision dependencies to vendor.
Thu, Nov 14, 2:57 PM · Security-Team-Reviews, Product-Infrastructure-Team-Backlog, MediaWiki-Vendor, Machine vision
Mholloway added a subtask for T237596: Add MachineVision dependencies to vendor: T237588: Security review for MachineVision libraries.
Thu, Nov 14, 2:57 PM · Product-Infrastructure-Team-Backlog, MediaWiki-Vendor, Machine vision
Mholloway moved T237596: Add MachineVision dependencies to vendor from Needs triage to Needs analysis on the Product-Infrastructure-Team-Backlog board.
Thu, Nov 14, 2:56 PM · Product-Infrastructure-Team-Backlog, MediaWiki-Vendor, Machine vision
Mholloway added a project to T237596: Add MachineVision dependencies to vendor: Product-Infrastructure-Team-Backlog.
Thu, Nov 14, 2:56 PM · Product-Infrastructure-Team-Backlog, MediaWiki-Vendor, Machine vision
Mholloway closed T238245: "We're sorry, something went wrong." on initial load of Special:SuggestedTags as Resolved.
Thu, Nov 14, 2:56 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), SDC-Statements (Machine-vision-depicts), Machine vision, Structured-Data-Backlog, Product-Infrastructure-Team-Backlog (Kanban)

Wed, Nov 13

Mholloway added a comment to T238245: "We're sorry, something went wrong." on initial load of Special:SuggestedTags.

This is the stack trace I'm seeing in exception.log log mwlog1001 that almost certainly corresponds to this bug.

Wed, Nov 13, 8:41 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), SDC-Statements (Machine-vision-depicts), Machine vision, Structured-Data-Backlog, Product-Infrastructure-Team-Backlog (Kanban)
Mholloway moved T238245: "We're sorry, something went wrong." on initial load of Special:SuggestedTags from To Do to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Wed, Nov 13, 8:38 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), SDC-Statements (Machine-vision-depicts), Machine vision, Structured-Data-Backlog, Product-Infrastructure-Team-Backlog (Kanban)
Mholloway claimed T238245: "We're sorry, something went wrong." on initial load of Special:SuggestedTags.
Wed, Nov 13, 8:37 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), SDC-Statements (Machine-vision-depicts), Machine vision, Structured-Data-Backlog, Product-Infrastructure-Team-Backlog (Kanban)
Mholloway added a comment to T238173: Special:SuggestedTags loads stale suggestions on back-navigation.

Basically, in FF, when you go back to the page the app doesn't seem to reload, it's present in the state it was before and shows you the batch of images that was fetched previously. But, I never saw any images that I had previously confirmed tags for.

This is consistent with my testing as well. In FF, the page returns to its exact previous state, and in Chromium, the API is re-queried. In neither case do I see images for which I've already voted.

Wed, Nov 13, 8:14 PM · Product-Infrastructure-Team-Backlog, SDC-Statements (Machine-vision-depicts), Machine vision, Structured-Data-Backlog
Mholloway updated the task description for T238245: "We're sorry, something went wrong." on initial load of Special:SuggestedTags.
Wed, Nov 13, 7:21 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), SDC-Statements (Machine-vision-depicts), Machine vision, Structured-Data-Backlog, Product-Infrastructure-Team-Backlog (Kanban)
Mholloway updated the task description for T238245: "We're sorry, something went wrong." on initial load of Special:SuggestedTags.
Wed, Nov 13, 7:20 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), SDC-Statements (Machine-vision-depicts), Machine vision, Structured-Data-Backlog, Product-Infrastructure-Team-Backlog (Kanban)
Mholloway triaged T238245: "We're sorry, something went wrong." on initial load of Special:SuggestedTags as High priority.
Wed, Nov 13, 7:19 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), SDC-Statements (Machine-vision-depicts), Machine vision, Structured-Data-Backlog, Product-Infrastructure-Team-Backlog (Kanban)
Mholloway created T238245: "We're sorry, something went wrong." on initial load of Special:SuggestedTags.
Wed, Nov 13, 7:19 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), SDC-Statements (Machine-vision-depicts), Machine vision, Structured-Data-Backlog, Product-Infrastructure-Team-Backlog (Kanban)
Mholloway moved T238173: Special:SuggestedTags loads stale suggestions on back-navigation from Doing to To Do on the Product-Infrastructure-Team-Backlog (Kanban) board.
Wed, Nov 13, 6:55 PM · Product-Infrastructure-Team-Backlog, SDC-Statements (Machine-vision-depicts), Machine vision, Structured-Data-Backlog
Mholloway placed T238173: Special:SuggestedTags loads stale suggestions on back-navigation up for grabs.

I cannot reproduce this, so I'll give it up to others to try. For the record, I tried locally, on test-commons, and on production Commons with Chromium 78.0.3904.70 and Firefox 70.0.1 on Ubuntu 18.04.

Wed, Nov 13, 6:55 PM · Product-Infrastructure-Team-Backlog, SDC-Statements (Machine-vision-depicts), Machine vision, Structured-Data-Backlog
Mholloway moved T238173: Special:SuggestedTags loads stale suggestions on back-navigation from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Wed, Nov 13, 5:40 PM · Product-Infrastructure-Team-Backlog, SDC-Statements (Machine-vision-depicts), Machine vision, Structured-Data-Backlog