Page MenuHomePhabricator

Correctly merge references of deleted files
Open, Needs TriagePublic

Description

The UserMerge extension currently does merge references of the fields fa_user and fa_user_text. However, it does not consider the field fa_deleted_user, which contains the user ID of the user, who deleted the file.

If there has been a file, which the user deleted using his old user account, then after the merge, the reference in fa_deleted_user will be broken, because it still points to the old user ID. It however should point to the new one.

To fix this, the field fa_deleted_user should still be added to the array of fields in UserMerge.php, function mergeDatabaseTables(), so that it gets updated as well!

Event Timeline

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 18 2016, 3:03 AM

Change 461125 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/UserMerge@master] Conditionally update few more tables as well

https://gerrit.wikimedia.org/r/461125

matej_suchanek updated the task description. (Show Details)

Change 461125 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/UserMerge@master] Conditionally update few more tables as well

https://gerrit.wikimedia.org/r/461125