Page MenuHomePhabricator

Correctly merge references of deleted files
Open, LowPublic

Description

The UserMerge extension currently does merge references of the fields fa_user and fa_user_text. However, it does not consider the field fa_deleted_user, which contains the user ID of the user, who deleted the file.

If there has been a file, which the user deleted using his old user account, then after the merge, the reference in fa_deleted_user will be broken, because it still points to the old user ID. It however should point to the new one.

To fix this, the field fa_deleted_user should still be added to the array of fields in UserMerge.php, function mergeDatabaseTables(), so that it gets updated as well!

Event Timeline

Change 461125 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/UserMerge@master] Conditionally update few more tables as well

https://gerrit.wikimedia.org/r/461125

Change 461125 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/UserMerge@master] Conditionally update few more tables as well

https://gerrit.wikimedia.org/r/461125

Aklapper added a subscriber: matej_suchanek.

@matej_suchanek: Removing task assignee as this open task has been assigned for more than two years - see the email sent to all task assignees on 2024-04-15.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!