Page MenuHomePhabricator

Allow Cite extension to hook into header expansion
Closed, DeclinedPublic

Description

For T70324, Cite needs to hook into Preprocessor::expand when headers are made. It can't be made with the ParserSectionCreate hook since it's called much later in the parse, at which point all references have already been processed.

Event Timeline

Change 273519 had a related patch set uploaded (by Cenarium):
Add ParserNewHeadingDone hook

https://gerrit.wikimedia.org/r/273519

thiemowmde subscribed.

This appears to be a purely technical ticket for a very specific change for something people don't even agree on is a problem. I suggest to continue the discussion in T70324, settle on a solution, and then create sub-tickets, if needed.

Change 273519 abandoned by Thiemo Kreuz (WMDE):
Add ParserNewHeadingDone hook

Reason:
The ticket T70324 that motivated this proposal is about the Cite extension. My team turned Cite inside out the past weeks. I don't think the change proposed here 4 years ago is needed. Cite changed a lot, and so did the code this patch here touches. I suggest to re-validate the original issue in T70324 first. I believe it doesn't even apply any more.

https://gerrit.wikimedia.org/r/273519