Page MenuHomePhabricator
Create Task
Maniphest T128795

As a user I would like to be able to "handoff" from browser to app and from app to browser
Closed, ResolvedPublic
Actions

Description

In order to support handoff from the desktop browser we need to update the site association file.

(We need to add the "handoff" service)

See the previous modification here:
https://gerrit.wikimedia.org/r/#/c/250897/

To verify the change has been deployed, check this file:
https://en.wikipedia.org/apple-app-site-association
You should now see a "webcredentials" dictionary and an "activity continuation" dictionary

To verify it is working correctly:

  1. uninstall the app
  2. install the app
  3. Ensure you are signed into iCloud on the device in the device settings.
  4. Lock the test device
  5. Open a en.wikipedia web page on a mac OR another iOS that is signed into the same iCloud account as the test device.
  6. Press the sleep wake button of the test device.
  7. Verify that you see a wikipedia icon in the bottom left corner of the screen
  8. Swipe up on the wikipedia icon in the bottom left corner of the screen
  9. Verify that the app opens with the same page as was in the browser.

Details

SubjectRepoBranchLines +/-
Support handoff and credential sharing with the iOS appoperations/mediawiki-configmaster+18 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Fjalapeno created this task.Mar 3 2016, 9:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 3 2016, 9:58 PM
• Fjalapeno added a comment.Mar 4 2016, 11:07 PM

https://en.wikipedia.org/apple-app-site-association

• JMinor triaged this task as High priority.Mar 7 2016, 8:22 PM
• JMinor added a project: iOS-app-v5.0.1-Kiwi.
• JMinor moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.
• Fjalapeno moved this task from Tasks from Product Backlog to Needs Estimation on the iOS-app-v5.0.1-Kiwi board.Mar 10 2016, 4:13 PM
• JMinor edited projects, added iOS-app-v5.0.2-Rubiks; removed iOS-app-v5.0.1-Kiwi.Mar 11 2016, 9:25 PM
• Fjalapeno claimed this task.Mar 22 2016, 4:20 PM
• Fjalapeno moved this task from Tasks from Product Backlog to Doing on the iOS-app-v5.0.2-Rubiks board.
• Fjalapeno mentioned this in T130841: As a user I would like to login to the app using saved credentials from Safari.Mar 24 2016, 5:00 PM

Also note we will be including the web credentials dictionary as part of this ticket as well to enable T130841 in a later update.

• Fjalapeno added a parent task: T130841: As a user I would like to login to the app using saved credentials from Safari.Mar 24 2016, 5:01 PM
• Fjalapeno moved this task from Doing to Needs Code Review on the iOS-app-v5.0.2-Rubiks board.Mar 24 2016, 5:21 PM

In review here:

https://gerrit.wikimedia.org/r/#/c/279394/

• Fjalapeno updated the task description. (Show Details)Mar 24 2016, 5:25 PM
Dereckson mentioned this in P2816 apple-app-site-association.Mar 25 2016, 3:27 AM
gerritbot subscribed.Mar 25 2016, 4:19 AM

Change 279394 had a related patch set uploaded (by Fjalapeno):
Update site association file to support handoff and credential sharing with the iOS app

https://gerrit.wikimedia.org/r/279394

gerritbot added a project: Patch-For-Review.Mar 25 2016, 4:19 AM
Krenair subscribed.Mar 25 2016, 4:47 AM

Yo should be able to open a wikipedia page in safari on your mac, and the lock screen your phone should have a wikipedia icon that you can slide up to continue reading the page on the device.

Without unlocking?

• Fjalapeno added a comment.Mar 25 2016, 4:53 AM
In T128795#2150429, @Krenair wrote:

Yo should be able to open a wikipedia page in safari on your mac, and the lock screen your phone should have a wikipedia icon that you can slide up to continue reading the page on the device.

Without unlocking?

No, you will still need to enter your passcode or use touch id

Dereckson added a project: Security-General.Mar 25 2016, 5:29 AM
Dereckson added subscribers: • csteipp, Dereckson.

@csteipp Do you think the Apple's Handoff / Continuity technology security paradigm acceptable? Users can disable it. It's available by default but requires all the devices to be (1) on the same wi-fi network (2) on the same bluetooth network (3) all logged to the same iCloud account.

• csteipp added a comment.Mar 25 2016, 6:03 PM

@Dereckson, I haven't studied it in depth, but my initial opinion is it isn't something I would personally use. But for protecting most wiki accounts (99.99% of which are unprivileged), it's probably fine. Like iMessage-- if you need security, use a product that is well studied and you know is safe instead. But for most users, iMassage is safe enough.

• JMinor added a project: iOS-app-feature-Links.Mar 28 2016, 5:45 PM
• JMinor edited projects, added iOS-app-v5.0.3-Disco; removed iOS-app-v5.0.2-Rubiks.Mar 30 2016, 10:11 PM
• JMinor moved this task from Tasks from Product Backlog to Needs Code Review on the iOS-app-v5.0.3-Disco board.Mar 30 2016, 11:05 PM
• Fjalapeno added a comment.Apr 4 2016, 6:53 PM

Scheduled for deployment on wednesday…

https://wikitech.wikimedia.org/wiki/Deployments#Wednesday.2C.C2.A0April.C2.A006

• Fjalapeno added a comment.Apr 4 2016, 6:55 PM

Note that it can take 5 days for iOS to update its cache.

• Fjalapeno updated the task description. (Show Details)Apr 4 2016, 6:58 PM
• Fjalapeno moved this task from Needs Code Review to Blocked or Waiting on the iOS-app-v5.0.3-Disco board.Apr 5 2016, 7:20 PM
• Fjalapeno moved this task from Blocked or Waiting to Needs Code Review on the iOS-app-v5.0.3-Disco board.
gerritbot added a comment.Apr 6 2016, 11:05 PM

Change 279394 merged by jenkins-bot:
Support handoff and credential sharing with the iOS app

https://gerrit.wikimedia.org/r/279394

• Fjalapeno moved this task from Needs Code Review to Needs Testing Criteria on the iOS-app-v5.0.3-Disco board.Apr 7 2016, 12:26 AM
• Fjalapeno moved this task from Needs Testing Criteria to Needs QA on the iOS-app-v5.0.3-Disco board.
• Fjalapeno added a comment.EditedApr 8 2016, 7:03 PM

IMG_7545.PNG (2×1 px, 793 KB)

How the icon looks on the lock screen ^

Nicholas.tsg subscribed.Apr 8 2016, 7:47 PM

First device: iPhone with iOS 9.3.1 and Wikipedia 5.0.3 (817), Second device: Mac OS X El Capitan (with same iCloud account as iPhone). When I returned to the iPhone in step 6 there was no Wikipedia icon on the bottom right of the screen. This is not fixed.

Nicholas.tsg moved this task from Needs QA to Blocked or Waiting on the iOS-app-v5.0.3-Disco board.Apr 8 2016, 7:48 PM
• Fjalapeno moved this task from Blocked or Waiting to Ready for PM Signoff on the iOS-app-v5.0.3-Disco board.Apr 12 2016, 4:38 PM
• Fjalapeno added a subscriber: • JMinor.

Just verified this again…

Used app store build.

Moving to PM signify for @JMinor to verify.

• JMinor closed this task as Resolved.Apr 21 2016, 9:22 PM

This is working for me now... lets add a regression test for this, so TSG can retest before public release, but I consider it resolved.

• Seton subscribed.Feb 22 2018, 3:51 AM
This comment was removed by Aklapper.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits