Page MenuHomePhabricator

Clicking on the left side of the search button opens the language picker
Closed, ResolvedPublic2 Estimated Story Points

Description

Found by @TJones when testing http://www.wikipedia.beta.wmflabs.org/

Steps to reproduce

  1. Go to http://www.wikipedia.beta.wmflabs.org/ (JS enabled)
  2. Click on the left side of the search button (blue button with search icon)

Expected behavior

  • The form is submitted

Actual behavior

  • The language picker opens.
  • The form is not submitted.

Event Timeline

We should be able to fix it by putting a z-index to the search button.

Now that the caching is no longer acting up, this is behaving as expected for me. Maybe it was an intermittent problem caused by other caching difficulties.

@TJones, apologies, it looks like an outdated version of the page was deployed to beta, thus you probably tested the wrong version.

Hi @TJones - can you retest this in your environment and let us know if it's still ongoing?

Thanks!

Change 276393 had a related patch set uploaded (by JGirault):
Fixes bug: Clicking on the left side of the search button opens the language picker

https://gerrit.wikimedia.org/r/276393

I went to http://www.wikipedia.beta.wmflabs.org/ just now and it's doing it again in Safari, Chrome, and Firefox on OS X.

(I like the idea of a version number on the page in beta—that would help a lot diagnosing cache and deployment problems.)

Change 276393 merged by jenkins-bot:
Fixes bug: Clicking on the left side of the search button opens the language picker

https://gerrit.wikimedia.org/r/276393

debt claimed this task.

Done and released on March 10, 2016 (PST)!