Page MenuHomePhabricator

MessageUtils::messageExists is busted
Closed, ResolvedPublic1 Story Points

Description

Say we have two languages:

es.json: { "foo": "hay problemas con foo", "defaultMessage":"hay problemas" }
en.json: { "foo": "problems with foo", "bar": "problems with bar", "defaultMessage":"problems" }

We want to get an error message in Spanish, as specific as possible. But if we ask for key "bar", it will give us the English message because there is no Spanish translation. We have a test that declares the message is not translated if we get the same as the English, and falls back to a less-specific error message. Unfortunately, this breaks on acronyms and things like "no", which are the same in both languages. We are getting unnecessarily vague errors.

Event Timeline

Ejegg created this task.Mar 11 2016, 1:36 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 11 2016, 1:36 AM

Change 276681 had a related patch set uploaded (by Ejegg):
Actually fix messageExists test

https://gerrit.wikimedia.org/r/276681

Ejegg set the point value for this task to 1.

Change 276681 merged by jenkins-bot:
Actually fix messageExists test

https://gerrit.wikimedia.org/r/276681

Ejegg closed this task as Resolved.Mar 11 2016, 5:45 AM
Ejegg moved this task from Review to Done on the Fundraising Sprint Elevator Maintenance 2016 board.