Page MenuHomePhabricator

Request for new hooks in link creations
Closed, DeclinedPublic

Description

Author: simon

Description:
Mainly in the file includes/Linker.php in the function getExternalLinkAttributes just before return $r; and one in getInternalLinkAttributes same location.

This would allow a few significant changes to the way links are placed online. Some prefer to not show titles, but it also could lead to more extensive implementations like different tracking methods (Google Analytics for one).


Version: unspecified
Severity: enhancement

Details

Reference
bz11104

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 9:51 PM
bzimport set Reference to bz11104.
bzimport added a subscriber: Unknown Object (MLST).

simon wrote:

Patch for adding the two hooks into Linker.php

attachment linkhooks.patch ignored as obsolete

*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*

sumanah wrote:

I'm sorry for the wait, Christian. I'm adding the "need-review" keyword so developers know that your patch is awaiting review. Thank you for your patch.

Comment on attachment 4056
Patch for adding the two hooks into Linker.php

Patch won't apply on trunk due to no familiar surrounding code

sumanah wrote:

Christian, if you'd like to revise your patch so that it works with the current version of the MediaWiki codebase, please come into our IRC channel
https://www.mediawiki.org/wiki/MediaWiki_on_IRC and discuss with us. Thanks!

I believe between the LinkBegin, LinkEnd, and LinkerMakeExternalLink hooks, there should be sufficient extension functionality.