Right now, scap checks have default timeout of 30 seconds, I have a huge check that takes more than that. It would be nice to have them in checks.yaml
Description
Description
Revisions and Commits
Revisions and Commits
rMSCA Scap | |||
Restricted Differential Revision | rMSCAbd6d1e39de2f Support per-check timeouts |
Related Objects
Related Objects
- Mentioned In
- T130404: Setup ORES service in beta cluster
Event Timeline
Comment Actions
Changing the timeout implementation to allow for per-check timeouts would be pretty straightforward:
- Remove the timeout parameter from checks.execute
- Introduce a timeout attribute/parameter in checks.Check (checks.load will pass everything specified in the YAML as a keyword argument so no change there)
- Implement a checks.CheckJob.hastimedout method that compares now the current job duration and the check's timeout.
- Refactor checks.execute to test job.hastimedout in the current path that handles timeouts