Page MenuHomePhabricator

Let scap checks have their timeouts ability to change
Closed, ResolvedPublic

Description

Right now, scap checks have default timeout of 30 seconds, I have a huge check that takes more than that. It would be nice to have them in checks.yaml

Revisions and Commits

rMSCA Scap
Restricted Differential Revision

Event Timeline

dduvall triaged this task as High priority.Mar 31 2016, 7:09 PM
dduvall subscribed.

Changing the timeout implementation to allow for per-check timeouts would be pretty straightforward:

  1. Remove the timeout parameter from checks.execute
  2. Introduce a timeout attribute/parameter in checks.Check (checks.load will pass everything specified in the YAML as a keyword argument so no change there)
  3. Implement a checks.CheckJob.hastimedout method that compares now the current job duration and the check's timeout.
  4. Refactor checks.execute to test job.hastimedout in the current path that handles timeouts
dduvall added a revision: Restricted Differential Revision.Mar 31 2016, 8:03 PM