Page MenuHomePhabricator
Create Task
Maniphest T132662

[Task] Do not use full deserialized entity for each PHP entity page view
Closed, ResolvedPublic
Actions

Description

Currently, OutputPageBeforeHTMLHookHandler always fetches an EntityRevision for displaying the termbox. Entity revisions are cached by CachingEntityRevisionLookup, so this does not hit us as hard as it could in terms of wgBackendResponseTime. The memory footprint due to that caching is probably quite high, though.

For entity page views on uncached entity revisions, getting rid of this should half wgBackendResponseTime.

Details

SubjectRepoBranchLines +/-
Put termbox rows into parser outputmediawiki/extensions/Wikibasemaster+121 -27
Clean-up mistakes from "put termbox rows into parser output"mediawiki/extensions/Wikibasemaster+10 -9
Don't load full entity on current revision viewmediawiki/extensions/Wikibasemaster+518 -10
Customize query in gerrit

Event Timeline

adrianheine created this task.Apr 14 2016, 7:52 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 14 2016, 7:52 AM
adrianheine added a project: Wikidata-Sprint-2016-04-12.Apr 14 2016, 7:52 AM
gerritbot subscribed.Apr 14 2016, 8:06 AM

Change 277777 had a related patch set uploaded (by Adrian Heine):
[WIP] Don't load full entity on current revision view

https://gerrit.wikimedia.org/r/277777

gerritbot added a project: Patch-For-Review.Apr 14 2016, 8:06 AM
adrianheine triaged this task as Medium priority.Apr 14 2016, 8:07 AM
adrianheine moved this task from Proposed to Doing on the Wikidata-Sprint-2016-04-12 board.
adrianheine moved this task from Doing to Review on the Wikidata-Sprint-2016-04-12 board.Apr 14 2016, 12:14 PM
adrianheine moved this task from Review to Doing on the Wikidata-Sprint-2016-04-12 board.Apr 19 2016, 9:27 AM
gerritbot added a comment.Apr 19 2016, 9:27 PM

Change 284358 had a related patch set uploaded (by Adrian Heine):
[WIP] Put termbox rows into parser output

https://gerrit.wikimedia.org/r/284358

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 9:27 PM
adrianheine moved this task from Doing to Review on the Wikidata-Sprint-2016-04-12 board.Apr 19 2016, 9:27 PM
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Apr 21 2016, 11:38 AM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-04-26.Apr 26 2016, 11:57 AM
Tobi_WMDE_SW moved this task from Proposed to Review on the Wikidata-Sprint-2016-04-26 board.Apr 26 2016, 11:58 AM
gerritbot added a comment.Apr 27 2016, 11:08 AM

Change 284358 merged by jenkins-bot:
Put termbox rows into parser output

https://gerrit.wikimedia.org/r/284358

adrianheine closed this task as Resolved.Apr 27 2016, 11:28 AM
adrianheine moved this task from Review to Done on the Wikidata-Sprint-2016-04-26 board.
gerritbot added a comment.Apr 27 2016, 12:29 PM

Change 277777 abandoned by Adrian Heine:
Don't load full entity on current revision view

https://gerrit.wikimedia.org/r/277777

TerraCodes unsubscribed.Apr 27 2016, 12:39 PM
gerritbot added a comment.Apr 27 2016, 4:31 PM

Change 285670 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Clean-up mistakes from "put termbox rows into parser output"

https://gerrit.wikimedia.org/r/285670

gerritbot added a comment.Apr 27 2016, 4:52 PM

Change 285670 merged by jenkins-bot:
Clean-up mistakes from "put termbox rows into parser output"

https://gerrit.wikimedia.org/r/285670

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL