Created attachment 4144
Fixing patch

Special:Uncategorizedpages derives from a different class than those other Special pages which show deleted pages as striken text. The patch fixes the bug I mentined here.

attachment PageQueryPage.patch ignored as obsolete

ayg wrote:

Note that the striking-out generally indicates that the page is no longer subject to inclusion. In this case, pages should be struck out if they have categories now. Deleted pages should by that logic always be struck out, but I'm not sure it makes sense to strike out *only* deleted pages. They should be red links, if applicable, but I would say that for consistency, striking-out shouldn't be used for them unless it's used for *all* pages that are no longer eligible for inclusion in the list. If you see what I mean.

Also, the existence checks should be done using a LinkBatch here. It's not necessarily critical, I know we have other places that just call Title::exists repeatedly, but really you shouldn't do that. It results in lots of unnecessary small queries instead of one slightly larger one. Other than that, I'd have to look closer to properly review the patch, which I don't have time for now.

Actually, when I created this patch, I simply copied (and modified) lines of code from the other Special pages which had the strike out feature with them; I mean, if a change towards LinkBatch is needed, it should happen to those Special pages too (if not already done).

• Bug 12679 has been marked as a duplicate of this bug. ***

With bug 12679 being marked as duplicate, I've updated the title of this bug too. Here is what I think: All special pages which show a list of pages should show the deleted pages as redlinks. Pages shouldn't be hidden from the list if they don't exist anymore. Any objections?

sumanah wrote:

Huji, thank you for the patch. I'm sorry, but in the time since you provided your patch, MediaWiki's codebase has changed enough that your patch no longer applies cleanly to trunk. Therefore I'm marking it obsolete and removing the "need-review" and "patch" keywords. If the issue is still one you're interested in fixing, please join us in IRC https://www.mediawiki.org/wiki/MediaWiki_on_IRC and talk with other developers before renewing and possibly revising your approach. Thanks for your interest in improving MediaWiki!

sumanah wrote:

Comment on attachment 4144
Fixing patch

This patch no longer applies to trunk per Rusty Burchfield's automated testing
https://docs.google.com/spreadsheet/ccc?key=0Ah_71HHl7qa7dGtvSms3TGpHQU9NU2Y1VmNzUEUteWc .