Page MenuHomePhabricator

Message Cx-tools-linter-title and Cx-tools-linter-content, triggered by abuse filter but not really an issue
Closed, DuplicatePublic

Description

Given that I have translated a page
And it generates a tag (?)
When I publish
Then I get a warning

Sort of..

The problem is that the warning is triggered by a filter that isn't really about issues, as the abuse filter is used as a general feature detector (or lack of feature). We can't simply assume it is some issue with the translated article, we only know the AbuseFilter generated some message.

I guess this is partly about AbuseFilter being used for the "wrong things", but it is really an edit filter.

In this specific case some users want a tag so they can do clean up later on. It is no consensus on this, but it is assumed to be an acceptable solution. The translated article isn't wrong per se, it just isn't quite what this group of users want. As such it isn't something that should trigger a warning, an information perhaps but not a warning.

Translating "issue" in this case into Norwegian worsen the problem as the Norwegian wording become stronger than the English one. The English "issue" translates into "problem", which is sort of right given it is a tag from "AbuseFilter" but is not right if the abuse filter is used as an edit filter.

screencap content translation 2016-05-02.png (580×1 px, 110 KB)

Top note says he article is published, while the box to the right side says the editor should continue editing, that is "Please fix the issues before publishing the translation. ". The article was in fact published. Perhaps the problem boils down to code expecting all responses from AbuseFilter to be blockage of the edits, while there should be two messages.

Event Timeline

And yes, I made the Norwegian translation of those strings so it is nearly me making a complaint about myself... :D

But please check the English source strings, not the translated ones. ;)

The actual error is a bogus abuse filter at nowiki, but the messages are somehow wrong. The bug report should probably be rephrased.

Change 290636 had a related patch set uploaded (by Eileen):
Remove trigger sql from submodule

https://gerrit.wikimedia.org/r/290636

Change 290636 merged by jenkins-bot:
Remove trigger sql from submodule

https://gerrit.wikimedia.org/r/290636

@jeblad, thanks for reporting.

The right tag for this is ContentTranslation and not CX-cxserver.

Also, this is probably a dupe of T132258, which was already fixed, and I'm marking it as such. Please reopen if I'm wrong.