Page MenuHomePhabricator

Make Debian package wikidiff2 compatible with PHP 7.0
Closed, ResolvedPublic

Description

Debian 9.0 Stretch will remove PHP 5 and only include PHP 7.0. This package wikidiff2 has dependencies to PHP 5 and is marked for autoremoval on May 20, 2016, at least if these dependencies remains.

It the first time I create a Debian package, but I worked to change these dependencies (available on https://github.com/Seb35/wikidiff2). I created and tested the package (php-wikidiff2) on Debian Stretch, it correctly compiles (with a patch) and it is correctly installed; so probably this could save it from deletion.

But there is a segfault in the resulting library, probably due to my patch: the way the value is returned was changed (it doesn’t compile without patch), and I probably didn’t write it in the right way. My patch followed https://wiki.php.net/phpng-upgrading#zend_string_api. (I didn’t write C++ since some years so I probably missed something.)


Debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=821633

Event Timeline

Change 293894 had a related patch set uploaded (by BryanDavis):
Update for PHP7 api changes

https://gerrit.wikimedia.org/r/293894

Change 293894 merged by jenkins-bot:
Update for PHP7 api changes

https://gerrit.wikimedia.org/r/293894

Applied patch and rebuilt package, and uploaded to https://mentors.debian.net/package/wikidiff2 for now

Legoktm claimed this task.

And updated package pushed to unstable, upstream bugs closed \o/