Page MenuHomePhabricator

Mark not-yet-loaded foreign notifications as read fails
Closed, ResolvedPublic

Description

The code that marks all foreign notifications as read

  1. Loads all notifications to get their IDs
  2. Uses the IDs to mark them as read

Since T130636, it fails to load the IDs.

Details

Related Gerrit Patches:

Event Timeline

SBisson created this task.May 6 2016, 2:13 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 6 2016, 2:13 PM
SBisson claimed this task.May 6 2016, 3:18 PM

Change 287232 had a related patch set uploaded (by Sbisson):
Fetch foreign notifications before marking them as read

https://gerrit.wikimedia.org/r/287232

Change 287232 merged by jenkins-bot:
Fetch foreign notifications before marking them as read

https://gerrit.wikimedia.org/r/287232

Checked in betalabs - it was one of the cases that were observed

28 messages vs 27 in the badge

0 alerts displayed red because it was from foreign wiki.

@Etonkovidova and @SBisson, I'm not clear on the status of this ticket. Is it fixed or not? From her last report, Elena would seem to be saying that this is broken. Thanks.

Those observations are not really related with this ticket.

Here's how to test:

  1. Make sure you have foreign notifications
  2. Open a notification flyout (Alert or Message, it doesn't matter)
  3. Mark the foreign notification bundle as read without expanding it
  4. reloading the page or reopening the flyout should confirm that the remote notifications have been marked as read

@Etonkovidova, please report the issues above in a new ticket (if you feel warranted). Thanks.

jmatazzoni closed this task as Resolved.May 17 2016, 8:29 PM