Page MenuHomePhabricator

Mark not-yet-loaded foreign notifications as read fails
Closed, ResolvedPublic


The code that marks all foreign notifications as read

  1. Loads all notifications to get their IDs
  2. Uses the IDs to mark them as read

Since T130636, it fails to load the IDs.

Screen Shot 2016-05-06 at 09.57.28.png (291×544 px, 46 KB)

Event Timeline

Change 287232 had a related patch set uploaded (by Sbisson):
Fetch foreign notifications before marking them as read

Change 287232 merged by jenkins-bot:
Fetch foreign notifications before marking them as read

Checked in betalabs - it was one of the cases that were observed

28 messages vs 27 in the badge

Screen Shot 2016-05-05 at 1.41.43 PM.png (310×637 px, 63 KB)

0 alerts displayed red because it was from foreign wiki.

Screen Shot 2016-05-05 at 4.03.19 PM.png (155×523 px, 29 KB)

@Etonkovidova and @SBisson, I'm not clear on the status of this ticket. Is it fixed or not? From her last report, Elena would seem to be saying that this is broken. Thanks.

Those observations are not really related with this ticket.

Here's how to test:

  1. Make sure you have foreign notifications
  2. Open a notification flyout (Alert or Message, it doesn't matter)
  3. Mark the foreign notification bundle as read without expanding it
  4. reloading the page or reopening the flyout should confirm that the remote notifications have been marked as read

@Etonkovidova, please report the issues above in a new ticket (if you feel warranted). Thanks.