The code that marks all foreign notifications as read
- Loads all notifications to get their IDs
- Uses the IDs to mark them as read
Since T130636, it fails to load the IDs.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fetch foreign notifications before marking them as read | mediawiki/extensions/Echo | master | +12 -70 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 287232 had a related patch set uploaded (by Sbisson):
Fetch foreign notifications before marking them as read
Comment Actions
Change 287232 merged by jenkins-bot:
Fetch foreign notifications before marking them as read
Comment Actions
Checked in betalabs - it was one of the cases that were observed
28 messages vs 27 in the badge
0 alerts displayed red because it was from foreign wiki.
Comment Actions
@Etonkovidova and @SBisson, I'm not clear on the status of this ticket. Is it fixed or not? From her last report, Elena would seem to be saying that this is broken. Thanks.
Comment Actions
Those observations are not really related with this ticket.
Here's how to test:
- Make sure you have foreign notifications
- Open a notification flyout (Alert or Message, it doesn't matter)
- Mark the foreign notification bundle as read without expanding it
- reloading the page or reopening the flyout should confirm that the remote notifications have been marked as read
Comment Actions
@Etonkovidova, please report the issues above in a new ticket (if you feel warranted). Thanks.