Page MenuHomePhabricator

CentralAuth uses master on POST requests for API/specialpages that return false for doesWrites()
Closed, ResolvedPublic

Description

These pages are treated as nullipotent, so DBPerformance log expectation are based on that. However, CentralAuth still uses the master on all POST requests (as a transitional measure). It should really only use it on requests which might write data (most particularly the CentralAuth endpoints the update user data).

Details

Related Gerrit Patches:

Event Timeline

aaron created this task.May 6 2016, 10:21 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 6 2016, 10:21 PM

Change 287292 had a related patch set uploaded (by Aaron Schulz):
Add WebRequest::isNullipotent()/markNullipotent() methods

https://gerrit.wikimedia.org/r/287292

Change 287292 merged by jenkins-bot:
Add WebRequest methods for determining "safe" requests

https://gerrit.wikimedia.org/r/287292

Change 288365 had a related patch set uploaded (by Aaron Schulz):
Avoid using the master DB for non-write POST requests

https://gerrit.wikimedia.org/r/288365

Change 288365 merged by jenkins-bot:
Avoid using the master DB for non-write POST requests

https://gerrit.wikimedia.org/r/288365

aaron closed this task as Resolved.May 19 2016, 7:27 PM