Proposed patch
I think old version is not longer needed.
Version: unspecified
Severity: normal
Attached:
Proposed patch
I think old version is not longer needed.
Version: unspecified
Severity: normal
Attached:
robchur wrote:
This will break the compatibility layer for all old MediaWiki installations and any extensions relying upon them.
(In reply to comment #1)
This will break the compatibility layer for all old MediaWiki installations and
any extensions relying upon them.
You think? Actually, do we need extensions for old MW versions? People, who need them, just have to switch to older SVN revision
Trying to dig through the revisions is too much of a pain.
We did start branching extensions. But I don't know how well the backporting et all will be, so I'd take that with a grain of salt. Also, some extensions are not on SVN.
robchur wrote:
I do not see any benefit in breaking a perfectly good compatibility layer, nor do I condone gratuitous breakage of backwards compatibility.
I strongly recommend against using ExtensionFunctions.php as it's a pain in the ass. Extensions should be self-sufficient.
(In reply to comment #5)
I strongly recommend against using ExtensionFunctions.php as it's a pain in the
ass. Extensions should be self-sufficient.
I'd have to agree, I've seen floods of "this doesn't work" threads and IRC complaints because of this.
robchur wrote:
I don't disagree with comment #5; what I object to is breaking the compatibility layer for those extensions which currently *do* use it, which includes third party extensions we don't maintain.
(In reply to comment #7)
I don't disagree with comment #5; what I object to is breaking the
compatibility layer for those extensions which currently *do* use it, which
includes third party extensions we don't maintain.
Yeah, I mentioned that in #3. We should leave extension functions alone. Rather, just replace all uses of it on SVN.