Page MenuHomePhabricator
Create Task
Maniphest T135180

Update ElasticsearchIntermediary::classifyErrorMessage() for es2.x
Closed, ResolvedPublic
Actions

Description

I just noticed while digging through some other things that this function was missed while we were upgrading things. This looks to primarily be used to distinguish between queries that fail and queries that are rejecting, which is then logged to graphite and shows up in our dashboards.

Details

SubjectRepoBranchLines +/-
Update classifyError to comply with new error handlingmediawiki/extensions/CirrusSearches2.x+111 -28
Customize query in gerrit

Event Timeline

EBernhardson created this task.May 12 2016, 9:46 PM
Restricted Application added projects: Discovery-ARCHIVED, Discovery-Search. · View Herald TranscriptMay 12 2016, 9:46 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald Transcript
• Deskana removed a project: Discovery-Search (Current work).May 12 2016, 10:00 PM
• Deskana edited projects, added Discovery-Search (Current work); removed Discovery-Search.
dcausse claimed this task.May 16 2016, 2:47 PM
dcausse moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.
gerritbot subscribed.May 16 2016, 5:18 PM

Change 288987 had a related patch set uploaded (by DCausse):
Update classifyError to comply with new error handling

https://gerrit.wikimedia.org/r/288987

gerritbot added a project: Patch-For-Review.May 16 2016, 5:18 PM
dcausse moved this task from not in use - please delete to Needs review on the Discovery-Search (Current work) board.May 16 2016, 5:20 PM
gerritbot added a comment.May 16 2016, 11:04 PM

Change 288987 merged by jenkins-bot:
Update classifyError to comply with new error handling

https://gerrit.wikimedia.org/r/288987

EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.May 23 2016, 4:07 PM
debt closed this task as Resolved.Jun 8 2016, 12:32 AM
debt subscribed.

Looks like this is resolved - closing.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits