Lots of Title::purgeExpiredRestriction from API DELETE FROM `page_restrictions` WHERE (pr_expiry < '20160517063108') without batching/throttling potentially causing lag on s5-api
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	jcrespo
	May 17 2016, 6:45 AM

Description

This could also cause network issues due to purging.

Details

	Subject	Repo	Branch	Lines +/-
	Limit DELETE in purgeExpiredRestrictions() and use primary key	mediawiki/core	master	+17 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		jcrespo	T135100 High replication lag to dewiki
		Resolved		aaron	T135470 Lots of Title::purgeExpiredRestriction from API DELETE FROM `page_restrictions` WHERE (pr_expiry < '20160517063108') without batching/throttling potentially causing lag on s5-api

Event Timeline

jcrespo created this task.May 17 2016, 6:45 AM

Restricted Application added a project: SRE. · View Herald TranscriptMay 17 2016, 6:45 AM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald Transcript

jcrespo added a parent task: T135100: High replication lag to dewiki.May 17 2016, 6:52 AM

There were hundreds of queries in the last hour, the largest ones taking 15 seconds:

db1049	wikiuser	dewiki	mw1226	-	195772733	59961145543	15s	2016-05-17 06:29:54
DELETE /* Title::purgeExpiredRestrictions Doc Taxon */ FROM `page_restrictions` WHERE (pr_expiry < '20160517062948')

jcrespo added a comment.May 17 2016, 7:22 AM

This comment was removed by jcrespo.

jcrespo mentioned this in T135471: Hundreds of concurrent SELECT MASTER_POS_WAIT('db1049-bin.002927', 354219766, 10) without debugging information (no user, not function) on s5 API node.May 17 2016, 7:24 AM

Joe triaged this task as High priority.May 17 2016, 10:44 AM

Change 289170 had a related patch set uploaded (by Aaron Schulz):
Limit DELETE in purgeExpiredRestrictions() and use primary key

https://gerrit.wikimedia.org/r/289170

gerritbot added a project: Patch-For-Review.May 17 2016, 11:22 AM

Change 289170 merged by jenkins-bot:
Limit DELETE in purgeExpiredRestrictions() and use primary key

https://gerrit.wikimedia.org/r/289170