Page MenuHomePhabricator

ORES cannot score multiple revisions
Closed, ResolvedPublic

Description

This request returns a 500 error: https://ores.wmflabs.org/v2/scores/enwiki/damaging/?revids=216123|32423423|3243242|234324

Traceback (most recent call last):
  File "/home/halfak/env/3.4/lib/python3.4/site-packages/flask/app.py", line 1836, in __call__
    return self.wsgi_app(environ, start_response)
  File "/home/halfak/env/3.4/lib/python3.4/site-packages/flask/app.py", line 1820, in wsgi_app
    response = self.make_response(self.handle_exception(e))
  File "/home/halfak/env/3.4/lib/python3.4/site-packages/flask/app.py", line 1403, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/home/halfak/env/3.4/lib/python3.4/site-packages/flask/_compat.py", line 33, in reraise
    raise value
  File "/home/halfak/env/3.4/lib/python3.4/site-packages/flask/app.py", line 1817, in wsgi_app
    response = self.full_dispatch_request()
  File "/home/halfak/env/3.4/lib/python3.4/site-packages/flask/app.py", line 1477, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/home/halfak/env/3.4/lib/python3.4/site-packages/flask/app.py", line 1381, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/home/halfak/env/3.4/lib/python3.4/site-packages/flask/_compat.py", line 33, in reraise
    raise value
  File "/home/halfak/env/3.4/lib/python3.4/site-packages/flask/app.py", line 1475, in full_dispatch_request
    rv = self.dispatch_request()
  File "/home/halfak/env/3.4/lib/python3.4/site-packages/flask/app.py", line 1461, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/home/halfak/projects/ores-wikimedia-config/submodules/ores/ores/wsgi/routes/v2/scores.py", line 156, in score_revisions_v2
    context, model, rev_ids, precache=precache)
  File "/home/halfak/projects/ores-wikimedia-config/submodules/ores/ores/score_processors/score_processor.py", line 32, in score
    include_features=include_features)
  File "/home/halfak/projects/ores-wikimedia-config/submodules/ores/ores/score_processors/celery.py", line 177, in _score
    include_features=include_features)
  File "/home/halfak/projects/ores-wikimedia-config/submodules/ores/ores/score_processors/celery.py", line 95, in _score_in_celery
    caches=caches)
  File "/home/halfak/projects/ores-wikimedia-config/submodules/ores/ores/score_processors/score_processor.py", line 60, in _get_root_ds
    roots = scoring_context.extract_roots(model, rev_ids, caches=caches)
  File "/home/halfak/projects/ores-wikimedia-config/submodules/ores/ores/scoring_contexts/scoring_context.py", line 100, in extract_roots
    for rev_id, (error, root_vals) in zip(rev_ids, error_root_vals):
  File "/home/halfak/env/3.4/lib/python3.4/site-packages/revscoring/extractors/api/extractor.py", line 114, in _extract_many
    rev_cache = caches[rev_id]
KeyError: 324234

Event Timeline

Issue exists in revscoring==1.2.4, but not revscoring==1.2.6

I just pushed https://gerrit.wikimedia.org/r/290902. This switches our wheels repo to use 1.2.6

Deployed! And it looks like we are OK

Ladsgroup claimed this task.