Page MenuHomePhabricator

commonPrint.css: Proof and fix overqualified selectors and use of `!important` (CSSLint)
Closed, DeclinedPublic

Description

Follow-up on T120154: Align commonPrint.css to (most) CSSLint errors&warnings and WMF's CSS Coding guidelines and cleanup:
Proof and fix overqualified selectors and use of !important in current commonPrint.css where applicable.

Currently CSSLint returns 60 warnings:

  • 16 overqualified selectors
  • 16 usage of !important
  • 16 usage of ID in selectors

Details

Event Timeline

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 28 2016, 12:34 AM
Volker_E updated the task description. (Show Details)May 28 2016, 12:38 AM

Change 313363 had a related patch set uploaded (by VolkerE):
commonPrint: Remove overqualified selectors & !important where applicable

https://gerrit.wikimedia.org/r/313363

Hmmm, I'm not sure it's worth potential new bugs to address these linting warnings, particularly in a "legacy" stylesheet.

Change 313363 merged by jenkins-bot:
commonPrint: Remove overqualified selectors & !important where applicable

https://gerrit.wikimedia.org/r/313363

Volker_E closed this task as Declined.EditedJan 6 2018, 2:00 AM

With above patch we came down from 16 to 8 overqualified selectors. Gonna put this on declined fwiw. We can always re-open if we gonna feel need for more work here.