Page MenuHomePhabricator

Unknown_action error should return an error object
Closed, ResolvedPublic


Author: russblau

Description: results in a text error message:

unknown_action: Unrecognised value for parameter 'action'

To be consistent with the treatment of other errors, it really should return a formatted response (in XML, or JSON, or whatever format has been selected) with an "error" attribute.

Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:00 PM
bzimport set Reference to bz11673.

cannon.danielc wrote:

Yes, it definitely should. I'm having a really hard time trying to diagnose this bug -- the code is clearly trying to produce a formatted message, but not succeeding for reasons unknown to me. Hopefully Yuri can figure it out better than I can :) Changing severity to "normal"--when a user requests an xml document and doesn't get one back, even if he specified an invalid parameter (or possibly a parameter that will be implemented in later versions, but hasn't been yet), that's a real problem, not a request for a trivial enhancement.

Bryan.TongMinh wrote:

Fixed in r32824.

Bryan.TongMinh wrote:

*** Bug 14942 has been marked as a duplicate of this bug. ***