Page MenuHomePhabricator

BaseBot.userPut gives wrong result when trying to add spaces
Closed, ResolvedPublic

Description

BaseBot.userPut() method gives wrong result when trying to add spaces or newlines at the end of the page. MediaWiki does not respect adding any space to the end but strips it. Unfortunately userPut() method only checks for differences including empty spaces at the end and returns True but it should return False in that case.

The result of userPut() might be used for further bot action which could be declined when no edit was done.

Event Timeline

Change 293905 had a related patch set uploaded (by Xqt):
[bugfix] lstrip() strings before comparing for changes

https://gerrit.wikimedia.org/r/293905

Xqt triaged this task as Medium priority.

Change 293905 merged by jenkins-bot:
[bugfix] rstrip() strings before comparing for changes

https://gerrit.wikimedia.org/r/293905

Change 295990 had a related patch set uploaded (by Xqt):
[fixed] remove rstrip() because T137637 has been fixed

https://gerrit.wikimedia.org/r/295990

Change 295990 merged by jenkins-bot:
[fixed] remove rstrip() because T137637 has been fixed

https://gerrit.wikimedia.org/r/295990