Page MenuHomePhabricator
Create Task
Maniphest T138257

document missing exceptions seem to be triggering a re-queue of the ElasticaWrite job
Closed, ResolvedPublic
Actions

Description

Might be a new bug since we deployed 2.x. When the document is missing we should be considering the write job that triggered it "ok" but in the CirrusSearch.log on fluorine it looks like the jobs and being requeued which means they need to fail multiple times before being abandoned.

Details

SubjectRepoBranchLines +/-
Fix DataSender::justDocumentMissingExceptionmediawiki/extensions/CirrusSearchREL1_27+2 -3
Properly handle document missing exceptionsmediawiki/extensions/CirrusSearchmaster+5 -5
Customize query in gerrit

Event Timeline

EBernhardson created this task.Jun 20 2016, 8:21 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 20 2016, 8:21 PM
EBernhardson renamed this task from document missing exceptions seem to be triggering a re-queue of the to document missing exceptions seem to be triggering a re-queue of the ElasticaWrite job.Jun 20 2016, 8:22 PM
EBernhardson added a project: CirrusSearch.
EBernhardson updated the task description. (Show Details)
Restricted Application added projects: Discovery-ARCHIVED, Discovery-Search. · View Herald TranscriptJun 20 2016, 8:22 PM
EBernhardson edited projects, added Discovery-Search (Current work); removed Discovery-Search.Jun 21 2016, 10:19 PM
EBernhardson claimed this task.Jun 29 2016, 7:47 PM
EBernhardson moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.
gerritbot subscribed.Jun 29 2016, 8:37 PM

Change 296645 had a related patch set uploaded (by EBernhardson):
Fix DataSender::justDocumentMissingException

https://gerrit.wikimedia.org/r/296645

gerritbot added a project: Patch-For-Review.Jun 29 2016, 8:37 PM
gerritbot added a comment.Jun 29 2016, 8:45 PM

Change 296649 had a related patch set uploaded (by EBernhardson):
Properly handle document missing exceptions

https://gerrit.wikimedia.org/r/296649

EBernhardson moved this task from not in use - please delete to Needs review on the Discovery-Search (Current work) board.Jun 29 2016, 8:45 PM
gerritbot added a comment.Jun 30 2016, 8:06 AM

Change 296649 merged by jenkins-bot:
Properly handle document missing exceptions

https://gerrit.wikimedia.org/r/296649

• dcausse moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Jun 30 2016, 8:17 AM
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-05_(1.28.0-wmf.9)).Jun 30 2016, 9:00 AM
gerritbot added a comment.Jun 30 2016, 2:17 PM

Change 296645 abandoned by EBernhardson:
Fix DataSender::justDocumentMissingException

Reason:
wrong branch

https://gerrit.wikimedia.org/r/296645

debt closed this task as Resolved.Jul 21 2016, 6:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits