Form styles are missing on Wikibase special pages (ones related to editing, e.g. Special:SetSiteLink) in mobile view.
This makes it confusing to try to edit an item using these special pages.
| aude | |
| Jun 22 2016, 3:09 PM |
| F4192061: specialsetsitelink.png | |
| Jun 22 2016, 3:09 PM |
Form styles are missing on Wikibase special pages (ones related to editing, e.g. Special:SetSiteLink) in mobile view.
This makes it confusing to try to edit an item using these special pages.
This block is missing:
.mw-ui-input {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
display: block;
width: 100%;
border: 1px solid #cccccc;
border-radius: 2px;
padding: 0.3em 0.3em 0.3em 0.6em;
font-family: inherit;
font-size: inherit;
line-height: inherit;
vertical-align: middle;
}Some change in MobileFrontend has made it disappear.
Change 298259 had a related patch set uploaded (by Jonas Kress (WMDE)):
Fix: Form styles are missing on Wikibase special pages in mobile view
Just uploaded a quick fix.
I think we should convert the form to OOUI form, to have a clean fix.
Maybe something @Ricordisamoa would like to do.
Change 298259 merged by jenkins-bot:
Fix: Form styles are missing on Wikibase special pages in mobile view
Just a note it has always been the case that mediawiki.ui.input has to be explicitly added to special pages.
Change 299161 had a related patch set uploaded (by Aude):
Add mediawiki.ui.input for all SpecialModifyEntity pages
Change 299161 merged by jenkins-bot:
Add mediawiki.ui.input for all SpecialModifyEntity pages
Appears to not be done, at least https://test.m.wikidata.org/wiki/Special:SetSiteLink/Q2205 is still unstyled. I assume there is a CSS class name missing on the form or something.
Double checked locally. Also http://wikidata.beta.wmflabs.org/wiki/Special:SetSiteLink?useformat=mobile got updated, while https://test.m.wikidata.org/wiki/Special:SetSiteLink/Q2205 still misses an update.