Page MenuHomePhabricator

Revision not found error unformatted and not localized
Closed, ResolvedPublic

Description

When labeling revisions, this sometimes shows up. It's not localized and the revision ID is not substituted in place of the $1.

{
  "code": "revision not found",
  "message": "Could not get metadata for revision $1"
}

Event Timeline

This is expected behavior. It means that the revision to be labeled has been deleted (or is somehow otherwise not available). However, the $1 should include a substituted rev_id and the string should be localized.

The code doesn't look obviously wrong here. See https://github.com/wiki-ai/wikilabels/blob/master/wikilabels/wsgi/static/js/wikiLabels/api.js#L50

Halfak renamed this task from Revision not found - Wikilabels to Revision not found error unformatted and not localized.Jul 28 2016, 2:21 PM
Halfak triaged this task as Medium priority.
Halfak updated the task description. (Show Details)