Maniphest T140039

Crash if trying to 3d touch / peek link in article reference panel.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Mhurd
	Jul 11 2016, 11:10 PM

Tags

Referenced Files

None

Subscribers

Description

Repro:

load "enwiki > Tyrannosaurus"
tap second reference link "[2]"
when reference panel appears try to peek a link in the panel
crash!

Fixed here: https://github.com/wikimedia/wikipedia-ios/pull/769

Related Objects

Mentioned Here: T139139: The app crashes when long pressing on an external link in citation window

Event Timeline

Mhurd created this task.Jul 11 2016, 11:10 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 11 2016, 11:10 PM

Mhurd added a project: Wikipedia-iOS-App-Backlog.Jul 11 2016, 11:11 PM

Mhurd claimed this task.Jul 11 2016, 11:15 PM

Mhurd moved this task from Needs Code Review to Needs QA on the iOS-app-v5.1.0-Saturn board.Jul 14 2016, 10:07 PM

Mhurd merged a task: T140168: Fix crash on 3d touch on reference panel link..

Testing on iOS 9.3.1 and Wikipedia 5.0.5 (901.1). Tapping and holding the link still causes crashing (quick tapping works fine).

In T140039#2473812, @Nicholas.tsg wrote:

Tapping and holding the link still causes crashing

That would be T139139: The app crashes when long pressing on an external link in citation window. This ticket is for the 3d-touch-peeking.

• Fjalapeno moved this task from Needs QA to Needs Testing Criteria on the iOS-app-v5.1.0-Saturn board.Jul 19 2016, 2:29 AM

• Fjalapeno edited projects, added iOS-app-v5.0.5-Fever, iOS-app-Bugs; removed iOS-app-v5.1.0-Saturn.Jul 22 2016, 8:13 PM

• Fjalapeno moved this task from Tasks from Product Backlog to Needs Testing Criteria on the iOS-app-v5.0.5-Fever board.

• Fjalapeno triaged this task as Medium priority.Jul 25 2016, 5:34 PM

• Fjalapeno triaged this task as Medium priority.

• Fjalapeno moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.

• Fjalapeno moved this task from Needs Testing Criteria to Verify Test Coverage on the iOS-app-v5.0.5-Fever board.Jul 25 2016, 5:58 PM

I don't think we need to test this with every regression run. Its not a common action or source of risk.