Page MenuHomePhabricator
Create Task
Maniphest T140390

Magnifying glass overlaps at 240px resolution
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Resize browser to 240px (as used by some Opera Mini browsers) and you'll see:

Screen Shot 2016-07-14 at 10.43.28 AM.png (302×295 px, 34 KB)

Expected: We should hide the icon in this situation

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix rendering of magnifying glass for small screensmediawiki/extensions/MobileFrontendmaster+1 -0
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Jul 14 2016, 5:44 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 14 2016, 5:44 PM
gerritbot subscribed.Jul 14 2016, 5:54 PM

Change 299010 had a related patch set uploaded (by Jdlrobson):
Fix rendering of magnifying glass for small screens

https://gerrit.wikimedia.org/r/299010

gerritbot added a project: Patch-For-Review.Jul 14 2016, 5:54 PM
gerritbot added a comment.Jul 15 2016, 9:31 AM

Change 299010 merged by jenkins-bot:
Fix rendering of magnifying glass for small screens

https://gerrit.wikimedia.org/r/299010

• bmansurov subscribed.Jul 15 2016, 9:43 AM

The above patch fixes the issue for browsers that support JS, but for non-JS browsers I see the left padding, but not the icon. We should either remove the padding, or bring back the icon.

Screen Shot 2016-07-15 at 2.42.06 PM.png (1×1 px, 444 KB)

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-19_(1.28.0-wmf.11)).Jul 15 2016, 10:00 AM
Jdlrobson reopened this task as Open.Jul 18 2016, 4:56 PM
Jdlrobson closed this task as a duplicate of T140490: Search magnifying glass and placeholder text mashed together in Opera Mini extreme mode (all resolutions).

Per https://phabricator.wikimedia.org/T140390#2465367

Jdlrobson closed this task as Resolved.Jul 18 2016, 5:11 PM
Jdlrobson claimed this task.

ignore above comment

Jdlrobson renamed this task from Magnifying glass overlaps on the smallest screens to Magnifying glass overlaps at 240px resolution.Aug 1 2016, 5:16 PM
Jdlrobson added a project: Reading-Web-Sprint-77-Segmentation-fault.
Jdlrobson moved this task from Needs Analysis to Ready for Signoff on the Reading-Web-Sprint-77-Segmentation-fault board.
Jdlrobson set the point value for this task to 2.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits