To distinguish, if the event happens in opened/stalled or resolved/invalid task, it would be practical to have the latter to be printed in grey instead of white on IRC. (Tags and other colors remain, just the title, link and comment)
Description
Description
Details
Details
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| Enhance Phorge event rendering | toolforge-repos/wikibugs2!17 | bd808 | work/bd808/irc-formatting | main |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | BUG REPORT | bd808 | T360353 Hashar does not like grey foreground color for distinguishing closed status events | ||
| Resolved | Feature | bd808 | T140881 Print events in closed tasks in grey |
Event Timeline
Comment Actions
This will require always passing the current status of the task to the message formatter. Currently we only pass status if the transaction group triggering the message included a status transition. As a corollary, the status that is always passed should be keyed different than the data for a status transition. current_status seems like a reasonable choice for the new key.
Comment Actions
Actually it will be even easier to propagate the "isClosed" boolean from maniphest.info as the toggle for this behavior.
Comment Actions
I found out wikibugs changed some of its messages text color to grey which has led https://gitlab.wikimedia.org/toolforge-repos/wikibugs2/-/commit/a4fe92d27196a2586b0fcb9c9593c03b22e6c8e0 and this task.
That turned some texts to light grey it is barely readable for me. I could possibly:
- change the grey to be darker / black but that defeat its purposes in other context when a dimmed text is desirable
- change the notification background color to something else but I don't quite see what would work with a light grey (maybe a way darker background, then it would stand out to much).
I'd like the foreground text to remain the default color. Maybe the different colors for Open → Resolved is sufficient to distinguish them from other kind of task. An alternative would be to use emojis?
Comment Actions
I created T360353: Hashar does not like grey foreground color for distinguishing closed status events for the bug report that was used to reopen this completed task.