wdqs-app-footer-updated-after must include the date
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Amire80
	Aug 15 2016, 5:03 PM

Description

The message Wdqs-app-footer-updated-after only says "ago", and I guess that it is supposed to be stuck after the time. If the whole string says something like "two days ago", then it must also include the time itself. It would probably be best to use the same library that Flow uses (not sure if it's Moment.js or something else).

Details

	Subject	Repo	Branch	Lines +/-
	Merging from 98cec07b87e7699dd33cbfd43b3f0416a5ab954a:	wikidata/query/gui-deploy	production	+6 -6
	Display data updated message as single message.	wikidata/query/gui	master	+14 -17

Customize query in gerrit

Related Objects

Mentioned In: rWDQG4e78b8fe6f02: Display data updated message as single message.
rWDQG98cec07b87e7: Display data updated message as single message.
T143071: [[Wikimedia:Wdqs-app-footer-updated-after/ast]] i18n issue
Mentioned Here: rWDQG98cec07b87e7: Display data updated message as single message.

Event Timeline

Amire80 created this task.Aug 15 2016, 5:03 PM

Restricted Application added projects: Wikidata, Discovery-ARCHIVED. · View Herald TranscriptAug 15 2016, 5:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Yeah it'd be nice for WDQS to predict Wikidata edits but I suppose that's not happening yet ;) So WDQS is always behind wikidata, even if by a little. Making it displayed as a whole string by a library may be nice, if we have one. Adding @Jonas.

Smalyshev moved this task from Incoming to GUI on the Wikidata-Query-Service board.Aug 15 2016, 5:19 PM

It's possible that I misunderstand the purpose of the string, but that's something that the qqq should make clear :)

There should be only one message instead of two.
Something like "Data updated $1 ago"
The $1 is updated frequently and on mouse over.

I have no objection to making it single message

Liuxinyu970226 mentioned this in T143071: [[Wikimedia:Wdqs-app-footer-updated-after/ast]] i18n issue.Aug 16 2016, 3:13 AM

Liuxinyu970226 merged a task: T143071: [[Wikimedia:Wdqs-app-footer-updated-after/ast]] i18n issue.

Liuxinyu970226 added subscribers: Xuacu, Liuxinyu970226.

The issue here is that for Asturian, Spanish and other languages we need the string for $time to come after the string for $ago to get a correct sentence.
Regards.

mxn subscribed.Aug 24 2016, 4:45 AM

• Jonas assigned this task to Stas.Aug 27 2016, 6:28 AM

• Jonas reassigned this task from Stas to Smalyshev.

• Jonas added a subscriber: Stas.

Change 307473 had a related patch set uploaded (by Smalyshev):
Display data updated message as single message.

https://gerrit.wikimedia.org/r/307473

gerritbot added a project: Patch-For-Review.Aug 30 2016, 6:06 AM

Diffusion mentioned this in rWDQG98cec07b87e7: Display data updated message as single message..Aug 30 2016, 6:10 AM

Diffusion mentioned this in rWDQG4e78b8fe6f02: Display data updated message as single message..

• Jonas closed this task as Resolved.Aug 30 2016, 6:33 AM

Change 307473 merged by jenkins-bot:
Display data updated message as single message.

https://gerrit.wikimedia.org/r/307473

Change 307538 had a related patch set uploaded (by Smalyshev):
Merging from 98cec07b87e7699dd33cbfd43b3f0416a5ab954a:

https://gerrit.wikimedia.org/r/307538

Change 307538 merged by Smalyshev:
Merging from 98cec07b87e7699dd33cbfd43b3f0416a5ab954a: