Page MenuHomePhabricator
Create Task
Maniphest T143023

TOC on iPad should remember its state
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The open/close state of the TOC on iPad should persist across article views. If the user has opened or closed the TOC, when another article is loaded from any source (Explore, search, tap on a link) the article view should keep the open/close state, and not re-open the TOC.

This should not affect the first view of the article reader on iPad, where the TOC should be open, as in the initial design.

Related Objects
Search...

Event Timeline

• JMinor created this task.Aug 15 2016, 6:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 15 2016, 6:23 PM
• JMinor triaged this task as Medium priority.Aug 15 2016, 6:24 PM
• JMinor moved this task from Backlog to Needs Estimation on the iOS-app-v5.1.0-Saturn board.
JoeWalsh claimed this task.Aug 15 2016, 9:04 PM
JoeWalsh set the point value for this task to 1.

https://github.com/wikimedia/wikipedia-ios/pull/838

JoeWalsh moved this task from Needs Estimation to Needs Code Review on the iOS-app-v5.1.0-Saturn board.Aug 15 2016, 9:05 PM
RHo created subtask T143093: TOC appear no LHS across all devices (for LTR).Aug 16 2016, 11:34 AM
• Fjalapeno moved this task from Needs Code Review to Needs Testing Criteria on the iOS-app-v5.1.0-Saturn board.Aug 16 2016, 6:08 PM
• JMinor moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.Aug 17 2016, 12:52 AM
• Fjalapeno moved this task from Needs Testing Criteria to Needs Design Review on the iOS-app-v5.1.0-Saturn board.Aug 17 2016, 4:08 PM
• Fjalapeno subscribed.

To test:

  1. Open any article on iPad
  2. Open the ToC if not already open
  3. Close the article
  4. Open a different article
  5. Verify the ToC is open
  6. Close the ToC
  7. Close the article
  8. Open a different article
  9. Verify the ToC is closed
• Fjalapeno moved this task from Needs Design Review to Needs QA on the iOS-app-v5.1.0-Saturn board.Aug 17 2016, 4:10 PM
Nicholas.tsg subscribed.Aug 18 2016, 7:43 PM

Testing on iPad Air/iOS 9.3.4 and Wikipedia app 5.1.0 (912). The ToC was closed when opening a different article after closing the ToC on the previous article so this is fixed.

Nicholas.tsg moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.1.0-Saturn board.Aug 18 2016, 7:43 PM
• JMinor closed this task as Resolved.Aug 23 2016, 6:38 PM
• JMinor closed subtask T143093: TOC appear no LHS across all devices (for LTR) as Resolved.Aug 23 2016, 10:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL