Page MenuHomePhabricator

MAX_FILE_SIZE shouldn't be hard coded in SpecialImport.php
Closed, ResolvedPublic


Currently, MAX_FILE_SIZE is hardcoded in SpecialImport.php, which should be changed so that it could be set thorugh LocalSettings.php

Version: unspecified
Severity: enhancement



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:59 PM
bzimport set Reference to bz12493.
bzimport added a subscriber: Unknown Object (MLST).

I've removed the limit in r29234; I can't really see any reason to have the extra limit. Not really sure how it snuck in, but it's been there since 2005. :)

I think it was there because PHP really has two ways to know the maximum upload size: through php.ini settings and by MAX_FILE_SIZE paramter sent togeather with the file ( However, I agree with you that it is useless and should have been removed already.