SecurePoll tally should show parsed options correctly
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Huji
	Sep 12 2016, 2:48 PM

Description

Currently, the tally will parse the option text (for instance if it contains wikicode for a link, it will create a linnk) but the output is returned as raw HTML, see screenshot below.

Details

	Subject	Repo	Branch	Lines +/-
	SecurePoll tally should show parsed options correctly	mediawiki/extensions/SecurePoll	master	+3 -1

Customize query in gerrit

Event Timeline

Huji created this task.Sep 12 2016, 2:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 12 2016, 2:48 PM

Huji triaged this task as Low priority.Sep 12 2016, 2:48 PM

Huji added a project: MediaWiki-extensions-SecurePoll.

Turns out it is happening because the option's text was passed to the XML::element funciton which assumes what is given to it is plain text, and escapes HTML chars. I will submit a patch shortly that fixes it.

Change 310051 had a related patch set uploaded (by Huji):
SecurePoll tally should show parsed options correctly

https://gerrit.wikimedia.org/r/310051

gerritbot added a project: Patch-For-Review.Sep 12 2016, 5:44 PM

Huji claimed this task.Sep 12 2016, 5:45 PM

Change 310051 merged by jenkins-bot:
SecurePoll tally should show parsed options correctly

https://gerrit.wikimedia.org/r/310051

aaron closed this task as Resolved.Sep 12 2016, 8:35 PM

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)).Sep 12 2016, 9:00 PM

SecurePoll tally should show parsed options correctlyClosed, ResolvedPublicActions

Description

Details

Event Timeline

SecurePoll tally should show parsed options correctly
Closed, ResolvedPublic
Actions