Page MenuHomePhabricator
Create Task
Maniphest T145503

Build a maintenance script to clean up duplicate data.
Closed, ResolvedPublic
Actions

Description

See the parent task

Details

SubjectRepoBranchLines +/-
Revert "Add maintenance/CleanDuplicateScores.php"mediawiki/extensions/ORESmaster+0 -59
Add maintenance/CleanDuplicateScores.phpmediawiki/extensions/ORESmaster+59 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ladsgroup created this task.Sep 13 2016, 10:55 AM
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptSep 13 2016, 10:55 AM
jcrespo added a comment.Sep 13 2016, 10:58 AM

Tip/question: why they were inserted in the firs place? Will we have common duplicate key inserts in the future?

Ladsgroup added a comment.Sep 13 2016, 11:07 AM

They shouldn't have inserted in the first place. We have two ways to insert the data:

  • Using the jobrunner. I'm guessing that's not the issue.
  • Using the maintenance script when we update the model. Since It might overlap with the job runner.

I'm not sure how we can avoid such cases.

Ladsgroup moved this task from Incoming to In progress on the User-Ladsgroup board.Sep 14 2016, 3:01 PM
Ladsgroup moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Sep 15 2016, 6:56 AM
Ladsgroup moved this task from In progress to Blocked on others on the User-Ladsgroup board.Sep 16 2016, 7:24 AM
Halfak mentioned this in T145356: Ensure ORES data violating constraints do not affect production.Sep 22 2016, 2:27 PM
gerritbot subscribed.Sep 22 2016, 5:52 PM

Change 312286 had a related patch set uploaded (by Ladsgroup):
Add maintenance/CleanDuplicateScores.php

https://gerrit.wikimedia.org/r/312286

gerritbot added a project: Patch-For-Review.Sep 22 2016, 5:52 PM
Halfak moved this task from Review to Completed on the Machine-Learning-Team (Active Tasks) board.Oct 3 2016, 4:33 PM
gerritbot added a comment.Oct 3 2016, 4:34 PM

Change 312286 merged by jenkins-bot:
Add maintenance/CleanDuplicateScores.php

https://gerrit.wikimedia.org/r/312286

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)).Oct 3 2016, 5:00 PM
gerritbot added a comment.Oct 5 2016, 1:07 PM

Change 314258 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Revert "Add maintenance/CleanDuplicateScores.php"

https://gerrit.wikimedia.org/r/314258

gerritbot added a comment.Oct 5 2016, 5:21 PM

Change 314258 abandoned by Thiemo Mättig (WMDE):
Revert "Add maintenance/CleanDuplicateScores.php"

Reason:
See Iadf3b00 instead.

https://gerrit.wikimedia.org/r/314258

Ladsgroup moved this task from Blocked on others to Done on the User-Ladsgroup board.Oct 6 2016, 6:12 PM
Halfak closed this task as Resolved.Oct 11 2016, 11:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL