Remove inline styling from NewSignupPage
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	SamanthaNguyen
	Oct 4 2016, 3:02 AM

Description

Result of a grep ran by ashley in T87148#1523869:

./NewSignupPage/NewSignupPage.js:                                       '<span id="existence-check-result" style="' + style + '">' +
./NewSignupPage/NewSignupPage.js:                               '<span id="password-match-check-result" style="padding: 2px; color: red">' +

Details

	Subject	Repo	Branch	Lines +/-
	Version 0.9.1: use the core-provided error message and error message CSS class instead of rolling out our own solution	mediawiki/extensions/NewSignupPage	master	+4 -6

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T154048 [EPIC] Clean up CSS for socials tools extensions
Open	None	T157256 [EPIC] Migrate inline code to appropriate files in social tools extensions
Open	None	T87148 [EPIC] Remove inline styling from Social Tools extensions
Resolved	ashley	T147255 Remove inline styling from NewSignupPage

Event Timeline

SamanthaNguyen created this task.Oct 4 2016, 3:02 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 4 2016, 3:02 AM

SamanthaNguyen updated the task description. (Show Details)Oct 4 2016, 3:06 AM

SamanthaNguyen added a parent task: T87148: [EPIC] Remove inline styling from Social Tools extensions .Oct 4 2016, 3:24 AM

SamanthaNguyen moved this task from Backlog to NewSignupPage on the Social-Tools board.Oct 4 2016, 3:27 AM

SamanthaNguyen moved this task from Backlog to Feedback on the NewSignupPage board.Oct 4 2016, 3:35 AM

Change 327931 had a related patch set uploaded (by Jack Phoenix):
Version 0.9.1: use the core-provided error message and error message CSS class instead of rolling out our own solution

https://gerrit.wikimedia.org/r/327931

gerritbot added a project: Patch-For-Review.Dec 17 2016, 12:28 PM

Change 327931 merged by jenkins-bot:
Version 0.9.1: use the core-provided error message and error message CSS class instead of rolling out our own solution

https://gerrit.wikimedia.org/r/327931

ashley closed this task as Resolved.Dec 17 2016, 12:33 PM

ashley claimed this task.

ashley removed a project: Patch-For-Review.

SamanthaNguyen added a project: CSS.Jan 7 2017, 11:13 PM