Maniphest T148465

ApiErrorFormatter_BackCompat::arrayFromStatus() tries to access protected StatusValue::$errors
Closed, InvalidPublic
Actions

Assigned To

Authored By

	Legoktm
	Oct 17 2016, 9:10 PM

Tags

Referenced Files

None

Subscribers

Related Objects

Mentioned Here: rMWc15caa6d53b4: Split StatusValue out of Status class and put it in /libs
rMW1c57794e371d: API: Overhaul ApiResult, make format=xml not throw, and add json formatversion

Event Timeline

Legoktm created this task.Oct 17 2016, 9:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 17 2016, 9:10 PM

It looks like rMWc15caa6d53b4: Split StatusValue out of Status class and put it in /libs removed the public errors member from Status without maintaining backwards compatibility like it did for most other members, and it wasn't noticed that this affected rMW1c57794e371d: API: Overhaul ApiResult, make format=xml not throw, and add json formatversion which was written first but merged after.

Actually, scratch that. Status::__get has the backwards compatibility, and it still works, which is why this hasn't been making unit tests fail.

ApiErrorFormatter_BackCompat::arrayFromStatus() doesn't accept a StatusValue, only a Status.

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:28 PM