Page MenuHomePhabricator

Maplink breaks when showing undefined groups
Closed, ResolvedPublic

Description

Steps to reproduce:

  • Create a page such as:
<maplink latitude="43.739" longitude="43.528" zoom="7" show="a,b,c,d"/>
  • Refresh the page, click on the link.
  • The map may not appear at all
  • Seeing in the console::
VM2434:1 Uncaught SyntaxError: Unexpected token u in JSON at position 0

Although this sounds like a corner case at first, I noticed it on Russian Wikivoyage... The maplink in the corner is broken. This makes it a very high priority bug :/

Details

Related Gerrit Patches:
mediawiki/extensions/Kartographer : masterUpgrade data lib to fix bug when API returns no data for groups

Event Timeline

Restricted Application added a project: Discovery. · View Herald TranscriptOct 21 2016, 12:56 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 317092 had a related patch set uploaded (by JGirault):
Upgrade data lib to fix bug when API returns no data for groups

https://gerrit.wikimedia.org/r/317092

JGirault moved this task from Backlog to Needs review on the Maps-Sprint board.Oct 21 2016, 12:59 AM

Change 317092 merged by jenkins-bot:
Upgrade data lib to fix bug when API returns no data for groups

https://gerrit.wikimedia.org/r/317092

Yurik closed this task as Resolved.Oct 21 2016, 5:02 AM