Page MenuHomePhabricator

WebResponse->setcookie() should handle prefixes
Closed, ResolvedPublic

Description

Author: ezyang

Description:
Except under special cases (such as when the cookie needs to be shared with some other software), all cookies should be prefixed with $wgCookiePrefix (a quick grep indicates that this is indeed the case for all existing code). I propose that WebResponse->setcookie() should automatically handle prefixes. In addition, all of the stray setcookie() calls should be using $wgRequest->response()->setcookie() instead.

Do you think this is a good idea?


Version: 1.12.x
Severity: enhancement
URL: http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/WebResponse.php?view=markup

Details

Reference
bz12976

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:03 PM
bzimport set Reference to bz12976.
bzimport added a subscriber: Unknown Object (MLST).