[Bug] fatal PageImages Call to a member function getUrl() on a non-object (boolean)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Matanya
	Nov 2 2016, 9:30 PM

Description

Stack trace:

{ "file": "/srv/mediawiki/php-1.29.0-wmf.1/extensions/PageImages/includes/ApiQueryPageImages.php", "line": 128, "function": "setResultValues", "class": "ApiQueryPageImages", "type": "->", "args": [ "array", "integer", "string", "integer" ] }, { "file": "/srv/mediawiki/php-1.29.0-wmf.1/includes/api/ApiQuery.php", "line": 251, "function": "execute", "class": "ApiQueryPageImages", "type": "->", "args": [] }, { "file": "/srv/mediawiki/php-1.29.0-wmf.1/includes/api/ApiMain.php", "line": 1435, "function": "execute", "class": "ApiQuery", "type": "->", "args": [] }, { "file": "/srv/mediawiki/php-1.29.0-wmf.1/includes/api/ApiMain.php", "line": 510, "function": "executeAction", "class": "ApiMain", "type": "->", "args": [] }, { "file": "/srv/mediawiki/php-1.29.0-wmf.1/includes/api/ApiMain.php", "line": 481, "function": "executeActionWithErrorHandling", "class": "ApiMain", "type": "->", "args": [] }, { "file": "/srv/mediawiki/php-1.29.0-wmf.1/api.php", "line": 83, "function": "execute", "class": "ApiMain", "type": "->", "args": [] }, { "file": "/srv/mediawiki/w/api.php", "line": 3, "function": "include", "args": [ "string" ] }

reproduce:
https://commons.wikimedia.org/w/api.php?action=query&prop=revisions|pageimages&piprop=original&continue=&rvprop=timestamp|user|userid|content&format=xml&rvgeneratexml&titles=File:Merval+(Aisne)+école+++mairie.JPG

Revisions and Commits

rEPIM extension-PageImages
	rEPIMbc543f73c33d Don't attempt to call methods on $file if it's not an object
	rEPIMaa5b08acf66c Don't attempt to call methods on $file if it's not an object
	rEPIMc399c4156eea Don't attempt to call methods on $file if it's not an object

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• mmodell	T149059 MW-1.29.0-wmf.1 deployment blockers
		Resolved		• mmodell	T149849 [Bug] fatal PageImages Call to a member function getUrl() on a non-object (boolean)

Event Timeline

Matanya created this task.Nov 2 2016, 9:30 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 2 2016, 9:30 PM

Matanya added a parent task: T149059: MW-1.29.0-wmf.1 deployment blockers.Nov 2 2016, 9:30 PM

Patch incoming

Commit: rEPIMaa5b08acf66c: Don't attempt to call methods on $file if it's not an object ( gerrit change 319643 )

• mmodell triaged this task as Medium priority.Nov 3 2016, 6:37 PM

• mmodell added a project: Patch-For-Review.Nov 3 2016, 6:59 PM

Mentioned in SAL (#wikimedia-operations) [2016-11-03T19:17:57Z] <Krenair> <twentyafterfour> !log In order to unblock the train for group2: deploying https://gerrit.wikimedia.org/r/#/c/319643/ refs T149059, T149849

• mmodell closed this task as Resolved by committing rEPIMc399c4156eea: Don't attempt to call methods on $file if it's not an object.Nov 3 2016, 7:26 PM

• mmodell added a commit: rEPIMc399c4156eea: Don't attempt to call methods on $file if it's not an object.

• mmodell added a commit: rEPIMaa5b08acf66c: Don't attempt to call methods on $file if it's not an object.

Mentioned in SAL (#wikimedia-operations) [2016-11-03T19:28:56Z] <twentyafterfour@tin> Synchronized php-1.29.0-wmf.1/extensions/PageImages/includes/ApiQueryPageImages.php: T149849 (duration: 00m 47s)

Confirmed fixed (the reproduce url works now)

• mmodell added a commit: rEPIMbc543f73c33d: Don't attempt to call methods on $file if it's not an object.Nov 7 2016, 5:54 PM

[Bug] fatal PageImages Call to a member function getUrl() on a non-object (boolean)Closed, ResolvedPublicActions

Description

Revisions and Commits

Related ObjectsSearch...

Event Timeline

[Bug] fatal PageImages Call to a member function getUrl() on a non-object (boolean)
Closed, ResolvedPublic
Actions

Related Objects
Search...