Page MenuHomePhabricator
Create Task
Maniphest T150846

Flip toggle button when using pin button for expansion
Closed, ResolvedPublic
Actions

Description

Reported by @thimeowmde:

Close the slider. The arrow points down. Click the pin. The slider
opens but the arrow does not change. Now you have to click the arrow
two times to make it point into the right direction again.

Details

SubjectRepoBranchLines +/-
Flip toggle button in 2 missing casesmediawiki/extensions/RevisionSlidermaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

Tobi_WMDE_SW created this task.Nov 16 2016, 11:10 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 16 2016, 11:10 AM
Addshore moved this task from Incoming to Revision Slider on the TCB-Team (now WMDE-TechWish) board.Nov 17 2016, 9:29 AM
Addshore claimed this task.Nov 17 2016, 10:47 AM
Addshore added a project: User-Addshore.
Addshore moved this task from Unsorted 💣 to Back Burner 🏛️ on the User-Addshore board.
Addshore moved this task from Todo to Sprint ready on the WMDE-TechWish board.

This occours in even more cases, for example, if you have the slider pinned it will load the arrow pointing down and will continue having the tooltip saying "open the slider"

gerritbot subscribed.Nov 17 2016, 11:01 AM

Change 322077 had a related patch set uploaded (by Addshore):
Flip toggle button in 2 missing cases

https://gerrit.wikimedia.org/r/322077

gerritbot added a project: Patch-For-Review.Nov 17 2016, 11:01 AM
Addshore moved this task from Back Burner 🏛️ to Active 🚁 on the User-Addshore board.Nov 17 2016, 11:01 AM
Addshore moved this task from Sprint ready to Currently in sprint on the WMDE-TechWish board.
Addshore mentioned this in rERSLfc213c88809a: Flip toggle button in 2 missing cases.Nov 17 2016, 11:09 AM
Tobi_WMDE_SW closed this task as Resolved.Nov 17 2016, 11:34 AM
Tobi_WMDE_SW moved this task from Currently in sprint to Done on the WMDE-TechWish board.
Addshore moved this task from Active 🚁 to Closing ✔️ on the User-Addshore board.Nov 17 2016, 11:35 AM
gerritbot added a comment.Nov 17 2016, 11:36 AM

Change 322077 merged by jenkins-bot:
Flip toggle button in 2 missing cases

https://gerrit.wikimedia.org/r/322077

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)).Nov 17 2016, 12:00 PM
Addshore moved this task from Done to Demoed on the WMDE-TechWish board.Nov 22 2016, 3:09 PM
Tobi_WMDE_SW moved this task from Incoming to Done on the Revision-Slider board.Dec 2 2016, 12:39 PM
Tobi_WMDE_SW removed a project: WMDE-TechWish.Jun 7 2017, 12:01 PM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 3:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL