Page MenuHomePhabricator
Create Task
Maniphest T151216

System messages are too CAPTCHA module specific
Closed, ResolvedPublic
Actions

Description

The following system messages refer to a CAPTCHA to be calculated (SimpleCaptcha and MathCaptcha). This does not really fit for other CAPTCHA modules like FancyCaptcha, and QuestyCapcha etc.

  • MediaWiki:Captcha-createaccount
  • MediaWiki:Captcha-badlogin
  • MediaWiki:Captcha-sendemail
  • MediaWiki:Captcha-addurl

I guess it will be great to have these messages less CAPTCHA module specific.

Details

SubjectRepoBranchLines +/-
Simplify system messages to fit for other CAPTCHA modulesmediawiki/extensions/ConfirmEditmaster+6 -6
Customize query in gerrit

Event Timeline

Kghbln created this task.Nov 21 2016, 4:39 PM
Restricted Application added subscribers: Florian, Aklapper. · View Herald TranscriptNov 21 2016, 4:39 PM
Florian triaged this task as Medium priority.Nov 24 2016, 7:50 PM
Florian added a project: Google-Code-In-2016.

This sounds like a task for GCI! :D I'll mentor it :)

Florian moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-In-2016 board.Nov 24 2016, 7:54 PM

-> https://codein.withgoogle.com/dashboard/tasks/5098096446930944/

Kghbln added a comment.Nov 26 2016, 10:02 PM

This sounds like a task for GCI! :D I'll mentor it :)

@Florian Great, thanks for triaging and the info. Happy mentoring!

Kghbln awarded a token.Nov 26 2016, 10:02 PM
divadsn claimed this task.Dec 2 2016, 12:20 PM
divadsn subscribed.

I am working to fix this. Will claim it on GCI after my parental consent has been approved.

divadsn added a comment.Dec 2 2016, 8:42 PM

Task has been claimed, patch coming soon.

gerritbot subscribed.Dec 2 2016, 10:26 PM

Change 325045 had a related patch set uploaded (by Divadsn):
Simplify system messages to fit for other CAPTCHA modules

https://gerrit.wikimedia.org/r/325045

gerritbot added a project: Patch-For-Review.Dec 2 2016, 10:26 PM
Florian closed this task as Resolved.Dec 2 2016, 10:51 PM
Kghbln added a comment.Dec 2 2016, 10:56 PM

Great and thanks a lot! Now we are cool! :)

gerritbot added a comment.Dec 2 2016, 11:02 PM

Change 325045 merged by jenkins-bot:
Simplify system messages to fit for other CAPTCHA modules

https://gerrit.wikimedia.org/r/325045

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)).Dec 3 2016, 12:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL