Page MenuHomePhabricator

divadsn (David Sn)
Google Code-in 2017 Student

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Nov 30 2016, 9:38 AM (154 w, 5 d)
Availability
Available
IRC Nick
divadsn
LDAP User
Unknown
MediaWiki User
Divadsn [ Global Accounts ]

Turns caffeine and pizza into code.

Recent Activity

Jul 15 2018

divadsn added a comment to T199511: Security review for fluidsynth.

@Legoktm those benchmark results are a bit old, while fluidsynth might got an update, I can update them if required :)

Jul 15 2018, 9:18 PM · MediaWiki-extensions-Score, Security-Team, Security-Team-Reviews

Jun 11 2018

Gerrit Code Review <gerrit@wikimedia.org> committed rEARAdc9d4b69768c: Final NoteDb migration updates (authored by divadsn).
Final NoteDb migration updates
Jun 11 2018, 6:33 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEARAd0a5e56a405b: Create change (authored by divadsn).
Create change
Jun 11 2018, 6:33 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEIDS424023f32ca6: Final NoteDb migration updates (authored by divadsn).
Final NoteDb migration updates
Jun 11 2018, 11:14 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEIDSbc4465169603: Update patch set 5 (authored by divadsn).
Update patch set 5
Jun 11 2018, 11:14 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEIDSef59f5900dfe: Update patch set 3 (authored by divadsn).
Update patch set 3
Jun 11 2018, 11:14 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEIDSf629200900db: Create patch set 4 (authored by divadsn).
Create patch set 4
Jun 11 2018, 11:14 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEIDSf8eed8bf607a: Create patch set 3 (authored by divadsn).
Create patch set 3
Jun 11 2018, 11:14 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEIDS34b291a39bc9: Update patch set 2 (authored by divadsn).
Update patch set 2
Jun 11 2018, 11:14 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEIDS130a10fcc816: Create patch set 2 (authored by divadsn).
Create patch set 2
Jun 11 2018, 11:14 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEIDS5c6a1b8c6b8f: Create change (authored by divadsn).
Create change
Jun 11 2018, 11:14 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGc3e83a40255f: Final NoteDb migration updates (authored by divadsn).
Final NoteDb migration updates
Jun 11 2018, 5:04 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG3de474c9d5c7: Create patch set 4 (authored by divadsn).
Create patch set 4
Jun 11 2018, 5:04 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGa60aa4f6962e: Update patch set 3 (authored by divadsn).
Update patch set 3
Jun 11 2018, 5:04 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG8f49e27a1841: Create patch set 3 (authored by divadsn).
Create patch set 3
Jun 11 2018, 5:04 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGcb52d88082ef: Create patch set 2 (authored by divadsn).
Create patch set 2
Jun 11 2018, 5:04 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG2d799ef56d7e: Create change (authored by divadsn).
Create change
Jun 11 2018, 5:04 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG91ceb59696c7: Final NoteDb migration updates (authored by divadsn).
Final NoteDb migration updates
Jun 11 2018, 5:03 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG863cb23a3ddc: Update patch set 2 (authored by divadsn).
Update patch set 2
Jun 11 2018, 5:03 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGe8c2d05986ed: Update patch set 2 (authored by divadsn).
Update patch set 2
Jun 11 2018, 5:03 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG9a0492000e20: Create patch set 2 (authored by divadsn).
Create patch set 2
Jun 11 2018, 5:03 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGa4e5f4865095: Update patch set 1 (authored by divadsn).
Update patch set 1
Jun 11 2018, 5:03 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG3010ac5149e5: Create change (authored by divadsn).
Create change
Jun 11 2018, 5:03 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG648a83335565: Final NoteDb migration updates (authored by divadsn).
Final NoteDb migration updates
Jun 11 2018, 5:02 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG71b57d25616b: Create change (authored by divadsn).
Create change
Jun 11 2018, 5:02 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG041d35af2cc5: Final NoteDb migration updates (authored by divadsn).
Final NoteDb migration updates
Jun 11 2018, 5:02 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGd5f52d548e7a: Update patch set 7 (authored by divadsn).
Update patch set 7
Jun 11 2018, 5:02 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG62a8c96e43d8: Update patch set 7 (authored by divadsn).
Update patch set 7
Jun 11 2018, 5:02 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGcb0a35bb97c4: Create patch set 7 (authored by divadsn).
Create patch set 7
Jun 11 2018, 5:02 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG63f2525deced: Create patch set 6 (authored by divadsn).
Create patch set 6
Jun 11 2018, 5:02 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG138cc4b24dff: Create patch set 5 (authored by divadsn).
Create patch set 5
Jun 11 2018, 5:02 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGa91887ef9620: Create patch set 4 (authored by divadsn).
Create patch set 4
Jun 11 2018, 5:02 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGe3dbef6f3926: Update patch set 3 (authored by divadsn).
Update patch set 3
Jun 11 2018, 5:02 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGd4f2c85d2fc3: Create patch set 3 (authored by divadsn).
Create patch set 3
Jun 11 2018, 5:02 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG83becb4f3388: Update patch set 2 (authored by divadsn).
Update patch set 2
Jun 11 2018, 5:02 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGbef76d6e8615: Create patch set 2 (authored by divadsn).
Create patch set 2
Jun 11 2018, 5:02 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGedc42449bc03: Create change (authored by divadsn).
Create change
Jun 11 2018, 5:02 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBTF74c2227be6c7: Final NoteDb migration updates (authored by divadsn).
Final NoteDb migration updates
Jun 11 2018, 2:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBTFfe454bab9de1: Update patch set 2 (authored by divadsn).
Update patch set 2
Jun 11 2018, 2:50 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBTFd0068e1f4bf9: Update patch set 2 (authored by divadsn).
Update patch set 2
Jun 11 2018, 2:50 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBTF23885da24dd3: Create patch set 2 (authored by divadsn).
Create patch set 2
Jun 11 2018, 2:50 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBTF2513be53aeef: Create change (authored by divadsn).
Create change
Jun 11 2018, 2:50 AM

Jun 10 2018

Gerrit Code Review <gerrit@wikimedia.org> committed rEENF79feb17e2e92: Final NoteDb migration updates (authored by divadsn).
Final NoteDb migration updates
Jun 10 2018, 2:06 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEENF7f33807d3e2d: Create patch set 3 (authored by divadsn).
Create patch set 3
Jun 10 2018, 2:06 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEENF06b3f9cc132a: Create patch set 2 (authored by divadsn).
Create patch set 2
Jun 10 2018, 2:06 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEENF4bcc75a7dde9: Create change (authored by divadsn).
Create change
Jun 10 2018, 2:06 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rERSLed854fa8f323: Update patch set 15 (authored by divadsn).
Update patch set 15
Jun 10 2018, 3:43 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rERSL1e6cb50dc404: Update patch set 14 (authored by divadsn).
Update patch set 14
Jun 10 2018, 3:43 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rERSLc82dcf0bd242: Update patch set 13 (authored by divadsn).
Update patch set 13
Jun 10 2018, 3:43 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rERSL48e3ebc0bfae: Update patch set 13 (authored by divadsn).
Update patch set 13
Jun 10 2018, 3:43 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rERSL1f6dc202cf4f: Update patch set 13 (authored by divadsn).
Update patch set 13
Jun 10 2018, 3:43 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rERSL83afbe8c3849: Update patch set 11 (authored by divadsn).
Update patch set 11
Jun 10 2018, 3:43 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rERSLef0e5003c6f0: Update patch set 6 (authored by divadsn).
Update patch set 6
Jun 10 2018, 3:43 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rERSLbfbd349a6de4: Update patch set 4 (authored by divadsn).
Update patch set 4
Jun 10 2018, 3:43 AM

Jun 9 2018

Gerrit Code Review <gerrit@wikimedia.org> committed rEBSJ8fca5d7707f5: Final NoteDb migration updates (authored by divadsn).
Final NoteDb migration updates
Jun 9 2018, 5:16 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBSJ8033ec6d96b9: Update patch set 2 (authored by divadsn).
Update patch set 2
Jun 9 2018, 5:16 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBSJbbb805d27f67: Create patch set 2 (authored by divadsn).
Create patch set 2
Jun 9 2018, 5:16 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBSJ6afbca8b4553: Create change (authored by divadsn).
Create change
Jun 9 2018, 5:16 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBSW9a85aa1745f8: Final NoteDb migration updates (authored by divadsn).
Final NoteDb migration updates
Jun 9 2018, 1:58 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBSW98b999e44843: Update patch set 3 (authored by divadsn).
Update patch set 3
Jun 9 2018, 1:58 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBSW305258f2ffb7: Create patch set 3 (authored by divadsn).
Create patch set 3
Jun 9 2018, 1:58 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBSWf85b4e8b8623: Create patch set 2 (authored by divadsn).
Create patch set 2
Jun 9 2018, 1:58 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBSWed398127e388: Create change (authored by divadsn).
Create change
Jun 9 2018, 1:58 PM

Jun 8 2018

Gerrit Code Review <gerrit@wikimedia.org> committed rEBSNdd5cd9794431: Final NoteDb migration updates (authored by divadsn).
Final NoteDb migration updates
Jun 8 2018, 11:54 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBSN60baf0a5e76b: Create patch set 2 (authored by divadsn).
Create patch set 2
Jun 8 2018, 11:54 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBSNc09c490ff0e7: Update patch set 2 (authored by divadsn).
Update patch set 2
Jun 8 2018, 11:54 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBSN0743a4ac2e64: Create change (authored by divadsn).
Create change
Jun 8 2018, 11:54 PM

Jan 23 2018

divadsn updated subscribers of T181738: Google Code-in 2017: Collect Feedback and Lessons Learned.

Here are some thoughts from my side as a GCI participant:

Jan 23 2018, 12:31 AM · Google-Code-in-2017, Developer-Advocacy (Jan-Mar-2018)

Jan 22 2018

divadsn added a comment to T185447: Update Phabricator OAuth scopes in documentation.

Is this about some local change specific to Wikimedia's instance of Phabricator, or does this apply to any Phabricator in general (which would make this an upstream issue)?

Jan 22 2018, 4:07 PM · Phabricator (Upstream), Upstream
divadsn triaged T185447: Update Phabricator OAuth scopes in documentation as Low priority.
Jan 22 2018, 8:53 AM · Phabricator (Upstream), Upstream
divadsn added a comment to T185447: Update Phabricator OAuth scopes in documentation.

Looking at the current source of Phabricator on GitHub, the "required" scope for user.whoami is referring to self::SCOPE_ALWAYS, therefore the docs for https://github.com/ofbeaton/oauth2-phabricator should be updated to list that scope.

Jan 22 2018, 8:51 AM · Phabricator (Upstream), Upstream
divadsn added a parent task for T185447: Update Phabricator OAuth scopes in documentation: T179202: Create Phabricator backend for python-social-auth.
Jan 22 2018, 8:41 AM · Phabricator (Upstream), Upstream
divadsn added a subtask for T179202: Create Phabricator backend for python-social-auth: T185447: Update Phabricator OAuth scopes in documentation.
Jan 22 2018, 8:41 AM · Google-Code-in-2017, Phabricator
divadsn created T185447: Update Phabricator OAuth scopes in documentation.
Jan 22 2018, 8:40 AM · Phabricator (Upstream), Upstream

Jan 21 2018

TheDJ awarded T181897: Migrate TiMidity++ to fluidsynth a Mountain of Wealth token.
Jan 21 2018, 5:19 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Patch-For-Review, Google-Code-in-2017, TimedMediaHandler, MediaWiki-extensions-Score
divadsn added a comment to T181897: Migrate TiMidity++ to fluidsynth.

Added missing documentation to the extension wiki page:
https://www.mediawiki.org/w/index.php?title=Extension:Score&oldid=2697225

Jan 21 2018, 2:43 AM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Patch-For-Review, Google-Code-in-2017, TimedMediaHandler, MediaWiki-extensions-Score

Jan 19 2018

divadsn updated subscribers of T185317: AssertionError in test_invalid_isbn.

@Dalba ok, that's a point, but now why the revert?
That patch could be fixed with a follow-up, which would be simply adding a |Invalid ISBN found to the regex, why not instead?

IMO, https://gerrit.wikimedia.org/r/#/c/399348/ was more deserved to be merged. It was submitted before your patch and it did not have this issue.

But it had other issue and the author wasn't doing anything for a month since that day, that's why I took it up and made mine when working on the task with @jayvdb as mentor.

Jan 19 2018, 10:46 PM · Patch-For-Review, Pywikibot, Pywikibot-tests
divadsn added a comment to T185317: AssertionError in test_invalid_isbn.

@Dalba ok, that's a point, but now why the revert?

Jan 19 2018, 9:22 PM · Patch-For-Review, Pywikibot, Pywikibot-tests
divadsn added a comment to T185317: AssertionError in test_invalid_isbn.
Jan 19 2018, 8:02 PM · Patch-For-Review, Pywikibot, Pywikibot-tests
divadsn added a comment to T185317: AssertionError in test_invalid_isbn.

Afaik it's usually supposed to install all needed requirements from the requirements.txt, but I may be wrong here.

Jan 19 2018, 8:02 PM · Patch-For-Review, Pywikibot, Pywikibot-tests
divadsn added a comment to T185317: AssertionError in test_invalid_isbn.

Running on Windows, make sure you don't have python-stdnum installed.

Jan 19 2018, 7:25 PM · Patch-For-Review, Pywikibot, Pywikibot-tests
divadsn added a comment to T168716: Mobile infobox styles do not work well with multiple column infobox rows.

@Jdlrobson, do we have a target article for this test on Staging? I have been looking for an article using the template in question, but I have not found one.

Jan 19 2018, 7:18 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Readers-Web-Kanbanana-Board-Old, Patch-For-Review, Google-Code-in-2017, patch-welcome, MinervaNeue, Readers-Web-Backlog, Design, Mobile

Jan 17 2018

divadsn added a comment to T179000: Blog about your GCI experience (findings and learnings) with Wikimedia [recurring].

I wrote my blog post in English, it lacks a bit at the end, but ready for the public :)
https://www.codebucket.de/blog/contest/2018/01/17/google-code-in-2017-and-the-future.html

Jan 17 2018, 5:04 PM · Google-Code-in-2017

Jan 15 2018

divadsn claimed T177205: Abusefilter blocking adding GCI 2017 mentors to wiki page.

I made my suggestion over at the discussion page, hope it will be fixed soon :)
https://www.mediawiki.org/wiki/MediaWiki_talk:Titleblacklist#Google_misspelling_pattern_matching_wrong_for_Talk:_pages

Jan 15 2018, 10:45 AM · Developer-Advocacy (Oct-Dec 2017), Google-Code-in-2017
divadsn added a comment to T177205: Abusefilter blocking adding GCI 2017 mentors to wiki page.

11:06:35 <RexxS> divadsn: the blacklisting of a title is via the Extension:TitleBlacklist - https://www.mediawiki.org/wiki/Extension:TitleBlacklist

Jan 15 2018, 10:29 AM · Developer-Advocacy (Oct-Dec 2017), Google-Code-in-2017
divadsn added a comment to T177205: Abusefilter blocking adding GCI 2017 mentors to wiki page.

This filter might be present here: https://www.wikidata.org/wiki/Special:AbuseFilter

Jan 15 2018, 10:03 AM · Developer-Advocacy (Oct-Dec 2017), Google-Code-in-2017

Jan 13 2018

divadsn added a comment to T168716: Mobile infobox styles do not work well with multiple column infobox rows.

I'm sorry that I've overlooked the basic styling of those elements, now I re-done the patch and kept those styles in tact, only changed the scaling behavior.

Jan 13 2018, 8:16 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Readers-Web-Kanbanana-Board-Old, Patch-For-Review, Google-Code-in-2017, patch-welcome, MinervaNeue, Readers-Web-Backlog, Design, Mobile
divadsn updated the task description for T154281: [recurring] Replace assertRaises with assertRaisesRegex.
Jan 13 2018, 5:32 PM · Pywikibot, Google-Code-in-2017, Patch-For-Review, Google-Code-In-2016, Pywikibot-tests
divadsn updated the task description for T154281: [recurring] Replace assertRaises with assertRaisesRegex.
Jan 13 2018, 5:31 PM · Pywikibot, Google-Code-in-2017, Patch-For-Review, Google-Code-In-2016, Pywikibot-tests

Jan 11 2018

divadsn closed T179202: Create Phabricator backend for python-social-auth as Resolved.

Closing as the original PR got merged a week ago.

Jan 11 2018, 3:24 PM · Google-Code-in-2017, Phabricator

Jan 10 2018

divadsn added a comment to T181875: Score should output MP3 files.

@Stemby MP3 files are better for mobile users from my experience when it comes to loading time and file size.

Jan 10 2018, 7:24 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, Google-Code-in-2017, TimedMediaHandler, MediaWiki-extensions-Score
divadsn committed rEBSWed8536d860e4: Add minus-x to composer.json (authored by divadsn).
Add minus-x to composer.json
Jan 10 2018, 6:48 PM
divadsn committed rEBSJ56ce2f386b44: Add minus-x to composer.json (authored by divadsn).
Add minus-x to composer.json
Jan 10 2018, 6:38 PM
divadsn committed rEBSW80af5884172c: Add minus-x to composer.json (authored by divadsn).
Add minus-x to composer.json
Jan 10 2018, 6:34 PM
divadsn committed rEBTFfe420b4430ac: Add minus-x to composer.json (authored by divadsn).
Add minus-x to composer.json
Jan 10 2018, 6:31 PM
divadsn committed rEBSN8e12370c3e85: Add minus-x to composer.json (authored by divadsn).
Add minus-x to composer.json
Jan 10 2018, 6:31 PM
divadsn closed T181875: Score should output MP3 files as Resolved.
Jan 10 2018, 1:10 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, Google-Code-in-2017, TimedMediaHandler, MediaWiki-extensions-Score
divadsn closed T181875: Score should output MP3 files, a subtask of T184598: Enable Score MP3 support for Wikimedia wikis, as Resolved.
Jan 10 2018, 1:10 PM · MediaWiki-extensions-Score
divadsn closed T181897: Migrate TiMidity++ to fluidsynth as Resolved.

Now it's possible to slowly migrate from TiMidity++ to Fluidsynth and then after a period of time drop support for TiMidity++ :)

Jan 10 2018, 1:10 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Patch-For-Review, Google-Code-in-2017, TimedMediaHandler, MediaWiki-extensions-Score
divadsn closed T181897: Migrate TiMidity++ to fluidsynth, a subtask of T181875: Score should output MP3 files, as Resolved.
Jan 10 2018, 1:10 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, Google-Code-in-2017, TimedMediaHandler, MediaWiki-extensions-Score