Page MenuHomePhabricator

Replace Kaltura player with Video.js
Open, NormalPublic

Tokens
"Love" token, awarded by Kristbaum."Love" token, awarded by MichaelSchoenitzer."100" token, awarded by divadsn."Orange Medal" token, awarded by Krinkle."Love" token, awarded by Liuxinyu970226."Yellow Medal" token, awarded by FoXFTW."Like" token, awarded by cscott."Mountain of Wealth" token, awarded by Reedy."Love" token, awarded by Qgil."Love" token, awarded by Bawolff.
Assigned To
Authored By
TheDJ, May 23 2015

Description

http://www.videojs.com looks nice. Let's play

Get your demo here !

Blockers

Enhancements Kultura had

TODO: create new tasks after Video.js becomes default

  • Make default resolution based on both thumbnail size + device pixel ratio (currently, only based on thumb size)
  • Remember user resolution override
  • Remember user last selected volume level https://github.com/theonion/videojs-persistvolume
  • Add a download button? (Native context menu "Save as.." might suffice, also download link exists on File info page)
  • End card showing title, author, etc (MediaViewer / Commons meta data) – http://theonion.github.io/videojs-endcard/

Ideas for later

  • Related videos
  • Replay button ChangeID
  • Airplay and Chromecast support
  • Poster for audio files (to essentially support adding audio underneath a thumbnail, e.g. in the infobox of a bird!)
  • Separate TMH playback technology so that Score extension can re-use the client-side player + maybe transcoding.

Related Objects

StatusAssignedTask
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
Openbrion
OpenNone
OpenNone
OpenNone
OpenNone
Openbrion
Resolvedbrion
OpenNone
OpenNone
OpenNone
ResolvedReedy
ResolvedTheDJ
Resolvedbrion
Resolvedbrion
ResolvedTheDJ
ResolvedTheDJ
OpenNone
ResolvedTheDJ
OpenNone
Resolvedbrion
Resolvedbrion
ResolvedTheDJ
OpenNone
Resolvedbrion
OpenNone

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
FoXFTW awarded a token.Dec 6 2016, 8:32 PM
Ltrlg added a subscriber: Ltrlg.Dec 28 2016, 2:26 PM
Fito added a subscriber: Fito.Jan 15 2017, 1:21 PM
Izno added a subscriber: Izno.Mar 23 2017, 10:29 PM
Krinkle removed a subscriber: Krinkle.Mar 25 2017, 3:46 AM
TheDJ removed TheDJ as the assignee of this task.Mar 28 2017, 8:04 PM
TheDJ added a subscriber: TheDJ.

I feel that having this on my name is potentially holding this ticket back. In my opinion, im not in a position to get this rolled out towards Wikimedia.

Aklapper added a project: Multimedia.EditedApr 26 2017, 6:28 PM

CC'ing Multimedia if they have any input / position on this regarding a potential future deployment. (see previous comment).

(For the broader picture: see T93544)

Krinkle updated the task description. (Show Details)May 19 2017, 2:56 PM
brion claimed this task.May 19 2017, 2:57 PM

I'll take over the rest of the cleanup for this, want to finally get it out the door soon :)

I've scheduled the Beta Feature to go live on Beta Cluster on Monday, and vaguely expected us to be able to actually release it in a week or so thereafter.

Krinkle updated the task description. (Show Details)May 19 2017, 3:06 PM
Krinkle updated the task description. (Show Details)May 19 2017, 3:11 PM
Krinkle updated the task description. (Show Details)May 19 2017, 3:31 PM
Krinkle updated the task description. (Show Details)May 19 2017, 3:34 PM
Krinkle updated the task description. (Show Details)May 19 2017, 3:55 PM
TheDJ updated the task description. (Show Details)May 19 2017, 4:29 PM
brion added a comment.May 19 2017, 4:51 PM

@Jdforrester-WMF an aggressive schedule. I might recommend pushing the beta rollout back a week, as I'll be on an airplane all Monday.

@brion we could try to update to videojs 6.x. from the changelog nothing really looks like breaking changes. Unless i read the thing wrong.

also videojs-offset has been updated for videojs 5 and 6.

Change 354564 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/extensions/TimedMediaHandler@master] Ensure parsercache consistency

https://gerrit.wikimedia.org/r/354564

Reedy added a comment.May 19 2017, 7:33 PM

@brion we could try to update to videojs 6.x. from the changelog nothing really looks like breaking changes. Unless i read the thing wrong.

also videojs-offset has been updated for videojs 5 and 6.

https://www.heavybit.com/library/podcasts/demuxed/ep-4-the-long-road-to-videojs-6/

Change 354564 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Ensure parsercache consistency

https://gerrit.wikimedia.org/r/354564

Paladox added a comment.EditedMay 19 2017, 8:07 PM

@brion we could try to update to videojs 6.x. from the changelog nothing really looks like breaking changes. Unless i read the thing wrong.

also videojs-offset has been updated for videojs 5 and 6.

https://www.heavybit.com/library/podcasts/demuxed/ep-4-the-long-road-to-videojs-6/

I just updated to it and it still works. No breakages. https://gerrit.wikimedia.org/r/#/c/314731/

brion added a comment.May 19 2017, 9:17 PM

Per IRC there are breakages with the videojs 6.1 update; at a minimum, the resolution switcher plugin's icon is missing.

brion added a comment.May 19 2017, 9:24 PM

Another problem: there's something wrong with block levels / paragraph wrapping.

This:

[[File:Folgers.ogv]]

[[File:Folgers.ogv]]

under videojs mode shows two copies of the video side-by-side but they should be in separate paragraphs due to the blank line in between.

Per IRC there are breakages with the videojs 6.1 update; at a minimum, the resolution switcher plugin's icon is missing.

See T165815: Update videojs to 6.1 and my attached patch.

TheDJ updated the task description. (Show Details)Jan 23 2018, 11:50 PM
TheDJ updated the task description. (Show Details)Jan 23 2018, 11:53 PM

Note it might be worth including the SRT to WebVTT converter server-side so people who have .srt files from another system can still import them without manually converting. Should probably check out the options on Amara etc.

We may want to consider either temp breaking the audio subtitles or doing a modal popup for the special case. todo -> decide :D

We may want to consider either temp breaking the audio subtitles or doing a modal popup for the special case. todo -> decide :D

In discussions, @TheDJ and I felt that temporarily breaking audio subtitles was the less-bad choice.

TheDJ updated the task description. (Show Details)Feb 1 2018, 11:14 AM
TheDJ added a comment.EditedFeb 6 2018, 3:43 PM

On the topic of audio subtitles:
https://github.com/walsh9/videojs-transcript

This is an old transcript videojs transcript module, which might be usable for some inspiration for audio subtitling (demo)

Another demo for able player: https://ableplayer.github.io/ableplayer/demos/audio4.html

What if we always open the player in MMV, then scroll the transcript inside MMV...

Krinkle raised the priority of this task from Low to Normal.Mar 19 2019, 3:09 PM

Change 511331 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/extensions/TimedMediaHandler@master] Remove responsive-layout module

https://gerrit.wikimedia.org/r/511331

Change 511331 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Remove responsive-layout module

https://gerrit.wikimedia.org/r/511331